diff options
| author | Richard Jones <rjones@redhat.com> | 2010-05-13 09:56:27 +0100 |
|---|---|---|
| committer | Richard Jones <rjones@redhat.com> | 2010-05-13 17:08:02 +0100 |
| commit | 55748a94bc840ac07d3c211119372cd16b31f1a0 (patch) | |
| tree | e4bbe67298d63e646f13d1ae3d2f305248503d0f /daemon/m4/gnulib-cache.m4 | |
| parent | b76fd51e142494058ca0082b547aa5e747ad4b79 (diff) | |
| download | libguestfs-55748a94bc840ac07d3c211119372cd16b31f1a0.tar.gz libguestfs-55748a94bc840ac07d3c211119372cd16b31f1a0.tar.xz libguestfs-55748a94bc840ac07d3c211119372cd16b31f1a0.zip | |
Improve errors from tar-in/tgz-in commands (RHBZ#591155 RHBZ#591250).
This commit improves the error messages from the tar-in, tgz-in (etc)
commands by capturing the stderr from the tar command in a file and
sending that back in the error message.
The method used for the error file is primitive, and there is a case
for a more generic error file mechanism, but this will do for now.
Sample error messages after this change:
$ virt-tar -u /tmp/test1.img /tmp/not.tar /
tar_in: tar subcommand failed on directory: /: tar: This does not look like a tar archive
tar: Skipping to next header
tar: Exiting with failure status due to previous errors at /home/rjones/d/libguestfs/tools/virt-tar line 247.
$ virt-tar -u /tmp/test1.img /tmp/test.tar /
tar_in: tar subcommand failed on directory: /: tar: access.log: Cannot open: Read-only file system
tar: Exiting with failure status due to previous errors at /home/rjones/d/libguestfs/tools/virt-tar line 247.
Diffstat (limited to 'daemon/m4/gnulib-cache.m4')
| -rw-r--r-- | daemon/m4/gnulib-cache.m4 | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/daemon/m4/gnulib-cache.m4 b/daemon/m4/gnulib-cache.m4 index 91c6ac22..f026cb33 100644 --- a/daemon/m4/gnulib-cache.m4 +++ b/daemon/m4/gnulib-cache.m4 @@ -15,7 +15,7 @@ # Specification in the form of a command-line invocation: -# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl byteswap c-ctype connect fsusage futimens getaddrinfo getline glob hash ignore-value manywarnings mkdtemp netdb openat perror pread readlink select sleep socket strchrnul strndup symlinkat sys_select sys_wait vasprintf warnings +# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl byteswap c-ctype connect error fsusage futimens getaddrinfo getline glob hash ignore-value manywarnings mkdtemp netdb openat perror pread read-file readlink select sleep socket strchrnul strndup symlinkat sys_select sys_wait vasprintf warnings # Specification in the form of a few gnulib-tool.m4 macro invocations: gl_LOCAL_DIR([]) @@ -37,6 +37,7 @@ gl_MODULES([ openat perror pread + read-file readlink select sleep |