diff options
| author | Richard W.M. Jones <rjones@redhat.com> | 2010-10-22 12:13:07 +0100 |
|---|---|---|
| committer | Richard W.M. Jones <rjones@redhat.com> | 2010-10-23 16:03:10 +0100 |
| commit | cf4ce99a68626582c0870df30115273284a0960e (patch) | |
| tree | 2d9e17021b288da93c8cfc78d07d7949b5e9a8cd | |
| parent | fb614e1b7e8c65c5978b0290806be2f93231cc8b (diff) | |
| download | libguestfs-cf4ce99a68626582c0870df30115273284a0960e.tar.gz libguestfs-cf4ce99a68626582c0870df30115273284a0960e.tar.xz libguestfs-cf4ce99a68626582c0870df30115273284a0960e.zip | |
inspector: Add comment about why --fish option implies write mode.
(cherry picked from commit 2109d8d86aeb66093e0a9f41d3693693e3df66d5)
| -rwxr-xr-x | inspector/virt-inspector | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/inspector/virt-inspector b/inspector/virt-inspector index dc15f0db..60d5869a 100755 --- a/inspector/virt-inspector +++ b/inspector/virt-inspector @@ -200,7 +200,15 @@ if ($version) { pod2usage (__"virt-inspector: no image or VM names given") if @ARGV == 0; my $rw = 0; + +# XXX This is a bug: Originally we intended to open the guest with +# rw=>1 in order to tell Sys::Guestfs::Lib that we should disallow +# active domains. However this also has the effect of opening the +# disk image in write mode, and in any case we don't use this option +# in guestfish any more since we moved all the inspection code into +# the core library. We should drop the fish output modes completely. $rw = 1 if $output eq "fish"; + my $g; my @images; if ($uri) { |