diff options
| author | Jim Meyering <meyering@redhat.com> | 2009-08-18 14:55:59 +0200 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2009-08-18 17:20:06 +0200 |
| commit | 1d8afa2416416acaf8b7ffc500cadfde13e3aca3 (patch) | |
| tree | 778d5b2f163c66cbcf5ce89f680860cef2632ccb | |
| parent | 53ce488f380e3dd94c26bf507c5639975125a1ee (diff) | |
| download | libguestfs-1d8afa2416416acaf8b7ffc500cadfde13e3aca3.tar.gz libguestfs-1d8afa2416416acaf8b7ffc500cadfde13e3aca3.tar.xz libguestfs-1d8afa2416416acaf8b7ffc500cadfde13e3aca3.zip | |
build: suppress an ignored-write-return-value warning
* bootstrap (modules): Add ignore-value.
* src/guestfs.c: Include "ignore-value.h".
(stdout_event): Ignore failure to write to stderr.
Also, prefer STDERR_FILENO over the literal "2".
* src/Makefile.am (libguestfs_la_CPPFLAGS): Include gnulib's .h files.
(libprotocol_la_CFLAGS): Remove -Wall -Wno-unused.
| -rwxr-xr-x | bootstrap | 1 | ||||
| -rw-r--r-- | src/Makefile.am | 4 | ||||
| -rw-r--r-- | src/guestfs.c | 3 |
3 files changed, 6 insertions, 2 deletions
@@ -53,6 +53,7 @@ modules=' gitlog-to-changelog gnu-make gnumakefile +ignore-value maintainer-makefile manywarnings warnings diff --git a/src/Makefile.am b/src/Makefile.am index 9eb71b9a..8d03a77c 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -54,7 +54,7 @@ libprotocol_la_SOURCES = \ guestfs_protocol.c \ guestfs_protocol.h -libprotocol_la_CFLAGS = -Wall -Wno-unused +libprotocol_la_CFLAGS = $(BUILT_SOURCES): stamp-generator @@ -117,6 +117,8 @@ libguestfs_la_LIBADD = libprotocol.la libguestfs_la_CFLAGS = -Wall -DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"' +libguestfs_la_CPPFLAGS = -I$(top_srcdir)/gnulib/lib + if HAVE_RPCGEN guestfs_protocol.c: guestfs_protocol.x rm -f $@-t $@-t2 diff --git a/src/guestfs.c b/src/guestfs.c index ad3980ff..ecdf9e58 100644 --- a/src/guestfs.c +++ b/src/guestfs.c @@ -59,6 +59,7 @@ #include "guestfs.h" #include "guestfs_protocol.h" +#include "ignore-value.h" #ifdef HAVE_GETTEXT #include "gettext.h" @@ -1697,7 +1698,7 @@ stdout_event (struct guestfs_main_loop *ml, guestfs_h *g, void *data, /* In verbose mode, copy all log messages to stderr. */ if (g->verbose) - write (2, buf, n); + ignore_value (write (STDERR_FILENO, buf, n)); /* It's an actual log message, send it upwards if anyone is listening. */ if (g->log_message_cb) |