diff options
| author | Richard Jones <rjones@redhat.com> | 2010-06-16 15:25:45 +0100 |
|---|---|---|
| committer | Richard Jones <rjones@redhat.com> | 2010-06-16 15:32:20 +0100 |
| commit | 1079f74704a06c06996e547fdecf20a8f92799c6 (patch) | |
| tree | 32b272a9b86952f06f8565526c1fe5d8cf09bee7 /.gitignore | |
| parent | 1e568f057e8bb7b36cc14e0e531d74b75ad9cb6c (diff) | |
| download | libguestfs-1079f74704a06c06996e547fdecf20a8f92799c6.tar.gz libguestfs-1079f74704a06c06996e547fdecf20a8f92799c6.tar.xz libguestfs-1079f74704a06c06996e547fdecf20a8f92799c6.zip | |
ocaml: Fix thread safety of strings in bindings (RHBZ#604691).
There's a thread safety issue with the current OCaml bindings which
is well explained in the bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=604691
This commit fixes the safety issue by copying strings temporarily
before releasing the thread lock. Updated code looks like this:
char *filename = guestfs_safe_strdup (g, String_val (filenamev));
int r;
caml_enter_blocking_section ();
r = guestfs_add_drive_ro (g, filename);
caml_leave_blocking_section ();
free (filename);
if (r == -1)
ocaml_guestfs_raise_error (g, "add_drive_ro");
Also included is a regression test.
Diffstat (limited to '.gitignore')
| -rw-r--r-- | .gitignore | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -167,6 +167,7 @@ ocaml/t/guestfs_005_load ocaml/t/guestfs_010_launch ocaml/t/guestfs_050_lvcreate ocaml/t/guestfs_060_readdir +ocaml/t/guestfs_070_threads ocaml/t/guestfs_500_inspect perl/bindtests.pl perl/blib |