libguestfs.git/perl/lib, branch oldlinux [MIRROR] library for accessing and modifying guest disk images perl: Don't fail if 'type' (disk format) attribute is missing in libvirt XML (RHBZ#701814). 2012-05-03T11:30:05+00:00 Richard W.M. Jones rjones@redhat.com 2012-05-03T11:25:54+00:00 f072a21f3aef6779aaa77329578ae3677a685d85 Old versions of libvirt allowed you to define disks like this: <disk type='file' device='disk'> <driver name='qemu'/> ... Since the <driver> element does not have a 'type' attribute (which defines the format), we are supposed to do autodetection, so the format should be undefined. However what actually happened was that the code in Sys::Guestfs::Lib::open_guest received format as an empty string from the xpath query, causing libguestfs to give an error. If the xpath query returns the format as an empty string, undefine it. 
Old versions of libvirt allowed you to define disks like this:

    <disk type='file' device='disk'>
      <driver name='qemu'/>
      ...

Since the <driver> element does not have a 'type' attribute (which
defines the format), we are supposed to do autodetection, so the
format should be undefined.

However what actually happened was that the code in
Sys::Guestfs::Lib::open_guest received format as an empty string from
the xpath query, causing libguestfs to give an error.

If the xpath query returns the format as an empty string, undefine it.
Tempus fugit. 2012-01-18T22:05:02+00:00 Richard W.M. Jones rjones@redhat.com 2012-01-18T22:05:02+00:00 08840bab44c38d0c69b5780c57b2bf370c96d58c Update all copyright dates to 2012. 
Update all copyright dates to 2012.
Fix 'unknown filesystem' warnings in old inspection code (RHBZ#678231 RHBZ#666578). 2011-08-11T10:45:25+00:00 Richard W.M. Jones rjones@redhat.com 2011-08-11T10:45:25+00:00 b9838001015a06a69a08b69d9f013d82f0ea3139 This is a comprehensive fix for the warnings from the old (and obsolete) Perl inspection code. For a full description and reproducer, see: https://bugzilla.redhat.com/show_bug.cgi?id=678231#c5 
This is a comprehensive fix for the warnings from the old (and
obsolete) Perl inspection code.  For a full description and
reproducer, see:

https://bugzilla.redhat.com/show_bug.cgi?id=678231#c5
perl: Fix another place where qw() was used as parentheses. 2011-07-27T14:43:12+00:00 Richard W.M. Jones rjones@redhat.com 2011-07-27T14:43:12+00:00 c70532ab4b3d977ed7484e473107808b22d90a2a This is a fix for Perl 5.14. See previous commit 5c3c7e8825341e18c9449976f8a321a04cc78d79. 
This is a fix for Perl 5.14.

See previous commit 5c3c7e8825341e18c9449976f8a321a04cc78d79.
Revert "Lib.pm: unknown filesystem label SWAP-sda2 (RHBZ#666578)" 2011-06-28T08:48:46+00:00 Richard W.M. Jones rjones@redhat.com 2011-06-27T17:14:15+00:00 123610f1b5133a9e541a245467f60d065ea96575 This reverts commit 5cab0d6c807d8a3bf9690375c663d11a10e21656. 
This reverts commit 5cab0d6c807d8a3bf9690375c663d11a10e21656.
perl: Don't use qw() as parentheses. 2011-06-18T12:00:00+00:00 Richard W.M. Jones rjones@redhat.com 2011-06-18T12:00:00+00:00 5c3c7e8825341e18c9449976f8a321a04cc78d79 In Perl 5.14: Use of qw(...) as parentheses is deprecated at perl/blib/lib/Sys/Guestfs/Lib.pm line 1111. 
In Perl 5.14:

Use of qw(...) as parentheses is deprecated at perl/blib/lib/Sys/Guestfs/Lib.pm line 1111.
perl: Canonicalize /dev/vd* paths in old inspection code (RHBZ#691724). 2011-03-29T11:20:57+00:00 Richard W.M. Jones rjones@redhat.com 2011-03-29T11:20:57+00:00 759f4369de965f46f4a93b3a75dada050f87e223 






Detect Red Hat Desktop as 'rhel' distro (RHBZ#682979).
2011-03-08T08:10:19+00:00

Richard W.M. Jones
rjones@redhat.com

2011-03-08T08:10:19+00:00

c1a227a960066fb9552e0c225bc473be365b67b0

/etc/redhat-release on Red Hat Desktop contains the following
string:
  Red Hat Desktop release 4 (Nahant Update 8)

Previously we matched against the string "Red Hat Enterprise Linux"
but since this does not contain that string, this distro wasn't being
detected correctly.

Note this also changes the obsolete Perl code, for the benefit of
virt-v2v.





/etc/redhat-release on Red Hat Desktop contains the following
string:
  Red Hat Desktop release 4 (Nahant Update 8)

Previously we matched against the string "Red Hat Enterprise Linux"
but since this does not contain that string, this distro wasn't being
detected correctly.

Note this also changes the obsolete Perl code, for the benefit of
virt-v2v.







Lib.pm: unknown filesystem /dev/hd{x} (cdrom) (RHBZ#666577)
2011-01-02T18:58:19+00:00

Douglas Schilling Landgraf
dougsland@redhat.com

2011-01-02T18:55:12+00:00

f07a0b6f1e01f12db0286ae49744deee0efcb5b9

This a purpose patch to avoid the message "unknown filesystem /dev/hdc".
Where /dev/hdc is an entry in fstab for CDROM.

Example of fstab:
/dev/hdc                /media/cdrom            auto
pamconsole,exec,noauto,managed 0 0

https://bugzilla.redhat.com/show_bug.cgi?id=666577

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>





This a purpose patch to avoid the message "unknown filesystem /dev/hdc".
Where /dev/hdc is an entry in fstab for CDROM.

Example of fstab:
/dev/hdc                /media/cdrom            auto
pamconsole,exec,noauto,managed 0 0

https://bugzilla.redhat.com/show_bug.cgi?id=666577

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>







Lib.pm: unknown filesystem label SWAP-sda2 (RHBZ#666578)
2011-01-02T18:58:09+00:00

Douglas Schilling Landgraf
dougsland@redhat.com

2011-01-02T18:53:55+00:00

5cab0d6c807d8a3bf9690375c663d11a10e21656

Hi,

This is a purpose patch to avoid the message: unknown filesystem label
SWAP-sda2.

Instead of validate the label with 'eq', use '=~' and /$label/i.

https://bugzilla.redhat.com/show_bug.cgi?id=666578

Thanks
Douglas





Hi,

This is a purpose patch to avoid the message: unknown filesystem label
SWAP-sda2.

Instead of validate the label with 'eq', use '=~' and /$label/i.

https://bugzilla.redhat.com/show_bug.cgi?id=666578

Thanks
Douglas