<feed xmlns='http://www.w3.org/2005/Atom'>
<title>libguestfs.git/daemon/command.c, branch 1.2.6</title>
<subtitle>[MIRROR] library for accessing and modifying guest disk images</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/'/>
<entry>
<title>daemon: Don't need to prefix error messages with the command name.</title>
<updated>2010-02-12T16:49:00+00:00</updated>
<author>
<name>Richard Jones</name>
<email>rjones@redhat.com</email>
</author>
<published>2010-02-12T14:06:25+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=e9c37113104c1cfb234535adc9b52ad3880a41ce'/>
<id>e9c37113104c1cfb234535adc9b52ad3880a41ce</id>
<content type='text'>
The RPC stubs already prefix the command name to error messages.
The daemon doesn't have to do this.  As a (small) benefit this also
makes the daemon slightly smaller.

Code in the daemon such as:

  if (argv[0] == NULL) {
    reply_with_error ("passed an empty list");
    return NULL;
  }

now results in error messages like this:

  &gt;&lt;fs&gt; command ""
  libguestfs: error: command: passed an empty list

(whereas previously you would have seen ..command: command:..)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The RPC stubs already prefix the command name to error messages.
The daemon doesn't have to do this.  As a (small) benefit this also
makes the daemon slightly smaller.

Code in the daemon such as:

  if (argv[0] == NULL) {
    reply_with_error ("passed an empty list");
    return NULL;
  }

now results in error messages like this:

  &gt;&lt;fs&gt; command ""
  libguestfs: error: command: passed an empty list

(whereas previously you would have seen ..command: command:..)
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix prototype of commandv to match prototype of commandrv.</title>
<updated>2009-11-09T11:05:19+00:00</updated>
<author>
<name>Richard Jones</name>
<email>rjones@redhat.com</email>
</author>
<published>2009-11-08T11:55:38+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=3cf719bc077a5f0d4f1a79279a5ba6e41d53c9b9'/>
<id>3cf719bc077a5f0d4f1a79279a5ba6e41d53c9b9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>command.c: avoid shadowing a global function</title>
<updated>2009-08-17T09:40:24+00:00</updated>
<author>
<name>Jim Meyering</name>
<email>meyering@redhat.com</email>
</author>
<published>2009-08-17T07:16:20+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=e82d864e02f7ab36881c6cda2798bb76370ee6c7'/>
<id>e82d864e02f7ab36881c6cda2798bb76370ee6c7</id>
<content type='text'>
* daemon/command.c (do_sh_lines, do_sh): Do not shadow global "command".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* daemon/command.c (do_sh_lines, do_sh): Do not shadow global "command".
</pre>
</div>
</content>
</entry>
<entry>
<title>adjust const "**" pointers to avoid warnings</title>
<updated>2009-08-17T09:40:24+00:00</updated>
<author>
<name>Jim Meyering</name>
<email>meyering@redhat.com</email>
</author>
<published>2009-08-07T07:38:37+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=adf20c0c4d9f488d55254f54a79079b9cacbde8d'/>
<id>adf20c0c4d9f488d55254f54a79079b9cacbde8d</id>
<content type='text'>
Also, ...
* src/generator.ml: Add DeviceList type, and propagate that change
out to all calling/interface code.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also, ...
* src/generator.ml: Add DeviceList type, and propagate that change
out to all calling/interface code.
</pre>
</div>
</content>
</entry>
<entry>
<title>generator.ml: use new "Pathname" designation</title>
<updated>2009-08-13T12:45:34+00:00</updated>
<author>
<name>Jim Meyering</name>
<email>meyering@redhat.com</email>
</author>
<published>2009-08-11T13:59:56+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=84fc760439e82e6b3616abd0d1f9bd7d7eb01ec0'/>
<id>84fc760439e82e6b3616abd0d1f9bd7d7eb01ec0</id>
<content type='text'>
Nearly every file-related function in daemons/*.c is affected:
Remove this pair of statements from each affected do_* function:
-  NEED_ROOT (return -1);
-  ABS_PATH (dir, return -1);
and change the type of the corresponding parameter to "const char *".
* src/generator.ml: Emit NEED_ROOT just once, even when there are two or
more Pathname args.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Nearly every file-related function in daemons/*.c is affected:
Remove this pair of statements from each affected do_* function:
-  NEED_ROOT (return -1);
-  ABS_PATH (dir, return -1);
and change the type of the corresponding parameter to "const char *".
* src/generator.ml: Emit NEED_ROOT just once, even when there are two or
more Pathname args.
</pre>
</div>
</content>
</entry>
<entry>
<title>update all NEED_ROOT uses</title>
<updated>2009-08-13T12:45:34+00:00</updated>
<author>
<name>Jim Meyering</name>
<email>meyering@redhat.com</email>
</author>
<published>2009-08-10T21:11:01+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=6bda071b5cd8393b37653687027c4ae6c6cf3804'/>
<id>6bda071b5cd8393b37653687027c4ae6c6cf3804</id>
<content type='text'>
run this command:
  git grep -l -w NEED_ROOT|xargs perl -pi -e \
    's/(NEED_ROOT) \((.*?)\)/$1 (return $2)/'
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
run this command:
  git grep -l -w NEED_ROOT|xargs perl -pi -e \
    's/(NEED_ROOT) \((.*?)\)/$1 (return $2)/'
</pre>
</div>
</content>
</entry>
<entry>
<title>Return error if allocations fail.</title>
<updated>2009-08-12T17:23:17+00:00</updated>
<author>
<name>Richard Jones</name>
<email>rjones@trick.home.annexia.org</email>
</author>
<published>2009-08-12T17:23:17+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=27566d8323e4a8af59f5649aeeaef97ebd55cbd0'/>
<id>27566d8323e4a8af59f5649aeeaef97ebd55cbd0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>If using SELinux, mount /selinux in the appliance.</title>
<updated>2009-08-12T16:23:58+00:00</updated>
<author>
<name>Richard Jones</name>
<email>rjones@trick.home.annexia.org</email>
</author>
<published>2009-08-12T15:31:06+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=2361905686c62b4163232139c3d390acd2c07916'/>
<id>2361905686c62b4163232139c3d390acd2c07916</id>
<content type='text'>
If selinux=1 on the Linux kernel command line, then we mount
/selinux in the appliance.  We will also bind-mount this
directory into guests when we run commands.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If selinux=1 on the Linux kernel command line, then we mount
/selinux in the appliance.  We will also bind-mount this
directory into guests when we run commands.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make /sysroot path configurable.</title>
<updated>2009-07-18T09:43:52+00:00</updated>
<author>
<name>Richard Jones</name>
<email>rjones@trick.home.annexia.org</email>
</author>
<published>2009-07-18T09:43:52+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=78029b529ad98769685d607230b70f71832d5906'/>
<id>78029b529ad98769685d607230b70f71832d5906</id>
<content type='text'>
Currently /sysroot is hard-coded throughout the daemon code.

This patch turns the path into a variable so that we can change
it in future, for example to allow standalone mode to be implemented.

This patch was tested by running all the C API tests successfully.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently /sysroot is hard-coded throughout the daemon code.

This patch turns the path into a variable so that we can change
it in future, for example to allow standalone mode to be implemented.

This patch was tested by running all the C API tests successfully.
</pre>
</div>
</content>
</entry>
<entry>
<title>remove trailing blanks</title>
<updated>2009-07-03T15:04:21+00:00</updated>
<author>
<name>Jim Meyering</name>
<email>meyering@redhat.com</email>
</author>
<published>2009-07-03T09:53:49+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/rjones/public_git/libguestfs.git/commit/?id=a7b73d4a1e09f12b2002083618056f0c823c1dcf'/>
<id>a7b73d4a1e09f12b2002083618056f0c823c1dcf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
