libguestfs.git/daemon/blockdev.c, branch stable-1.10

appliance: Set $PATH instead of hard-coding paths to binaries everywhere.

2010-03-26T13:36:30+00:00

Change the appliance so PATH includes common directories.  Thus
we don't need to hard-code paths to binaries (eg. "/sbin/fdisk")
everywhere.

daemon: Don't need to prefix error messages with the command name.

2010-02-12T16:49:00+00:00

The RPC stubs already prefix the command name to error messages.
The daemon doesn't have to do this.  As a (small) benefit this also
makes the daemon slightly smaller.

Code in the daemon such as:

  if (argv[0] == NULL) {
    reply_with_error ("passed an empty list");
    return NULL;
  }

now results in error messages like this:

  > command ""
  libguestfs: error: command: passed an empty list

(whereas previously you would have seen ..command: command:..)

Fix prototype of commandv to match prototype of commandrv.

2009-11-09T11:05:19+00:00

wc, blockdev: avoid warnings about discarding "const" qualifiers

2009-08-17T09:40:24+00:00

* daemon/wc.c (wc): Make "flag" param const.
* daemon/blockdev.c (call_blockdev): Likewise, for "switc".

adjust const "**" pointers to avoid warnings

2009-08-17T09:40:24+00:00

Also, ...
* src/generator.ml: Add DeviceList type, and propagate that change
out to all calling/interface code.

generator.ml: use new "Pathname" designation

2009-08-13T12:45:34+00:00

Nearly every file-related function in daemons/*.c is affected:
Remove this pair of statements from each affected do_* function:
-  NEED_ROOT (return -1);
-  ABS_PATH (dir, return -1);
and change the type of the corresponding parameter to "const char *".
* src/generator.ml: Emit NEED_ROOT just once, even when there are two or
more Pathname args.

* src/generator.ml: Change all `String "device"' to `Device "device"'.

2009-08-13T12:45:34+00:00

Then update each affected function, removing each uses of RESOLVE_DEVICE,
now that it's generated in caller from stub.c.
* daemon/blockdev.c (call_blockdev): Remove use of RESOLVE_DEVICE.
* daemon/devsparts.c (do_mkfs): Likewise.
* daemon/ext2.c (do_e2fsck_f, do_get_e2label, do_get_e2uuid): Likewise.
(do_resize2fs, do_set_e2label, do_set_e2uuid, do_tune2fs_l): Likewise.
* daemon/fsck.c (do_fsck): Likewise.
* daemon/grub.c (do_grub_install): Likewise.
* daemon/lvm.c (do_lvremove, do_pvcreate, do_pvremove): Likewise.
(do_pvresize): Likewise.
* daemon/mount.c (do_mount_vfs): Likewise.
* daemon/ntfs.c (do_ntfs_3g_probe): Likewise.
* daemon/scrub.c (do_scrub_device): Likewise.
* daemon/sfdisk.c (sfdisk, sfdisk_flag): Likewise.
* daemon/swap.c (do_mkswap, do_mkswap_L, do_mkswap_U): Likewise.
(do_swapoff_device, do_swapon_device): Likewise.
* daemon/zero.c (do_zero): Likewise.
* daemon/zerofree.c (do_zerofree): Likewise.

change almost all uses: s/IS_DEVICE/RESOLVE_DEVICE/

2009-08-13T12:45:33+00:00

Use this command:
  git grep -l -w IS_DEVICE|xargs perl -pi -e \
    's/\b(?:IS_DEVICE)\b( \(.*?,) (.*?)\)/RESOLVE_DEVICE$1 return $2)/'

remove trailing blanks

2009-07-03T15:04:21+00:00

In the daemon, change all const char * parameters to char *.

2009-06-10T13:16:47+00:00