1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
|
#!/usr/bin/env ruby
require File.dirname(__FILE__) + '/../../lib/puppettest'
require 'puppettest'
require 'mocha'
class TestMasterClient < Test::Unit::TestCase
include PuppetTest::ServerTest
def setup
super
@master = Puppet::Network::Client.master
end
def mkmaster(options = {})
options[:UseNodes] = false
options[:Local] = true
if code = options[:Code]
Puppet[:code] = code
else
Puppet[:manifest] = options[:Manifest] || mktestmanifest
end
# create our master
# this is the default server setup
master = Puppet::Network::Handler.master.new(options)
return master
end
def mkclient(master = nil)
master ||= mkmaster()
client = Puppet::Network::Client.master.new(
:Master => master
)
return client
end
def test_disable
FileUtils.mkdir_p(Puppet[:statedir])
manifest = mktestmanifest
master = mkmaster(:Manifest => manifest)
client = mkclient(master)
assert_nothing_raised("Could not disable client") {
client.disable
}
client.expects(:getconfig).never
client.run
client = mkclient(master)
client.expects(:getconfig)
assert_nothing_raised("Could not enable client") {
client.enable
}
client.run
end
# Make sure we're getting the client version in our list of facts
def test_clientversionfact
facts = nil
assert_nothing_raised {
facts = Puppet::Network::Client.master.facts
}
assert_equal(Puppet.version.to_s, facts["clientversion"])
end
# Make sure non-string facts don't make things go kablooie
def test_nonstring_facts
FileUtils.mkdir_p(Puppet[:statedir])
# Add a nonstring fact
Facter.add("nonstring") do
setcode { 1 }
end
assert_equal(1, Facter.nonstring, "Fact was a string from facter")
client = mkclient()
assert(! FileTest.exists?(@createdfile))
assert_nothing_raised {
client.run
}
end
# This method downloads files, and yields each file object if a block is given.
def test_download
source = tempfile()
dest = tempfile()
sfile = File.join(source, "file")
dfile = File.join(dest, "file")
Dir.mkdir(source)
File.open(sfile, "w") {|f| f.puts "yay"}
files = []
assert_nothing_raised do
files = Puppet::Network::Client.master.download(:dest => dest, :source => source, :name => "testing")
end
assert(FileTest.directory?(dest), "dest dir was not created")
assert(FileTest.file?(dfile), "dest file was not created")
assert_equal(File.read(sfile), File.read(dfile), "Dest file had incorrect contents")
assert_equal([dest, dfile].sort, files.sort, "Changed files were not returned correctly")
end
def test_getplugins
Puppet[:filetimeout] = -1
Puppet[:pluginsource] = tempfile()
Dir.mkdir(Puppet[:pluginsource])
Dir.mkdir(File.join(Puppet[:pluginsource], "testing"))
$loaded = []
loader = Puppet::Util::Autoload.new(self, "testing")
myplugin = File.join(Puppet[:pluginsource], "testing", "myplugin.rb")
File.open(myplugin, "w") do |f|
f.puts %{$loaded << :myplugin}
end
assert_nothing_raised("Could not get plugins") {
Puppet::Network::Client.master.getplugins
}
destfile = File.join(Puppet[:plugindest], "testing", "myplugin.rb")
assert(File.exists?(destfile), "Did not get plugin")
assert(loader.load(:myplugin), "Did not load downloaded plugin")
assert($loaded.include?(:myplugin), "Downloaded code was not evaluated")
# Now modify the file and make sure the type is replaced
File.open(myplugin, "w") do |f|
f.puts %{$loaded << :changed}
end
assert_nothing_raised("Could not get plugin changes") {
Puppet::Network::Client.master.getplugins
}
assert($loaded.include?(:changed), "Changed code was not evaluated")
# Now try it again, to make sure we don't have any objects lying around
assert_nothing_raised {
Puppet::Network::Client.master.getplugins
}
end
def test_getfacts
Puppet[:filetimeout] = -1
Puppet[:factsource] = tempfile()
Dir.mkdir(Puppet[:factsource])
hostname = Facter.value(:hostname)
myfact = File.join(Puppet[:factsource], "myfact.rb")
File.open(myfact, "w") do |f|
f.puts %{Facter.add("myfact") do
setcode { "yayness" }
end
}
end
assert_nothing_raised {
Puppet::Network::Client.master.getfacts
}
destfile = File.join(Puppet[:factdest], "myfact.rb")
assert(File.exists?(destfile), "Did not get fact")
assert_equal(hostname, Facter.value(:hostname),
"Lost value to hostname")
assert_equal("yayness", Facter.value(:myfact),
"Did not get correct fact value")
# Now modify the file and make sure the type is replaced
File.open(myfact, "w") do |f|
f.puts %{Facter.add("myfact") do
setcode { "funtest" }
end
}
end
assert_nothing_raised {
Puppet::Network::Client.master.getfacts
}
assert_equal("funtest", Facter.value(:myfact),
"Did not reload fact")
assert_equal(hostname, Facter.value(:hostname),
"Lost value to hostname")
# Now run it again and make sure the fact still loads
assert_nothing_raised {
Puppet::Network::Client.master.getfacts
}
assert_equal("funtest", Facter.value(:myfact),
"Did not reload fact")
assert_equal(hostname, Facter.value(:hostname),
"Lost value to hostname")
end
# Make sure that setting environment by fact takes precedence to configuration
def test_setenvironmentwithfact
name = "environment"
value = "test_environment"
Facter.stubs(:to_hash).returns(name => value)
assert_equal(value, Puppet::Network::Client.master.facts[name])
end
# Make sure we load all facts on startup.
def test_loadfacts
dirs = [tempfile(), tempfile()]
count = 0
names = []
dirs.each do |dir|
Dir.mkdir(dir)
name = "fact%s" % count
names << name
file = File.join(dir, "%s.rb" % name)
# Write out a plugin file
File.open(file, "w") do |f|
f.puts %{Facter.add("#{name}") do setcode { "#{name}" } end }
end
count += 1
end
Puppet[:factpath] = dirs.join(":")
names.each do |name|
assert_nil(Facter.value(name), "Somehow retrieved invalid fact")
end
assert_nothing_raised {
Puppet::Network::Client.master.loadfacts
}
names.each do |name|
assert_equal(name, Facter.value(name),
"Did not retrieve facts")
end
end
if Process.uid == 0
# Testing #283. Make sure plugins et al are downloaded as the running user.
def test_download_ownership
dir = tstdir()
dest = tstdir()
file = File.join(dir, "file")
File.open(file, "w") { |f| f.puts "funtest" }
user = nonrootuser()
group = nonrootgroup()
chowner = Puppet::Type.type(:file).create :path => dir,
:owner => user.name, :group => group.name, :recurse => true
assert_apply(chowner)
chowner.remove
assert_equal(user.uid, File.stat(file).uid)
assert_equal(group.gid, File.stat(file).gid)
assert_nothing_raised {
Puppet::Network::Client.master.download(:dest => dest, :source => dir,
:name => "testing"
) {}
}
destfile = File.join(dest, "file")
assert(FileTest.exists?(destfile), "Did not create destfile")
assert_equal(Process.uid, File.stat(destfile).uid)
end
end
# Test retrieving all of the facts.
def test_facts
facts = nil
assert_nothing_raised do
facts = Puppet::Network::Client.master.facts
end
Facter.to_hash.each do |fact, value|
assert_equal(facts[fact.downcase], value.to_s, "%s is not equal" % fact.inspect)
end
# Make sure the puppet version got added
assert_equal(Puppet::PUPPETVERSION, facts["clientversion"], "client version did not get added")
# And make sure the ruby version is in there
assert_equal(RUBY_VERSION, facts["rubyversion"], "ruby version did not get added")
end
# #540 - make sure downloads aren't affected by noop
def test_download_in_noop
source = tempfile
File.open(source, "w") { |f| f.puts "something" }
dest = tempfile
Puppet[:noop] = true
node = stub 'node', :environment => "development"
Puppet::Node.stubs(:find).returns node
assert_nothing_raised("Could not download in noop") do
@master.download(:dest => dest, :source => source, :tag => "yay")
end
assert(FileTest.exists?(dest), "did not download in noop mode")
assert(Puppet[:noop], "noop got disabled in run")
end
# #491 - make sure a missing config doesn't kill us
def test_missing_localconfig
master = mkclient
master.local = false
driver = master.send(:instance_variable_get, "@driver")
driver.local = false
Puppet::Node::Facts.indirection.stubs(:save)
# Retrieve the configuration
master.getconfig
# Now the config is up to date, so get rid of the @objects var and
# the cached config
master.clear
File.unlink(master.cachefile)
assert_nothing_raised("Missing cache file threw error") do
master.getconfig
end
assert(! @logs.detect { |l| l.message =~ /Could not load/},
"Tried to load cache when it is non-existent")
end
def test_locking
master = mkclient
class << master
def getconfig
raise ArgumentError, "Just testing"
end
end
master.run
assert(! master.send(:lockfile).locked?,
"Master is still locked after failure")
end
# Make sure we get a value for timeout
def test_config_timeout
master = Puppet::Network::Client.client(:master)
time = Integer(Puppet[:configtimeout])
assert_equal(time, master.timeout, "Did not get default value for timeout")
assert_equal(time, master.timeout, "Did not get default value for timeout on second run")
# Reset it
Puppet[:configtimeout] = "50"
assert_equal(50, master.timeout, "Did not get changed default value for timeout")
assert_equal(50, master.timeout, "Did not get changed default value for timeout on second run")
# Now try an integer
Puppet[:configtimeout] = 100
assert_equal(100, master.timeout, "Did not get changed integer default value for timeout")
assert_equal(100, master.timeout, "Did not get changed integer default value for timeout on second run")
end
def test_splay
client = mkclient
# Make sure we default to no splay
client.expects(:sleep).never
assert_nothing_raised("Failed to call splay") do
client.send(:splay)
end
# Now set it to true and make sure we get the right value
client = mkclient
client.expects(:sleep)
Puppet[:splay] = true
assert_nothing_raised("Failed to call sleep when splay is true") do
client.send(:splay)
end
time = Puppet::Util::Storage.cache(:configuration)[:splay_time]
assert(time, "Splay time was not cached")
# Now try it again
client = mkclient
client.expects(:sleep).with(time)
assert_nothing_raised("Failed to call sleep when splay is true with a cached value") do
client.send(:splay)
end
end
def test_environment_is_added_to_facts
facts = Puppet::Network::Client::Master.facts
assert_equal(facts["environment"], Puppet[:environment], "Did not add environment to client facts")
# Now set it to a real value
Puppet[:environments] = "something,else"
Puppet[:environment] = "something"
facts = Puppet::Network::Client::Master.facts
assert_equal(facts["environment"], Puppet[:environment], "Did not add environment to client facts")
end
# #685
def test_http_failures_do_not_kill_puppetd
client = mkclient
client.meta_def(:getconfig) { raise "A failure" }
assert_nothing_raised("Failure in getconfig threw an error") do
client.run
end
end
def test_invalid_catalogs_do_not_get_cached
master = mkmaster :Code => "notify { one: require => File[yaytest] }"
master.local = false # so it gets cached
client = mkclient(master)
client.stubs(:facts).returns({})
client.local = false
Puppet::Node::Facts.indirection.stubs(:terminus_class).returns(:memory)
# Make sure the config is not cached.
client.expects(:cache).never
client.getconfig
# Doesn't throw an exception, but definitely fails.
client.run
end
def test_classfile
Puppet[:code] = "class yaytest {}\n class bootest {}\n include yaytest, bootest"
Puppet::Node::Facts.indirection.stubs(:save)
master = client = nil
assert_nothing_raised() {
master = Puppet::Network::Handler.master.new(
:Local => false
)
}
assert_nothing_raised() {
client = Puppet::Network::Client.master.new(
:Master => master
)
}
# Fake that it's local, so it creates the class file
client.local = false
# We can't guarantee class ordering
client.expects(:setclasses).with do |array|
array.length == 2 and array.include?("yaytest") and array.include?("bootest")
end
assert_nothing_raised {
client.getconfig
}
end
end
|