From 184132e07fc1461555cb4da842df15f32842a843 Mon Sep 17 00:00:00 2001
From: Markus Roberts <Markus@reality.com>
Date: Fri, 9 Jul 2010 18:05:07 -0700
Subject: Code smell: Use {} for % notation delimiters wherever practical

*

* Replaced 16 occurances of %([qQrwWx])\((.*?)\) with %\1{\2}

  3 Examples:

      The code:
          # %r(/) != /\//
      becomes:
          # %r{/} != /\//
      The code:
          ri    = glob(%w(bin/*.rb sbin/* lib/**/*.rb)).reject { |e| e=~ /\.(bat|cmd)$/ }
      becomes:
          ri    = glob(%w{bin/*.rb sbin/* lib/**/*.rb}).reject { |e| e=~ /\.(bat|cmd)$/ }
      The code:
          if !FileUtils.uptodate?("/var/cache/eix", %w(/usr/bin/eix /usr/portage/metadata/timestamp))
      becomes:
          if !FileUtils.uptodate?("/var/cache/eix", %w{/usr/bin/eix /usr/portage/metadata/timestamp})

* Replaced 12 occurances of %([qQrwWx])\[(.*?)\] with %\1{\2}

  3 Examples:

      The code:
          return send(command) if %w[get backup restore].include? command
      becomes:
          return send(command) if %w{get backup restore}.include? command
      The code:
          for iv in %w[indent space space_before object_nl array_nl check_circular allow_nan max_nesting]
      becomes:
          for iv in %w{indent space space_before object_nl array_nl check_circular allow_nan max_nesting}
      The code:
          @puppetd.command_line.stubs(:args).returns(%w[--logdest /my/file])
      becomes:
          @puppetd.command_line.stubs(:args).returns(%w{--logdest /my/file})

* Replaced no occurances of %([qQrwWx])<(.*?)> with %\1{\2}

* Replaced 19 occurances of

      %([qQrwWx])([^{\[(<])(.*?)\2

  with

      %\1{\3}

  3 Examples:

      The code:
          at.add_mapping(%r%^lib/puppet/(.*)\.rb$%) { |filename, m|
      becomes:
          at.add_mapping(%r{^lib/puppet/(.*)\.rb$}) { |filename, m|
      The code:
          at.add_mapping(%r%^spec/(unit|integration)/.*\.rb$%) { |filename, _|
      becomes:
          at.add_mapping(%r{^spec/(unit|integration)/.*\.rb$}) { |filename, _|
      The code:
          at.add_mapping(%r!^lib/puppet\.rb$!) { |filename, _|
      becomes:
          at.add_mapping(%r{^lib/puppet\.rb$}) { |filename, _|
---
 install.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'install.rb')

diff --git a/install.rb b/install.rb
index 54a714674..18da2bebb 100755
--- a/install.rb
+++ b/install.rb
@@ -82,7 +82,7 @@ end
 sbins = glob(%w{sbin/*})
 bins  = glob(%w{bin/*})
 rdoc  = glob(%w{bin/* sbin/* lib/**/*.rb README README-library CHANGELOG TODO Install}).reject { |e| e=~ /\.(bat|cmd)$/ }
-ri    = glob(%w(bin/*.rb sbin/* lib/**/*.rb)).reject { |e| e=~ /\.(bat|cmd)$/ }
+ri    = glob(%w{bin/*.rb sbin/* lib/**/*.rb}).reject { |e| e=~ /\.(bat|cmd)$/ }
 man   = glob(%w{man/man[0-9]/*})
 libs  = glob(%w{lib/**/*.rb lib/**/*.py})
 tests = glob(%w{test/**/*.rb})
-- 
cgit