| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
There was a subtle 1.8.7 dependence in the composite key / namevar patch;
Nick discovered that our assumtion that hashes could be used as hash keys
does not hold in earlier bersions of ruby. This patch replaces the hash
valued uniqueness_key with an array of the values of the (ordered) key
attributes.
|
|
|
|
|
|
| |
Merging some of the branches creates a require-loop; this commit breaks it by
removing the most recently added link (which I believe to have been unneeded /
unrelated to the patch in which it snuck in).
|
|
|
|
| |
There was a comma missing from a raise, which caused a warning message on each run.
|
| |
|
| |
|
| |
|
|
|
|
| |
and update the specs that were testing it.
|
|
|
|
|
| |
The value method was failing to return any value in the case where
the value was false.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Puts reportdir and reporturl back in the "main" block because this makes
tests break for reasons I don't understand.
|
|
|
|
|
|
| |
Tests that weren't managing the environment but were still expecting to have
functions defined in it were appalled when the functions/environments binding
actually started working. This patch fixes those tests.
|
|
|
|
|
|
| |
This change allows the --onetime command line option to be set by the
Puppet[:onetime] global option or read from the config file, rather than
forcing it to be read from the config file.
|
|
|
|
|
| |
audit's munge was not idempotent because newattr was not idempotent.
This patch simplifies newattr such that it becomes idempotent.
|
|
|
|
|
|
|
| |
This adds the --charset option to puppetdoc for RDoc mode.
This allows to set the charset for the generated html.
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|
|
|
|
|
|
|
|
|
|
| |
The following manifest was failing:
$data = {}
This patch makes sure we initalize our ast hash with an empty ruby
hash when it is created without any values.
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This operator allows to find if the left operand is in the right one.
The left operand must be resort to a string, but the right operand can be:
* a string
* an array
* a hash (the search is done on the keys)
This syntax can be used in any place where an expression is supported.
Syntax:
$eatme = 'eat'
if $eatme in ['ate', 'eat'] {
...
}
$value = 'beat generation'
if 'eat' in $value {
notice("on the road")
}
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|
|
|
|
|
| |
This patch allows the puppet single-executable to invoke external,
hyphenated subcommands, much like how git does.
|
|
|
|
|
|
| |
OpenSuSE replaced rug with zypper so our code should too
Signed-off-by: Matt Robinson <matt@puppetlabs.com>
|
|
|
|
|
| |
Remove workarounds that were only needed because ruby's builtin YAML
lib is broken.
|
|
|
|
|
|
|
|
|
| |
execution and fix minor bug with logoutput and returns as an array..
* Add 'tries' and 'try_sleep' parameters
* Fix bug where returns is specified as an array and logoutput on
* failure.
* unit tests for both cases above.
|
| |
|
|
|
|
|
|
|
|
|
| |
Change Autoloader's load to re-raise exceptions that happen when
trying to load files, rather than just warning.
This version still does not raise an error if the file is not found, as
doing so would change the behavior of 'load' pretty significantly, but I
am ambivalent this.
|
|
|
|
|
|
|
| |
Change Autoloader's loadall to re-raise exceptions that happen when
trying to load files, rather than just warning.
Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
|
|
|
|
|
|
|
|
| |
Class namespace is different than namespace of nodes and definition as
it contains the whole qualified name.
This bit was left out in the type are not AST anymore refactoring.
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|
|
|
|
| |
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
|
|
|
|
| |
Puppetdoc got confused because it wasn't popping the comment context for
collections and resource defaults. This commit adds the popping.
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows you to create builtin nested resource types
that generate other resources that generate other resources
ad naseum.
The primary point of this feature is that you can make
builtin resource types that have a lot of the same
encapsulation abilities of defined resource types.
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
|
|
|
|
|
| |
specify
it in the config file.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The user method on the provider always returned what the resource should
be, not what it actually was, so it always seemed to be insync to
puppet.
Also cleaned up some cruft on the perms that did different things
depending on whether a user was specified on the resource. This isn't
necessary since a user is required on the resource.
Paired with: Jesse Wolfe
Signed-off-by: Matt Robinson <matt@puppetlabs.com>
|
|
|
|
|
|
|
|
| |
This disables adding any code to 'main' except
in site.pp, so if you have code outside of a node,
class, or define it will throw an exception.
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will produce the name of the module that a given
resource is defined in, rather than the module that
the resource type itself is defined in. For instance:
# in one/manifests/onedef.pp
define one::onedef {
notice "Called $name from $caller_module_name"
}
# in two/manifests/init.pp
class two {
one::onedef { yay: }
}
produces:
Called yay from two
This could obviously be extended to actually build a caller
stack, as frightening as that seems.
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is only true for resource types (e.g., classes and defines)
of course.
The actual variable is 'module_name':
class mymod {
notify { "in mymod '$module_name'": }
}
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
|
|
|
|
| |
Prevents unmet dependency problems when running tests without the
couchrest gem
|
|
|
|
|
| |
* Cleaner implementation of abstract Couch terminus
* More thoroughly tested facts Couch terminus
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements an abstract CouchDB terminus and a concrete CouchDB terminus
used to store node facts. Node facts are stored in a "node" document as
the "facts" attribute. This node document may also be used by other
couchdb termini that store node-related information. It is recommended
to use a separate document (or documents) to store large data structures
like catalogs, linking them to their related node document using
embedded ids.
This implementation depends on the "couchrest" gem.
* Add Puppet.features.couchdb?
* Add Puppet[:couchdb_url] setting
* Add Puppet::Node::Facts#== for testing
* Add PuppetSpec::FIXTURE_DIR for easy access to fixture files
* Add CouchDB Terminus
* Add Facts::CouchDB terminus
* Stores facts inside a "node" document
* Use key (hostname) as _id for node document
* #find returns nil if document cannot be found
* #save finds and updates existing document OR creates new doc [1]
* Store facts in "facts" attribute of node document
|
|
|
|
| |
Doh.
|
|
|
|
|
|
| |
Older / user written providers may just return a bare string from their ___cmd
functions instead of an array. This forces the command as used to be an array
without breaking the cases where they (correctly) do return an array.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Example puppet.conf:
[puppetmasterd]
reports = store, http
reporturl = http://localhost:3000/reports
* Group reporturl and reportdir in new reports section of
Puppet::Settings
* Add specs for both
|
|
|
|
| |
Patch thanks to Alan Barrett
|
| |
|
|
|
|
| |
This is the patch as submitted by vichharaks ros <vichharaks.ros@hp.com>
|
|
|
|
| |
Thanks to Alan Barrett for the patch
|
|
|
|
|
|
|
| |
The message was "host_aliases changed from 'absent' to ''". When reading from
the hosts file, a host without aliases was considered to have "absent"
host_aliases. The host_aliases list is now considered to be present but empty
if it is absent.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provides a full audit trail for any parameter on any
resource Puppet can manage. Just use:
file { "/my/file": audit => [content, owner] }
And Puppet will generate an event any time either of
those properties change.
This commit also deprecates the 'check' parameter in favor of
a new 'audit' parameter.
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
|
|
|
|
|
|
|
|
|
|
| |
It was called in the 'check' attribute but not set
anywhere else.
The whole point of being a property is that you can
retrieve the current state of that property - not
being checkable/auditable is nonsensical.
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The whole host_config concept is a bit outdated now that Configurer
exists, I think, (since any catalog it uses should be a host_config).
However, fixing that is outside of the scope of this series.
In the meantime, this does a better job of making sure every
catalog except the Settings catalogs are host_configs.
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is again about moving transactional behaviour out
of Puppet::Type and into the transactional code.
I initially moved this code into Resource::Status,
but it seemed to make more sense in the Harness - the
Status object should be thin and have no code
that doesn't make sense on both sides of the pipe,
it seemed.
The interface gets a bit uglier as a result, but this
is all about good design != good OO (because we're
increasing the argument count of methods by moving
them outside of the target class).
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|