summaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fix #2638 - Allow creating several nodes with matching namesBrice Figureau2009-09-172-1/+5
| | | | | | | | When we are checking if a node exists before creating a new one we were also trying to match with regex node names, finding matches where in fact there is no equality. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix for #2621 (JSON serialization of exec)Markus Roberts2009-09-161-1/+0
| | | | | | | Removed the array wrapping of values for JSON serialization, and the associated test. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fix #2622 - Puppetdoc in single manifest to console is brokenBrice Figureau2009-09-161-3/+5
| | | | | | | | | After the LoadedCode refactoring I forgot to update this (mostly) unused part of puppetdoc which unfortunately is not covered by unit tests. This commit fixes this issue. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix #2640 - Daemontools and Runit were not creating the enable symlinkBrice Figureau2009-09-162-13/+10
| | | | | | | | Due to an incorrect tests, those providers weren't enabling themselves when starting, thus failing to create the symlink necessary for them to run. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix #2627 - regex node name could lead to invalid tagBrice Figureau2009-09-161-3/+1
| | | | | | | | | We're converting the regex to a straight name to be used as the node class name which later on will be used as tag. It was possible to generate an invalid tag name (containing leading or successive dots). Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Merged fix for #2601Markus Roberts2009-09-161-10/+4
| | | | | | | | | | | This patch rolls up the changeses discussed on the list & the ticket The fqdn_rand now takes any number of additional arguments of any type that has a string representation (typically integers or strings) and concatenats them on to the salt. The tests have been adjusted to reflect this. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fix for #2637 (Webrick accpting connections on dead sockets)Markus Roberts2009-09-151-1/+8
| | | | | | | | | | There was a race condition between the layers (SSL vs. TCP/IP) that permitted the creation of non-functional connections when webrick managed the connection. This patch moves the responsibility into our code via the provided callbacks and makes sure the socket is valid before accepting the connection. Signed-off-by: Markus Roberts <Markus@reality.com>
* Merge branch 'tickets/0.25.x/2634' into 0.25.xJames Turnbull2009-09-151-3/+4
|\
| * Fixed #2634 - Added servicegroup_name parameter to serviceescalation typeJames Turnbull2009-09-151-3/+4
| |
* | Fix for #2605 by falling back to alternative solution to #1963Markus Roberts2009-09-151-6/+13
| | | | | | | | | | | | | | | | | | | | Two solutions were proposed and tested for #1963; both worked but one (the read_nonblock solution) was used for performance reasons. This solution does not work on older ruby implementations (1.8.1) because read_nonblock is not available. This patch implements the alternative fix (IO.popen) as a fallback to handles such cases. Signed-off-by: Markus Roberts <Markus@reality.com>
* | Make regsubst() function operate on arrays (feature #2491).Thomas Bellman2009-09-151-30/+44
| | | | | | | | | | | | | | | | | | | | | | Allow the first argument to the regsubst() function be an array, and perform regexp replacement on each element of the array in that case. This patch also adds more error checking to give better error messages to the user when given bad parameters. Signed-off-by: Thomas Bellman <bellman@nsc.liu.se>
* | Fix for #2600 (wrong number of arguments under older mongrel)Markus Roberts2009-09-153-15/+13
|/ | | | | | | | | | | | | | | | | | This was an API compatibility problem with mongrel's HTTPResponse.start() method between Mongrel 1.0.x and 1.1.x (the number of parameters changed). The older version does not provide the option to set the response header message which was used (redundantly with the response body) to return the error message when the HTTP response was signaling an error. In order to suport the older version the call was wrapped with a fallback and the coresponding code in the other rest implementations was adjusted to always send the error message in the response body. Then the rest terminus was adjusted to pull the message from the response body (if it is present) rather than from the header (which is only used as a fallback for dealing with older puppetmasters), and the tests were augmeted to verify this behaviour. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixs #2620 authconf interpolation, #2570 0-9 in domain namesMarkus Roberts2009-09-141-53/+29
| | | | | | | | | | | | | | Partial refactoring to clean up the case in the ticket (host name containing dots, begining and ending with a digit, was mistaken for an IP address) and a range of related edge cases. Stopped short of a full refactoring (put off to 0.26 as #2623) Added tests for numerous edge cases. This also fixes the issue raised in #2570. Signed-off-by: Markus Roberts <Markus@reality.com>
* Require active_record/version to support ActiveRecord < 2.3Todd Zullinger2009-09-091-0/+1
| | | | | | | | | ActiveRecord < 2.3.0 did not autoload active_record/version which caused puppet to incorrectly believe ActiveRecord was not available. This compliments 1a5c5b3 (Fixing #2508 - removing mention of ActiveRecord 2.3). Signed-off-by: Todd Zullinger <tmz@pobox.com>
* Ticket #2525 don't fail find_manifest on invalid module namesMarkus Roberts2009-09-052-14/+12
| | | | | | | | | The patch that put validity assertions in for module names broke find_manifest because rather than returning a failure it now rasies an exception. This patch catches the exception and treats it as a negative result. Signed-off-by: Markus Roberts <Markus@reality.com>
* This further normalizes the handling of init-style services (includingMarkus Roberts2009-09-053-58/+36
| | | | | | | | | the redhat "service" wrapper script). Removes special case handling of non-zero exit code in redhat (base already did this) and centralizes scattered @resource[:has_____] checks. Tests that proper versions of each are called and one level of fallbacks. Signed-off-by: Markus Roberts <Markus@reality.com>
* Combined fix for #2525, #2552 -- RedHat service issuesMarkus Roberts2009-09-051-1/+9
| | | | | | | | | This patch normalizes the structure of the RH service routines which should clear up any lingering issues; xxxcmd routines always return an appropriate array, while the coresponding routines (status/restart/ etc.) either call super or take the needed actions. Signed-off-by: Markus Roberts <markus@phage.local>
* Fixed #2589 - Renamed zfs delete to destroy and added testsJames Turnbull2009-09-051-1/+1
|
* Monkey patch to improve yaml compatibility between ruby versionsMarkus Roberts2009-09-052-0/+44
| | | | | | | | | Ruby 1.8.1 can not parse the yanl produced by later versions because it requires explict type tagging of symbols. This patch adds the tagging on to later versions so that mixed version instalations can use yaml. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixing #2592 - you can escape slashes in regexesLuke Kanies2009-09-041-3/+14
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2590 - modulepath is not cached inappropriatelyLuke Kanies2009-09-031-0/+8
| | | | | | | | | | | | | | | | It was getting cached by Environment instances too early, thus causing some executables to use the default even when it was overridden. We're taking the slightly extreme step of clearing the environment list if any parameter is set, but this is relatively inexpensive and is the only way to always be correct. The reason that the environments cache this value at all is that to build up their module path they have to search through every known module for a lib or plugins directory, which is then done every time a class is sought in the language. Caching it saves a *ton* of file accesses. Signed-off-by: Luke Kanies <luke@madstop.com>
* Update documentation string to reflect actual intent of ↵Steven Jenkins2009-09-041-1/+1
| | | | Puppet::Node::Facts::Rest
* Fixes #2581. Use new 10.6 global launchd overrides file for service ↵Nigel Kersten2009-09-031-10/+82
| | | | status/enabled
* Fixed Naginator linkJames Turnbull2009-09-031-1/+1
|
* Fixing #2582 - / no longer autorequires /Luke Kanies2009-09-011-3/+3
| | | | | | This was obviously resulting in a dep cycle. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2577 - clarifying and demoting the deprecation noticeLuke Kanies2009-09-012-10/+18
| | | | | | | It's now just notice instead of a warning, and it clarifies that 0.24 clients can't be present. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2574 - autoloading finds plugins in modulesLuke Kanies2009-09-011-4/+5
| | | | | | | | We had some stupid errors that were preventing this from happening; this fixes them and adds an integration test. Signed-off-by: Luke Kanies <luke@madstop.com>
* The first regex node now matches firstLuke Kanies2009-09-011-8/+15
| | | | | | | Before it was undefined, but now we always match the first defined node. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2563 - multiple regex nodes now work togetherLuke Kanies2009-09-011-2/+12
| | | | | | | | | | The problem was that we were needing to convert one of the regexes to a string, which wasn't working well. This adds specific rules for how regexes vs. strings get compared. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixes #724 - false is equivalent to 'ruby -W1'Marc Fournier2009-09-011-1/+1
| | | | Signed-off-by: Marc Fournier <marc.fournier@camptocamp.com>
* Fix parser error outputTodd Zullinger2009-08-241-1/+1
| | | | | | The 'value' passed to on_error in Puppet::Parser::Parser is a hash, and we only want to print the 'value' key, rather than a flattened string of the hash.
* Fixing #2551 - fixing content changed logsLuke Kanies2009-08-231-0/+15
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2549 - autoloading of top-level classes works againLuke Kanies2009-08-241-7/+14
| | | | | | | | This was broken in the recent refactor around autoloading, which didn't special-case classes that specified that they were top-level. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2460 - puppetmasterd can now read the cert and keyLuke Kanies2009-08-241-4/+25
| | | | | | | | | | | | This follows on to the previous commits which made Puppet resilient to the service user being absent. This just changes the default owner of all of the cert-related files to now be the service user, which means that on the server all of these files will be owned by that user and on the client, at least when the service user does not exist, they will be owned by root. Signed-off-by: Luke Kanies <luke@madstop.com>
* Not using the service user in settings when it's unavailableLuke Kanies2009-08-242-1/+15
| | | | | | | | | This gets us most of the way toward fixing #2460 - we can now have the certificate information owned by the service user when it's available, thus making it so that puppetmasterd (not running as root) can read it. Signed-off-by: Luke Kanies <luke@madstop.com>
* Explicitly loading all facts in the directory service providerLuke Kanies2009-08-241-0/+3
| | | | | | | | We otherwise have load-order issues, where this provider tries to use the facts but they aren't currently autoloaded by default in Facter. Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding an 'exists?' delegator from user type to providerLuke Kanies2009-08-241-0/+5
| | | | | | | We need this knowledge from the Settings class, and it makes more sense to delegate than to use direct access to the provider. Signed-off-by: Luke Kanies <luke@madstop.com>
* Switching the owner/group settings to use symbolic valuesLuke Kanies2009-08-242-49/+62
| | | | | | | | | | | | | | We previously allowed the owner and group to be set to arbitrary values but we never actually used it -- we always just set them to '$user' or '$group'. This commit changes the model to allow 'root' or 'service', where 'service' is converted to the actual service user/group. This has the potential to have backward compatibility concerns, because users could have changed the owner/group in puppet.conf, but the chances of that are fantastically small. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing the yamldir group to be a group instead of userLuke Kanies2009-08-241-1/+1
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Moving Setting classes into separate filesLuke Kanies2009-08-245-279/+286
| | | | | | | | This isn't really a refactor, just moving code around. I did some simple method renaming, also. Signed-off-by: Luke Kanies <luke@madstop.com>
* Removing chuser on darwin restrictionLuke Kanies2009-08-241-4/+0
| | | | | | | | | | | For too long we have refused to change users on Darwin because a long time ago the ruby they shipped with was really, really broken. It's been fixed for a while, so this just removes the restriction. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2558 - propagating recent fileserving changesLuke Kanies2009-08-245-18/+18
| | | | | | | | | | | | | | | | | | I'd made changes to the internals of the fileserving system to fix #2544 (mostly switched from passing the node around and then calculating the environment to just passing the environment around), but those changes weren't consistent throughout the fileserving code. In the process of making them consistent, I realized that the plain file server actually needs the node name rather than the environment, so I switched to passing the request around, because it has both pieces of information. Also added further integration tests which will hopefully keep this from cropping up again. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixes #2550 Handles case where metadata is nilMarkus Roberts2009-08-231-7/+6
| | | | | | | | | | | | | The checksum function assumed that if the source was present the metadata (including checksum) was also, and thus that the type of the checksum could be extracated with a simple RegExp match. When metadata is nil it returns nil for the source checksum and the modified function passes this on. Alternatives would be to default to :md5 or to pass on to checking the :checksum parameter as if there were no source. Signed-off-by: Markus Roberts <Markus@reality.com>
* Ticket 2559 -- parseonly ignored specified fileMarkus Roberts2009-08-221-0/+6
| | | | | | | | In the command-line option parsing refactor from 0.24.x the manifest specification was lost for --parseonly, so site.pp was always used. This patch adds the parsing back in. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixed #2562 - Recognize the usecacheonfailure option againJohn A. Barbuto2009-08-211-0/+5
| | | | Signed-off-by: John A. Barbuto <jbarbuto@corp.sourceforge.com>
* Refactoring the Module/Environment co-interfaceLuke Kanies2009-08-182-28/+15
| | | | | | | This simplifies who owns what code in these two classes, and the result should be much cleaner and simpler. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #1544 - plugins in modules now works againLuke Kanies2009-08-185-17/+12
| | | | | | | | | | | | We had to fix the fileserving plumbing to use the request environment instead of trying to use the node environment. This was apparently never fixed after we added the environment to the URI in REST calls. There's still a bit of refactoring left to clean up the APIs used in some of this code. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixes #2513. debian service provider now uses invoke-rc.d to determine ↵Nigel Kersten2009-08-181-11/+19
| | | | enabled? status
* Fixing fact-missing problem when puppet.conf is reparsedLuke Kanies2009-08-181-0/+6
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fix for #2531; adds tests to confirm problem and related cases,Markus Roberts2009-08-181-1/+3
| | | | | | | notes fixes specific issue by eliminating the specal case for opaque strings which caused them to be strings when everything else was arrays; adds nots and pending tests where FQDN support could be added but stops short of a full refactor.
generated by cgit (git 2.34.1) at 2024-09-25 09:30:21 +0000