summaryrefslogtreecommitdiffstats
path: root/lib/puppet
Commit message (Collapse)AuthorAgeFilesLines
* Fix for Bug #4756 - Providers no longer respect missing featuresJames Cammarata2010-09-141-0/+6
| | | | Restored deleted lines from type.rb and reinstated unit tests
* Fix for #4736 -- preserve case of defined resourcesMarkus Roberts2010-09-101-2/+7
| | | | | | This restricts the change introduced in #4691 to hostclasses, and leaves defined resources and nodes alone, thus more closely mimicing the 0.25.x behaviour. It also includes title, as this was similarly affected.
* Fix for #4637 --use of namevar missed in refactorMarkus Roberts2010-09-091-1/+1
| | | | | A use of namevar apparently slipped through the net or got (re)introduced in a merge/conflict resolution.
* Minimal fix for #4691 -- class name uppercased in $nameMarkus Roberts2010-09-071-1/+1
| | | | | | The class name is now stored internally with an initial capital, which changed the contents of $name in a way that broke some manifests. This fix stores the downcased version in $name.
* Fix for #4693 -- implicit stages should never be serializedMarkus Roberts2010-09-071-1/+1
| | | | | | | | | | | My fix for #4542 was overly enthusiastic about assuring that all resources had a stage, resulting in stages designations being serialized for resources in manifests which did not use resources (everything was in implicit main). This broke 0.25.x compatibility, as all catalogs now refered to stages. This patch scales back the change for #4542 slightly, supressing the setting of main on the puppetmaster and relying on the default behaviour on the client (for 2.6.x and later, treat it as main; for 0.25.x, do nothing).
* Fix for tests broken by fix for #4489 -- stub standaloneMarkus Roberts2010-09-071-1/+5
| | | | | | If the file streaming is to be thwarted when running standalone the test for standalone needs to be stubbed when running specs, lest the tests inexplicably fail.
* Fix for #4489 -- apply was using the rest terminusMarkus Roberts2010-09-072-0/+12
| | | | | | | | | | | | | | | | | Basing pervasive low-level behaviour changes on the application name isn't a good idea, but if we're going to do it we need to remember to update the test when we rename the application. Further, if we optimize around such low-level tests (as we did when implementing file-streaming) we need to carry the tests over into the new data paths. This commit addresses both of these isues, restoring 0.25.x stand-alone file serving by adjusting the process-name test in the indirector to recognize "apply" as standalone (and thus not use http to fetch the files) and by adding a branch to the file streaming code to do the same when fetching the content. I am not certain that this change is globally correct; there may be other related problems that will not be fixed (and may in fact be exacerbated) by this patch.
* [#4462] uncaught Timeout::ErrorJesse Wolfe2010-09-071-1/+3
| | | | | | puppet agent was not catching all species of exceptions, causing it to crash on net/http timeout errors. This patch broadens the types of exceptions that are caught.
* Fixed alias metaparam docs errorJames Turnbull2010-09-071-1/+1
|
* Skip apt-listbugs and apt-listchanges when installing from puppetDean Wilson2010-09-041-0/+4
|
* Fixed queue require for #4555James Turnbull2010-09-031-1/+1
|
* Fixed #4100 - Added http_caching to yumrepo typeJames Turnbull2010-08-311-0/+6
|
* Added cost parameter to the yumrepo typeJames Turnbull2010-08-311-0/+6
|
* Fixed extlookup documentation and spacingJames Turnbull2010-08-312-143/+134
|
* Fix for #4506 -- too much data being serializedMarkus Roberts2010-08-311-1/+1
| | | | | | | | | | | | The serialization of much of the memory image was being triggered by a copy of an unchanging method return value in an instance variable. I had introduced this as a performance hack. The results were correct, but when the object was serialized it took a huge amount of data with it (known_resource_types, and from there...) As the underlying costly operation is no longer being called (thanks to Paul and Jesse) the caching is no longer a significant performance boost, and can thus simply be removed.
* Fixed terminus example documentationJames Turnbull2010-08-292-4/+4
|
* Fix for #4456 -- need to accept some mime-type aliasesMarkus Roberts2010-08-242-4/+10
| | | | | | Rather than just creating a handler for the base mime-type (e.g. "text/yaml") we create some synonyms where appropriate (e.g. "text/x-yaml", "application/yaml", etc.)
* Fix for #4489 -- apply was using the rest terminusMarkus Roberts2010-08-241-2/+2
| | | | | | | | | | Basing pervasive low-level behaviour changes on the application name isn't a good idea, but if we're going to do it we need to remember to update the test when we rename the application. I am not certain that this change is globally correct; there may be other related problems that will not be fixed (and may in fact be exacerbated) by this patch.
* Fix for #4542 -- included classes weren't assigned proper stagesMarkus Roberts2010-08-241-13/+6
| | | | | | This commit unifies the code paths on which classes are added, alters the default stage to respect the stage of the parent if any, and assures that the resource is notified if its stage is assigned (turning an implicit stage into an explicit one).
* Fix for #4501 -- reports not generated in standaloneMarkus Roberts2010-08-241-5/+10
| | | | | | | The refactors for 2.6.x stopped "puppet apply" from saving reports; this fix adds report saving back to puppet apply but leaves a number of related issues (code path consolidation, report contents, etc.) unresolved for future patches in the 2.6.x series or more significant refactoring in 2.7.x.
* Start server before agentBernhard Miklautz2010-08-211-1/+1
|
* [#4555] puppet queue tries to call code it hasn't requiredJesse Wolfe2010-08-211-0/+1
| | | | | | | | | puppet queue was trying to call .subscribe on Puppet::Resource::Catalog::Queue, but that object had not been loaded into the ruby interpreter. This bug was partially masked by ruby's confusing constant resolution, which was incorrectly returning the Puppet::Application::Queue class instead of throwing a NameError
* fix #4528 - treat * as absentPeter Meier2010-08-211-1/+1
| | | | | | | Internally the cron type is seeing params containing only '*', as absent. However, if a user was setting a parameter explicitely as '*', we weren't munging it to be absent. Hence, we were setting this param over and over again.
* Fix for #4518 -- classes not getting added to compiler.classesMarkus Roberts2010-08-211-0/+1
| | | | | | | The responsibility for adding classes to the compiler's classes list (for use in constructing classes.txt) moved around a bit in the 0.25 to 2.6 transition before being dropped in a merge conflict resolution. Ooops. This restores it, and adds tests to prevent regression.
* Maint. -- Fix test failures broken by previous commitMarkus Roberts2010-08-211-2/+8
| | | | | | | This basically involved adding a search method to the yaml indirector, which I did by copying the one from ssl_file and fiddling with it until the tests passed. Since the most straight forward way to do this required extending the interface to the path method I added tests for the additional behaviour.
* Maint. Removing code at the request of the original authorMarkus Roberts2010-08-211-10/+1
| | | | A contributor has requested that his changes be removed from puppet.
* [#4298] Puppet apply prints an error if the file to apply doesn't existMatt Robinson2010-08-211-1/+4
| | | | | | | | Also warns you it's skipping files if you pass it more than one file to apply. Reviewed-by: Nick Lewis <nick@puppetlabs.com> Signed-off-by: Matt Robinson <matt@puppetlabs.com>
* Further RST to Markdown fixes for types, values, testsJames Turnbull2010-08-1214-183/+130
|
* Updated all types to Markdown outputJames Turnbull2010-08-1168-445/+410
| | | | | | | | | | Updated defaults.rb to Markdown Migrated report documentation to Markdown Migrated Naginator doco to Markdown Updated provider documentation to Markdown
* Updated reference output to generate valid MarkdownJames Turnbull2010-08-113-15/+9
|
* Reformatting documentation from RST to MarkDown (#4509)Jes Fraser2010-08-115-64/+64
| | | | Signed-off-by: Jes Fraser <jes@gadget.geek.nz>
* Rewrote functions documentation to MarkdownJames Turnbull2010-08-1118-119/+114
|
* Removed legacy Trac codeJames Turnbull2010-08-112-34/+3
|
* Fix for #4476 -- rails calling yaml internalsMarkus Roberts2010-08-061-1/+1
| | | | | | | | Some recent versions of rails have started calling yaml with the internal (and IIRC depricated) signature; this does nothing special in yaml but it breaks with zaml, so we add an ignored parameter to simulate the non-behavior. *sigh* I love rails.
* Fixes #4485 -- single quoted strings should not treat \n as new lineMarkus Roberts2010-08-051-11/+11
| | | | | | | | | | | | This is the rest of the change for #4303; James and I discussed various ways the solution to that ticket needed to be extended but, as neither of us committed code, nothing changed. This is the least implact extension, which mimics the behaviour of prior versions. It leaves open the question: should '\\x' start with a single or double backslash? If, as now, '\\x' starts with a double backslash (i.e. single quote is the only escapable characterin single quoted strings) a string ending in a backslash can not be represented in a single quoted string.
* Passenger needs HTTP headers values to be stringBrice Figureau2010-08-051-1/+1
| | | | | | | | | When streaming a file through rack, we set the Content-Length header to be the size of the transmitted file. This size is an int, and recent passenger versions only support string values. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* [#4404] Remove requirement for source on Parser::Resource::ParamNick Lewis2010-08-041-1/+1
| | | | | | | | Stage[main] is created without an associated source, to which Parser::Resource::Param objects. This patch observes that the source attribute of both Parser::Resource and Parser::Resource::Param seem not to be used anywhere, and removes the requirement that it be supplied.
* Fix #4458 - Do not dump the whole environment when instances can't be foundBrice Figureau2010-08-041-1/+1
| | | | | | | | | | | | | | | When generating the error message when we can't find any instances for a search request, we were "inspect"ing the request which now contains an environment instance which itself contains a lots of things (including all the known resource types). Thus it was generating a very large "reason" (ie the HTTP error string). On some environments (ie proxied mongrel) this was too large and the proxy would produce an error 500. I just changed the error message to just log the indirection name and request key (which should be enough to understand what is wrong). Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix for #4465 -- earlier "feature" patch broke ldapMarkus Roberts2010-08-041-52/+8
| | | | | | | | | The patch for #3904 should not have been accepted; it's buggy and the use case (supporting having nodes in ldap more than once with the same name but distinct records) is ill-conceived. This commit reverts the patch (a7884b47) and the previous attempt to fix it (e6709da4), restoring the old (0.25.x) behaviour.
* [#4467] Make Puppet Master respect facts_terminus settingsRein Henrichs2010-08-042-4/+1
| | | | | | | | | * Remove hard-coded facts terminus in master * Change facts_terminus default to 'yaml' for master and 'facter' for everything else. Paired-with: Matt Robinson <matt@puppetlabs.com> Signed-off-by: Rein Henrichs <rein@puppetlabs.com>
* added md5 support as requested in ↵Alice Kærast2010-08-031-0/+5
| | | | http://serverfault.com/questions/166199/puppet-md5-sum-of-string
* [#4381] extlookup shouldn't trigger reparses of .pp filesJesse Wolfe2010-08-031-3/+0
| | | | | | | extlookup was adding its data files to the list of watched source files. This causes the .pp manifests to be re-parsed whenever the .csv files change, which is no longer necessary, as the .csv files are already reparsed on every function call.
* [#4370] Fixes extlookup precedence getting overwritten between runsMatt Robinson2010-08-033-12/+7
| | | | | | | | | | | | | | | We found the gsub! in extlookup was actually modifying the value for extlookup_precedence, so the next node to call it just got the interpolated value from the first run. We did two things in the code to prevent this: 1. We returned a dup of the ast string object so that modifying it wouldn’t change puppet’s state. We didn’t do this for all possible return values because we depend on using the original ast array object to do array concatenation 2. We fixed extlookup to not do a destructive gsub Reviewed by: Jesse Wolfe
* Fixed #4364 - Reduced audit msg from info to debugJames Turnbull2010-08-031-1/+1
|
* [#4347] run_mode was colliding with --mode for "puppet doc"Jesse Wolfe2010-08-032-2/+2
| | | | | | The run_mode value was incorrectly getting stored to Puppet[:mode], which was confusing the optparser for applications that declare a --mode parameter.
* [#4423] repair parameterized class instantiationJesse Wolfe2010-08-033-17/+25
| | | | | | My earlier #4397 patch was not aware of the parameterized class instantiation syntax, and failed on manifests that instantiate parameterized classes.
* [#4423] class { shouldn't get stored on the namespace stackJesse Wolfe2010-08-031-1/+1
| | | | | | | The new syntax for instantiating parameterized classes was confusing the lexer's notion of namespaces. This is a simple fix to prevent that syntax from polluting the namespaces.
* [#4397]+[#4344] Move type-name resolution out of Puppet::Resource into the ↵Jesse Wolfe2010-08-036-130/+57
| | | | | | | | | | | | | | | | | | AST resources. Move type-name resolution out of Puppet::Resource into the AST resources. Move find_resource_type out of Puppet::Resource into Scope Thus, never pass unqualified type names to Puppet::Resource objects. Thus, Puppet::Resource objects don't need the namespace property, and Puppet::Resource objects never consult the harddrive to look for .pp files that might contain their type definitions, Thus, performance is improved. Also removes the temporary fix for #4257 that caused #4397 (The code was too eager to look for a class in the topscope) Paired-With: Paul Berry <paul@puppetlabs.com> Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
* [#4344] Temporary fix to stop agent from importing modulesNick Lewis2010-08-031-0/+4
| | | | | | | Due to type collection madness, agent tries to import modules to resolve resource types. That is wrong, decreases performance, and causes problems. This patch forces agent to not import any files by setting ignoreimport to true.
* [#4344] Fix for failing templates when module name matches file in local dir.Paul Berry2010-08-031-1/+1
| | | | | | | | | When the name of a module matches the name of a file in the local directory, puppet agent would sometimes try to read that file and interpret it as puppet code. This happened because files.rb was unintentionally permitting puppet files without an extension. Fixed by changing the glob pattern to only permit ".pp" and ".rb" extensions.