summaryrefslogtreecommitdiffstats
path: root/lib/puppet
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | Rename variable used in File type validation to be more clearJacob Helwig2011-02-011-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'count' variable is used to keep track of how many 'creator' parameters are set on the Type in order to raise an exception if this is greater than one. Be explicit about this. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
| * | | | | | Remove invalid "timestamp" and "time", and add missing "ctime" File checksum ↵Jacob Helwig2011-02-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | types. 'timestamp', and 'time' have been invalid since well before 2.6.0, so do not add them to the list of valid checksum types. 'ctime' was missing from the list of valid checksum types, so add it. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
| * | | | | | Remove order dependency when specifying source and checksum on File typeJacob Helwig2011-02-011-1/+0
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If source was specified after setting the checksum, it would cause the checksum to be set back to :md5. This was completely unnecessary, because the checksum has its own default of :md5. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
* | | | | | Merge remote branch 'jamtur01/tickets/2.6.x/3646' into 2.6.nextPaul Berry2011-02-011-0/+9
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | * jamtur01/tickets/2.6.x/3646: Fixed #3646 - Added documentation for compile and apply to man page
| * | | | | Fixed #3646 - Added documentation for compile and apply to man pageJames Turnbull2011-01-211-0/+9
| |/ / / /
* | | | | Bug #5755 -- ZAML generates extra newline in some hash backreferences.Daniel Pittman2011-01-311-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This data structure generates YAML with an extra newline that violates the syntax rules and all: list = [1] { :a => list, :b => list }.to_yaml This breaks real client use of the YAML catalogs, not to mention our own use of cached catalogs...
* | | | | bug #5681 -- code fix to handle AIX mount outputRick Bradley2011-01-311-1/+1
| | | | | | | | | | | | | | | | | | | | Making a simplified fix to find mount name in AIX mount command output.
* | | | | Bug #5681 -- parse AIX mount command output.Daniel Pittman2011-01-312-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Modified the Puppet::Provider::Mount (lib/puppet/provider/mount.rb) to parse AIX mount command output - Modified lib/puppet/type/mount.rb to set remount to false by default in AIX and fix small typo
* | | | | Fixed #6091 - Changed POSIX path matching to allow multiple leading slashesJames Turnbull2011-01-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | According to http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap03.html#tag_03_266: "Multiple successive slashes are considered to be the same as one slash.", so '//tmp/xxx' is a valid POSIX pathname. Thomas Bellman adds: You should probably read section 3.2 then as well: 3.2 Absolute Pathname A pathname beginning with a single or more than two slashes; see also Pathname. Note that a pathname starting with exactly two slashes is *not* an absolute pathname according to Posix. And 4.11 (Pathname Resolution) says: A pathname that begins with two successive slashes may be interpreted in an implementation-defined manner, although more than two leading slashes shall be treated as a single slash. Posix has this rule to accomodate DomainOS, which was a Unix- like OS from Apollo, where paths on the form "//foo/bar/gazonk" meant the file "/bar/gazonk" on the machine named "foo". You may recognize this format from URLs, or MS Windows SMB paths (with backslashes instead of forward slashes). This ignores that complication, since none of our supported platforms treat the '//' form as significant. Signed-off-by: James Turnbull <james@lovedthanlost.net> Signed-off-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Rick Bradley <rick@rickbradley.com>
* | | | | Fixed #6061 - Allowed -1 as password min/max ageJames Turnbull2011-01-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows setting disabling password aging on Linux and Solaris Signed-off-by: James Turnbull <james@lovedthanlost.net>
* | | | | Feature #5855 -- fix withenv call in freebsd package providerfredrik-eriksson2011-01-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Qualify 'withenv' in the provider, since it is part of an entirely different part of puppet, not a method on this provider. This closes #5855. Signed-off-by: fredrik-eriksson <fredrik.eriksson@loopia.se> Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
* | | | | Merge branch 'bug/2.6.next/6009' into 2.6.nextDaniel Pittman2011-01-251-2/+2
|\ \ \ \ \
| * | | | | Fixed #6009 - nested member list vs directory service group providerJames Turnbull2011-01-251-2/+2
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Directory Service group (and user) provider behaves erratically if members is a nested list; this happens with the following manifest: $r = ["root"] $a = ["daemon", "crc"] $n = ["nobody"] group { "testgroup": ensure => present, members => [$r, $a, $n] } This resolves the issue by flattening the list at the time we are using it; while a more general solution might be desirable this resolves the specific issue cleanly enough. Original patch from Clay Caviness. Tests by Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: James Turnbull <james@lovedthanlost.net>
* | | | | (#5944) Remove documentation of define() when used on nodes, as it is not a ↵nfagerlund2011-01-251-21/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | supported use of this function. Final patch in this series reviewed by Dan Bode.
* | | | | (#5944) Further edits of inline defined() documentation.nfagerlund2011-01-251-25/+30
| | | | | | | | | | | | | | | | | | | | Fixing use of define/declare; editing for clarity.
* | | | | (#5944) Improve documentation of defined() functionnfagerlund2011-01-251-6/+41
| | | | | | | | | | | | | | | | | | | | The differences in the way defined() handles different types of entities weren't well-explained. Documentation was also added for the behavior of defined(Node["somenode.domain.com"]).
* | | | | Merge branch 'ticket/2.6.next/5594' into 2.6.nextnfagerlund2011-01-251-32/+2
|\ \ \ \ \
| * | | | | (#5594) Update documentation of exec resource type.nfagerlund2011-01-251-32/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The exec resource doc referred to duplicate names being allowed, which stopped being true in 0.24.2. Reviewed by Matt Robinson.
* | | | | | Merge branch 'ticket/2.6.next/5931' into 2.6.nextPaul Berry2011-01-2519-55/+31
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/2.6.next/5931: (#5931) Prevent errors when calling insync? on audited properties Maint: Removed dead code from resource harness. Maint: Rename misleading insync? method in file provider
| * | | | | (#5931) Prevent errors when calling insync? on audited propertiesPaul Berry2011-01-2518-34/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Created a method safe_insync? which first checks whether the property has a "should" value of nil, and if so returns true. Most insync? methods were already doing this, but a few were not, leading to bugs if a property was being audited but not set. Types should continue to override the insync? method, but callers of insync? should call safe_insync? instead. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
| * | | | | Maint: Removed dead code from resource harness.Paul Berry2011-01-251-18/+0
| | | | | | | | | | | | | | | | | | | | | | | | Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
| * | | | | Maint: Rename misleading insync? method in file providerPaul Berry2011-01-253-3/+3
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method actually checks whether the file owner is in sync. Renamed to is_owner_insync? Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
* / / / / (#5548) Specify return values of manual status commands in service type ↵nfagerlund2011-01-251-4/+10
|/ / / / | | | | | | | | | | | | | | | | | | | | description. Reviewed by Matt Robinson.
* | | | (#5900) Include ResourceStatus#failed in serialized reportsNick Lewis2011-01-141-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This property was excluded from serialization because it was believed that its value could be determined by looking at the events of a ResourceStatus. However, if a resource can't be retrieved, it will have no events created, and will have no other way of determining its status. Reviewed-By: Paul Berry
* | | | (#5882) Added error-handling for bucketing files in puppet inspectNick Lewis2011-01-131-1/+5
| | | | | | | | | | | | | | | | Paired-With: Paul Berry
* | | | (#5882) Added error-handling to puppet inspect when auditingNick Lewis2011-01-131-12/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If auditing a resource fails, the report will contain failure events for every audited property of the resource. The report itself will also be marked as "failed". Paired-With: Paul Berry
* | | | (#5171) Made "puppet inspect" upload audited files to a file bucketPaul Berry2011-01-132-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This only occurs if the new setting :archive_files is set. Another new setting, :archive_file_server, can be used to specify the server that files should be uploaded to. Paired-with: Nick Lewis <nick@puppetlabs.com>
* | | | Prep for #5171: Added a missing require to inspect application.Paul Berry2011-01-131-0/+1
| | | | | | | | | | | | | | | | Paired-with: Nick Lewis <nick@puppetlabs.com>
* | | | (#5838) Support paths as part of file bucket requests.Paul Berry2011-01-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In versions of Puppet 2.6.0-2.6.4, file bucket requests are of the form md5/<checksum>/<path>. The path functionality has been removed, however we still need to support requests coming from older clients. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
* | | | (#5838) Make file bucket dipper efficient when saving a file that already existsPaul Berry2011-01-121-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Before saving to the file bucket, the file bucket dipper now checks to make sure that no file with the given checksum is already present. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
* | | | (#5838) Implemented the "head" method for FileBucketFile::File terminus.Paul Berry2011-01-123-180/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to do this it was necessary to refactor FileBucketFile to untangle responsibilities for computing paths, reading files, etc. In the process, removed speculative generalizations and unused functionality. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
* | | | (#5838) Added support for HEAD requests to the indirector.Paul Berry2011-01-127-13/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added the ability for the indirector to handle REST HEAD requests. These are done using a new indirector method, head(), which should return true if find() would return a result and false if find() would return nil. Access control for the head method is the union of that for the find and save methods. That is, if either find or save is allowed, then head is allowed. This is necessary so that users will not have to change their authconfig to take advantage of the new feature. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
* | | | (#5838) Refactored error handling logic into find_in_cache.Paul Berry2011-01-121-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved the error handling logic surrounding the call to Puppet::Indirector::Indirection#find_in_cache() into the find_in_cache() method itself, so that won't need to be duplicated when find_in_cache() is called from elsewhere. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
* | | | (#5838) Refactored Puppet::Network::Rights#fail_on_denyPaul Berry2011-01-122-23/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Changed into a method that returns the exception to raised rather than raising it. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
* | | | (#5171) Made filebucket able to perform diffsJesse Wolfe2011-01-113-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is now possible to ask the filebucket to diff two files using a URL of the form: https://puppet/production/file_bucket_file/md5/{first file hash}?diff_with={second file hash} The returned diff is a string, the output of the "diff" command. Paired-with: Paul Berry <paul@puppetlabs.com>
* | | | (#5710) Removed unnecessary calls to insync?Paul Berry2011-01-071-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the resource harness, we were calling insync? on all properties of a resource, even if those properties weren't being managed. This was unsafe. Changed to only call insync? on properties that are mentioned in the manifest. In addition, we discovered that the resource harness's computation of desired_values was incorrect, and was consulting the current system state rather than the desired state. Since this hash was (erroneously) only being consulted to see if it included :ensure, this didn't cause any obvious bugs. However it is now fixed. Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
* | | | Merge branch 'ticket/2.6.next/5799' into 2.6.nextNick Lewis2011-01-071-19/+1
|\| | |
| * | | (#5799) Simplify report dir creationNick Lewis2011-01-061-19/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This report processor was unnecessarily using Puppet to create a single directory. This was causing complex failures in any spec dealing with reports. Paired-With: Paul Berry
* | | | Merge branch 'maint/2.6.next/inspect_audited_should_be_true' into 2.6.nextMatt Robinson2011-01-061-1/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | * maint/2.6.next/inspect_audited_should_be_true: maint: Inspect reports should have audited = true on events
| * | | | maint: Inspect reports should have audited = true on eventsMatt Robinson2011-01-061-1/+7
| |/ / / | | | | | | | | | | | | Paired-with: Jesse Wolfe
* / / / Maint: Added "skipped" to the YAML output for Puppet::Resource::StatusPaul Berry2011-01-061-1/+2
|/ / / | | | | | | | | | | | | | | | In 2.6.4 and earlier, "skipped" appeared only when true. A recent change accidentally caused it to never appear. This change makes it always appear.
* | | maint: remove stray debug statement.Jesse Wolfe2011-01-031-1/+1
| | | | | | | | | | | | I accidentally committed a debug statement. Now I am removing it.
* | | Merge branch 'maint/2.6.next/speed_up_slow_inspects' into 2.6.nextJesse Wolfe2011-01-035-0/+20
|\ \ \
| * | | maint: Prune #inspect methods on various objectsJesse Wolfe2011-01-035-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby's default #inspect method can lead to printing factorial-order output for large graphs of objects. Since we have large graphs of objects, this is not optimal. This patch replaces a few well-connected objects' #inspect methods with methods that produce reduced output, and are thus much faster. Paired-With: Nick Lewis <nick@puppetlabs.com>
* | | | Merge branch 'ticket/2.6.next/5758' into 2.6.nextPaul Berry2011-01-032-7/+8
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | * ticket/2.6.next/5758: (#5758) Verify that report events are correctly created Prep work for #5758: set audited=true on all audit events Prep work for #5758: clean up initializer for Puppet::Transaction::Event
| * | | Prep work for #5758: set audited=true on all audit eventsPaul Berry2011-01-031-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, events would only have audited=true if auditing was enabled AND there had been a change in an audited parameter. Paired-with: Matt Robinson <matt@puppetlabs.com>
| * | | Prep work for #5758: clean up initializer for Puppet::Transaction::EventPaul Berry2011-01-031-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Puppet::Transaction::Event#initialize() contained unnecessary code that allowed the properties of an event to be passed in as separate arguments. This was never used. Paired-with: Matt Robinson <matt@puppetlabs.com>
* | | | Merge branch 'ticket/2.6.next/5698' into 2.6.nextJesse Wolfe2011-01-032-3/+7
|\ \ \ \ | |/ / / |/| | |
| * | | Fix #5698 puppet inspect shouldn't report of attributes of deleted filesJesse Wolfe2011-01-032-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a resource is absent, then reporting that its properties are all ":absent" is not particularly correct. This patch makes the `inspect` application's reports behave more like `apply` reports, and skip properties other than :ensure for absent resources. Reviewed-By: Nick Lewis <nick@puppetlabs.com>
* | | | (#5715) Added attributes resource_type and title to Puppet::Resource::Status.Paul Berry2010-12-301-2/+4
| | | | | | | | | | | | | | | | | | | | These new attributes save report processors from having to parse the "resource" attribute.