| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The 'count' variable is used to keep track of how many 'creator'
parameters are set on the Type in order to raise an exception if this is
greater than one. Be explicit about this.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
types.
'timestamp', and 'time' have been invalid since well before 2.6.0, so do
not add them to the list of valid checksum types.
'ctime' was missing from the list of valid checksum types, so add it.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If source was specified after setting the checksum, it would cause the
checksum to be set back to :md5. This was completely unnecessary, because
the checksum has its own default of :md5.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | | |
* jamtur01/tickets/2.6.x/3646:
Fixed #3646 - Added documentation for compile and apply to man page
|
| |/ / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This data structure generates YAML with an extra newline that violates the
syntax rules and all:
list = [1]
{ :a => list, :b => list }.to_yaml
This breaks real client use of the YAML catalogs, not to mention our own use
of cached catalogs...
|
| | | | |
| | | | |
| | | | |
| | | | | |
Making a simplified fix to find mount name in AIX mount command output.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Modified the Puppet::Provider::Mount (lib/puppet/provider/mount.rb) to parse
AIX mount command output
- Modified lib/puppet/type/mount.rb to set remount to false by default in AIX
and fix small typo
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
According to
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap03.html#tag_03_266:
"Multiple successive slashes are considered to be the same as one
slash.", so '//tmp/xxx' is a valid POSIX pathname.
Thomas Bellman adds:
You should probably read section 3.2 then as well:
3.2 Absolute Pathname
A pathname beginning with a single or more than two slashes;
see also Pathname.
Note that a pathname starting with exactly two slashes is *not*
an absolute pathname according to Posix. And 4.11 (Pathname
Resolution) says:
A pathname that begins with two successive slashes may be
interpreted in an implementation-defined manner, although
more than two leading slashes shall be treated as a single
slash.
Posix has this rule to accomodate DomainOS, which was a Unix-
like OS from Apollo, where paths on the form "//foo/bar/gazonk"
meant the file "/bar/gazonk" on the machine named "foo". You may
recognize this format from URLs, or MS Windows SMB paths (with
backslashes instead of forward slashes).
This ignores that complication, since none of our supported platforms treat
the '//' form as significant.
Signed-off-by: James Turnbull <james@lovedthanlost.net>
Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
Signed-off-by: Rick Bradley <rick@rickbradley.com>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This allows setting disabling password aging on Linux and Solaris
Signed-off-by: James Turnbull <james@lovedthanlost.net>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Qualify 'withenv' in the provider, since it is part of an entirely different
part of puppet, not a method on this provider. This closes #5855.
Signed-off-by: fredrik-eriksson <fredrik.eriksson@loopia.se>
Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
|
|\ \ \ \ \ |
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The Directory Service group (and user) provider behaves erratically if members
is a nested list; this happens with the following manifest:
$r = ["root"]
$a = ["daemon", "crc"]
$n = ["nobody"]
group { "testgroup":
ensure => present,
members => [$r, $a, $n]
}
This resolves the issue by flattening the list at the time we are using it;
while a more general solution might be desirable this resolves the specific
issue cleanly enough.
Original patch from Clay Caviness.
Tests by Daniel Pittman <daniel@puppetlabs.com>
Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
Signed-off-by: James Turnbull <james@lovedthanlost.net>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
supported use of this function.
Final patch in this series reviewed by Dan Bode.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixing use of define/declare; editing for clarity.
|
| | | | |
| | | | |
| | | | |
| | | | | |
The differences in the way defined() handles different types of entities weren't well-explained. Documentation was also added for the behavior of defined(Node["somenode.domain.com"]).
|
|\ \ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The exec resource doc referred to duplicate names being allowed, which stopped being true in 0.24.2.
Reviewed by Matt Robinson.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* ticket/2.6.next/5931:
(#5931) Prevent errors when calling insync? on audited properties
Maint: Removed dead code from resource harness.
Maint: Rename misleading insync? method in file provider
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Created a method safe_insync? which first checks whether the property
has a "should" value of nil, and if so returns true. Most insync?
methods were already doing this, but a few were not, leading to bugs
if a property was being audited but not set.
Types should continue to override the insync? method, but callers of
insync? should call safe_insync? instead.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This method actually checks whether the file owner is in sync.
Renamed to is_owner_insync?
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
description.
Reviewed by Matt Robinson.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This property was excluded from serialization because it was believed that its
value could be determined by looking at the events of a ResourceStatus.
However, if a resource can't be retrieved, it will have no events created, and
will have no other way of determining its status.
Reviewed-By: Paul Berry
|
| | | |
| | | |
| | | |
| | | | |
Paired-With: Paul Berry
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If auditing a resource fails, the report will contain failure events for every
audited property of the resource. The report itself will also be marked as
"failed".
Paired-With: Paul Berry
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This only occurs if the new setting :archive_files is set. Another
new setting, :archive_file_server, can be used to specify the server
that files should be uploaded to.
Paired-with: Nick Lewis <nick@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | | |
Paired-with: Nick Lewis <nick@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In versions of Puppet 2.6.0-2.6.4, file bucket requests are of the
form md5/<checksum>/<path>. The path functionality has been removed,
however we still need to support requests coming from older clients.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Before saving to the file bucket, the file bucket dipper now checks to
make sure that no file with the given checksum is already present.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In order to do this it was necessary to refactor FileBucketFile to
untangle responsibilities for computing paths, reading files, etc. In
the process, removed speculative generalizations and unused
functionality.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Added the ability for the indirector to handle REST HEAD requests.
These are done using a new indirector method, head(), which should
return true if find() would return a result and false if find() would
return nil.
Access control for the head method is the union of that for the find
and save methods. That is, if either find or save is allowed, then
head is allowed. This is necessary so that users will not have to
change their authconfig to take advantage of the new feature.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Moved the error handling logic surrounding the call to
Puppet::Indirector::Indirection#find_in_cache() into the
find_in_cache() method itself, so that won't need to be duplicated
when find_in_cache() is called from elsewhere.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Changed into a method that returns the exception to raised rather than
raising it.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It is now possible to ask the filebucket to diff two files using a URL
of the form:
https://puppet/production/file_bucket_file/md5/{first file hash}?diff_with={second file hash}
The returned diff is a string, the output of the "diff" command.
Paired-with: Paul Berry <paul@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In the resource harness, we were calling insync? on all properties of
a resource, even if those properties weren't being managed. This was
unsafe. Changed to only call insync? on properties that are mentioned
in the manifest.
In addition, we discovered that the resource harness's computation of
desired_values was incorrect, and was consulting the current system
state rather than the desired state. Since this hash was
(erroneously) only being consulted to see if it included :ensure, this
didn't cause any obvious bugs. However it is now fixed.
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
|
|\| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This report processor was unnecessarily using Puppet to create a
single directory. This was causing complex failures in any spec
dealing with reports.
Paired-With: Paul Berry
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
* maint/2.6.next/inspect_audited_should_be_true:
maint: Inspect reports should have audited = true on events
|
| |/ / /
| | | |
| | | |
| | | | |
Paired-with: Jesse Wolfe
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
In 2.6.4 and earlier, "skipped" appeared only when true. A recent
change accidentally caused it to never appear. This change makes it
always appear.
|
| | |
| | |
| | |
| | | |
I accidentally committed a debug statement. Now I am removing it.
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Ruby's default #inspect method can lead to printing factorial-order
output for large graphs of objects. Since we have large graphs of
objects, this is not optimal.
This patch replaces a few well-connected objects' #inspect methods with
methods that produce reduced output, and are thus much faster.
Paired-With: Nick Lewis <nick@puppetlabs.com>
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
* ticket/2.6.next/5758:
(#5758) Verify that report events are correctly created
Prep work for #5758: set audited=true on all audit events
Prep work for #5758: clean up initializer for Puppet::Transaction::Event
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously, events would only have audited=true if auditing was
enabled AND there had been a change in an audited parameter.
Paired-with: Matt Robinson <matt@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Puppet::Transaction::Event#initialize() contained unnecessary code
that allowed the properties of an event to be passed in as separate
arguments. This was never used.
Paired-with: Matt Robinson <matt@puppetlabs.com>
|
|\ \ \ \
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If a resource is absent, then reporting that its properties are all
":absent" is not particularly correct. This patch makes the `inspect`
application's reports behave more like `apply` reports, and skip
properties other than :ensure for absent resources.
Reviewed-By: Nick Lewis <nick@puppetlabs.com>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
These new attributes save report processors from having to parse the
"resource" attribute.
|