| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
fix UIDs but also GIDs
Fixes #1169
Fixes #804 (workaround was probably incomplete, as required changes in lib/puppet/util/posix.rb were missing)
Signed-off-by: Andreas Rogge <a.rogge@solvention.de>
|
|
|
|
|
|
|
|
|
|
| |
any local variables and added a local variable -- see
http://snurl.com/21zf8. My own testing showed that this
caused memory growth to level off at a reasonable level.
Note that the link above says the problem is only with class
methods, but my own testing showed that it's any method that
meets these criteria. This is not a functional change, but
should hopefully be the last nail in the coffin of #1131.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, if there were an error creating a resource,
the error would propagate leaving any previously
created resources still in memory.
Now, resources are removed by default when an error
happens during instantiation, and the error propagates
to the caller so that they can log or whatever.
This also allows the Settings class to correctly and
separately handle the cases where we can't create the
catalog (which should never happen in normal usage but
was happening because of this error -- later catalogs
couldn't be created because earlier catalogs left
resources lying around) from those where we can't
apply the catalog.
|
| |
|
|
|
|
| |
once, which should make the system a bit more efficient.
|
|
|
|
|
|
| |
(#1036). The problem only cropped up if there was a failure
when trying to manage the system -- this would cause the
setting-based resources not to get cleaned up.
|
|
|
|
| |
Fixes #1086
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The CA serial file was getting owned by root because it was using a different method to write to file
Pulled the readwritelock out of lib/puppet/sslcertificates/ca.rb into lib/puppet/util/settings.rb
Refactored write, writesub and readwritelock a bit to reuse code
(write and readwritelock both call writesub)
Added a mode to :serial in lib/puppet/util/defaults.rb
|
|\ |
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
any objects, nor does it use Puppet's RAL resources. In the
process, I fixed #894 (you can now copy links) and refactored
other classes as necessary. Mostly it was fixing tests.
This is a squashed commit of a temporary branch, fwiw,
and it also includes any fixes to the tests that were
necessary to get all tests passing again.
|
| |
|
|
|
|
| |
slightly based on the code in type/file/checksum.rb.
|
|
|
|
|
|
| |
with the rest of the checksums we're likely to use,
and adding tests, which I somehow missed when I wrote
this file.
|
|
|
|
| |
from modules even when Autoload#loadall is used.
|
| |
|
|
|
|
|
|
| |
in each module, in addition to the lib directory. The 'lib'
directory is also deprecated, but supported for now to give
people a chance to convert.
|
| |
|
|
|
|
| |
removing the bangs from 'add_vertex!' and 'add_edge!'.
|
| |
|
|
|
|
|
| |
correctly ignored, and you now use 'false' instead of 'none'
to explicitly ignore them.
|
|
|
|
| |
file values that are false.
|
|
|
|
| |
class skip any resources that are already in memory.
|
|
|
|
|
|
| |
the class parts are now added as tags. I've also
created a Tagging module that we should push throughout
the rest of the system that uses tags.
|
|
|
|
| |
from the system, and implemented my own topsort method.
|
|
|
|
| |
done this but I must not have committed it.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I use Naginator to parse and generate the files, with
ParsedFile to handle record management and the like.
Note that each resource type itself is just a call to
a Factory method, since everything is just based on Naginator.
Given that, all of the tests are in a single unit/ral/types/nagios.rb
file, since I used a factory to generate them, too. This is probably
either unnecessary or insufficient, but it's as far as I'm
willing to go in testing them, and it did actually catch a few
bugs.
|
|
|
|
|
|
| |
and Naginator providers. This is basically all of
the code that's necessary to create all of the needed
Nagios types.
|
|
|
|
|
|
|
| |
caused other problems.
This whole thing will hopefully get *drastically* easier once we
get rid of global resources.
|
|
|
|
|
|
|
|
|
| |
resulted in the resource duplication, based on how the
settings are used, so I added a test to only use those settings
if the directories do not exist.
This isn't a great fix, but it will suffice until I can kill these
resource conflicts once and for all.
|
| |
|
|
|
|
| |
necessary to support it.
|
|
|
|
|
|
| |
except that I was not passing the interpolated value in
to the hook, which meant the libdir was set to something
like $vardir/lib.
|
|
|
|
|
| |
when the configuration file is parsed. The bug is still
there, but I'm getting closer.
|
| |
|
|
|
|
|
| |
no tests for now, since it's a very small chunk of code
and it's *insanely* difficult to test this kind problem.
|
|
|
|
|
|
|
|
| |
so that it correctly just yields if you're not root. It
also no longer tries to set :uid or :gid; just :euid and :egid,
and it once again sets :egid before it sets :euid, which is
important because you usually can't change your group after
you've changed your user id.
|
|
|
|
| |
method to provider features.
|
| |
|
|\
| |
| |
| |
| |
| | |
Conflicts:
CHANGELOG
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
mount, fixing #891. The patch was ported to the current
code by David Schmitt, I applied the rest of Matt's
patches, and I then fixed all of the code so that the
tests passed.
The primary change I had to make to the patch was reenabling
host expansion in paths -- his patch had disabled it.
|
|/
|
|
| |
20070913004017-6856b-cdbbba99de0b33b64874205a27833b5114fcc6b9.patch by womble -- Allow empty config settings
|
|
|
|
|
| |
class for Parameter, which apparently lost the 'nodoc' method
for that class.
|
|
|
|
| |
fix #791.
|
|
|
|
|
|
|
|
| |
resources. These are commits:
c19835ce9f8a5138b30a1a32ca741c996b0916d2
9290cc89a2206fb5204578f8e91208857a48b147
ffb4c2dbc7314b364d25e4f7be599ef05b767b44
|
|\ |
|
| | |
|