summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fixes #2503Markus Roberts2009-08-131-2/+8
| | | | | | | | | | | Added a random suffex to the temporary file name and verify that the name is not in use (retry on collison). No additional tests added as the lifetime of the temporary file is bound by the routine, making spec driven tests impraticable. Includes logic to account for dead-end symlinks as well, as per Luke. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixes #2360 - Removed annoying log messageAndrew Shafer2009-08-132-9/+15
| | | | | | This change will effect all the properties implemented with list.rb (groups, roles, auths, profiles). The change will match [] values for should as insync when none exist. (so no more log message)
* Fixed #2525 - Wrong method being overridden in Red Hat servicesJames Turnbull2009-08-111-1/+1
|
* Fixing more tests broken from missing librariesLuke Kanies2009-08-106-15/+31
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing ActiveRecord Indirector tests to skip w/out RailsLuke Kanies2009-08-104-6/+9
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2489 - queue integration tests are skipped w/out jsonLuke Kanies2009-08-102-3/+4
| | | | | | | | | All of the tests were failing because we had a call outside of any of the tests, just to autoload the constant. Removed that call and stubbed things so the tests don't run without json. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2508 - removing mention of ActiveRecord 2.3Luke Kanies2009-08-101-1/+1
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2541 - file cache is more resilient to failureLuke Kanies2009-08-102-8/+42
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* vim: Mark puppetFunction values as containedTodd Zullinger2009-08-091-1/+1
| | | | | | | This prevents 'file' from being highlighted as a function when it is used as a resource. Signed-off-by: Todd Zullinger <tmz@pobox.com>
* Add shellquote() function.Thomas Bellman2009-08-082-0/+133
| | | | | | | | | | This adds a new function shellquote() which can be used for quoting arguments in shell commands used in the exec type. This only supports Unixoid operating systems. Other systems would likely require some other quoting. Signed-off-by: Thomas Bellman <bellman@nsc.liu.se>
* Fixes #2499. Allows execs to specify an array for the returns parameterNigel Kersten2009-08-082-8/+21
|
* Updated fix for #2481James Turnbull2009-08-051-3/+5
|
* Revert "Fxied #2481 - Added status and restart overrides for Red Hat service ↵James Turnbull2009-08-051-4/+4
| | | | | | provider." This reverts commit 967eb9f52938d8849b99686bf2c0b9da9a183399.
* Fixed #2498 - logcheck updateJames Turnbull2009-08-051-1/+1
|
* Removed extraneous debuggingroot2009-08-041-4/+0
|
* Updated two more testsJames Turnbull2009-08-042-0/+5
|
* Logs now assume resource params have metadataLuke Kanies2009-08-032-8/+1
| | | | | | | | | | | We were previously not assuming they had it, because I figured there were just a couple that didn't. On closer inspection, none of them did. The previous commit fixed that, so this commit fixes the assumption. Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding metadata delegation from param to resourceLuke Kanies2009-08-034-19/+34
| | | | | | | | | | This is for file, line, version, and tags, with the parameter name added to the tags. This is mostly so logs generated by the parameters work better. Signed-off-by: Luke Kanies <luke@madstop.com>
* Removing unnecessary debug outputLuke Kanies2009-08-031-1/+0
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding integration tests for #2371 (backup refactor)Luke Kanies2009-08-032-119/+106
| | | | | | Also removed old conflicting file tests. Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding many tests for #2371, and slightly refactoringLuke Kanies2009-08-032-47/+139
| | | | | | | | This mostly focuses on adding all of the detailed tests for this new code, but it also cleans the code up just a little bit. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixes for Redmine 2371.Steven Jenkins2009-08-033-125/+157
| | | | | | | | | | | This changes the condition checking of handlebucket, as well as moves it (and remove_backup) into a separate module. It additionally refactors common code out of handlebucket into separate private methods. Some new RSpec tests which use mock and stubs are added as well, including removing the old test/ral/type/filebucket.rb tests since they are already covered by RSpec tests.
* Fixes #2464, #2457. Deprecate reportserver for report_server. Add ↵Nigel Kersten2009-08-044-3/+64
| | | | report_port setting. Add tests.
* Fixing #2484 - "format missing" messages are betterLuke Kanies2009-08-041-2/+2
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixes #2483 - Log only copies metadata from RAL objectsLuke Kanies2009-08-042-16/+36
| | | | | | | | | | | | | | | | | | | We were previously trying to figure out what data was available based on what methods existed, but that caught a different method profile from modules. This fixes it so we only look for this data from Puppet::Type or Puppet::Parameter instances. I had to add the ability to skip data that's not available, since File's 'ensure' parameter doesn't have 'file' data, I assume because of the metaprogramming we do around the 'file' value for 'ensure'. It's a workaround for now, and there's a test in there to verify it, anyway. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixed #2486 - Missing require 'monitor' in parser_support.rbJames Turnbull2009-08-041-0/+1
|
* Added R.I.Pienaar's extlookup.rb to the ext directoryJames Turnbull2009-08-031-0/+183
|
* Added example conf/puppet-queue.confJames Turnbull2009-08-031-0/+10
|
* Fxied #2481 - Added status and restart overrides for Red Hat service provider.James Turnbull2009-08-031-4/+4
|
* rack: SSL Env vars can be in Request.env or ENVChristian Hofstaedtler2009-08-034-12/+33
| | | | | | | Fix #2386, by checking either Request.env or ENV for the SSL environment variables. This is necessary as Passenger 2.2.3 changed the location of these vars, even though the Rack spec says nothing about ENV or these variables.
* rack: don't directly use the forbidden HTTP_CONTENT_TYPE env var (fixes rack ↵Christian Hofstaedtler2009-08-032-3/+3
| | | | specification conformance)
* Removing old filebucket testLuke Kanies2009-08-031-110/+0
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Cleaning up tests for #2469Luke Kanies2009-08-032-43/+70
| | | | | | | This is a small refactor of the filebucket type, and a larger refactor of the tests. Signed-off-by: Luke Kanies <luke@madstop.com>
* default server in remote filebucketsTill Maas2009-08-033-23/+62
| | | | | | | | | | | | With the path parameter set to false, the server defaults to Puppet[:server]. This allows to use a remote filebucket without syncing the servername there with the one used on the config file. To use the default server, this manifest can be used: filebucket { main: path => false } A related bug report is: http://projects.reductivelabs.com/issues/2456
* Fixes #2444 - Various JSON test failuresMarkus Roberts2009-08-031-3/+17
|
* Fixed #2294 - Classes sometimes cannot be foundMarkus Roberts2009-08-032-53/+134
| | | | | | | | | | | | | | | | | | | | | | | | This patch should fix the race condition causing ticket 2294; it extends the loading logic so that: * initial load attempts are processed (as before), * recursive load attempts return immediately (as before), * but subsequent concurrent load attempts from different threads wait on a semaphore (condition variable) and then retry (e.g. use the now-valid results of the first thread). This is a slight modification of the solution I'd originally proposed, to prevent a deadlock that could have arisen if three or more threads simultaneously attempted to load the same item. Though it solves the bug as reported, it has room for improvement: * Failures aren't cached, so repeated attempts will be made to import invalid items each time they are encountered * It doesn't address any of the underlying referential ambiguity (module vs. filename) * The threading logic should probably be refactored into a separate class (as a start I encapsulated it in an ad hoc singleton class, so at least it isn't cluttering up the load method) Signed-off-by: Markus Roberts <Markus@reality.com>
* Adding #2477 - puppet can apply provided catalogsLuke Kanies2009-08-025-35/+187
| | | | | | | | | | | | This provides the other half of #2440 - you can compile catalogs into json with puppetmasterd, and now you can take those json catalogs and apply them. This allows you to use whatever mechanism you want to ship the catalogs around. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing problems my Feature refactor causedLuke Kanies2009-08-022-6/+9
| | | | | | | | | The problems were that I wasn't propagating return values sufficiently, such that false values didn't travel enough, and the 'name' attribute was necessary in the private method but wasn't actually passed in. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing ruby warning in definition testLuke Kanies2009-08-021-1/+1
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixed global deprecation error in useradd Unit testsJames Turnbull2009-08-021-3/+0
|
* Adding a test for the Exec typeLuke Kanies2009-08-021-0/+13
| | | | | | | | I thought I'd found a bug, but I couldn't reproduce it. This test was supposed to demonstrate the bug, but is at least good enough to leave in. Signed-off-by: Luke Kanies <luke@madstop.com>
* Speeding a test up through stubbingLuke Kanies2009-08-021-0/+1
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing a small test by stubbing instead of mockingLuke Kanies2009-08-021-2/+1
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing a test broken by the regex featuresLuke Kanies2009-08-021-0/+14
| | | | | | | | Unsetting scope vars was broken, but it was only ever used in testing (and apparently rarely at that), so it wasn't caught. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing tests broken by caching autoload resultsLuke Kanies2009-08-023-10/+3
| | | | | | | | | These tests tried to load something, verified the loads didn't work, and then created the thing to load. This is a bit silly, so I just removed those sections of the tests. Signed-off-by: Luke Kanies <luke@madstop.com>
* Migrating Handler base tests from test/ to spec/Luke Kanies2009-08-022-63/+25
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Migrating Feature tests to specLuke Kanies2009-08-024-110/+145
| | | | | | | | | | This was to fix a failing test/unit test. Test coverage is now a bit better, more maintainable, and I refactored the code just slightly to make it a bit cleaner. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing cron test to match new behaviourLuke Kanies2009-08-021-1/+1
| | | | | | | 7 was added as a valid weekday in #2293, and this test just corrects that. Signed-off-by: Luke Kanies <luke@madstop.com>
* Migrating tests to spec and removing an obsolete testLuke Kanies2009-08-022-70/+19
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Logging the configuration version we're applyingLuke Kanies2009-08-011-0/+2
| | | | | | | This is just an additional info log in the transaction, and is only done if the version is non-nil. Signed-off-by: Luke Kanies <luke@madstop.com>
generated by cgit (git 2.34.1) at 2025-09-30 12:37:17 +0000