summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* [#4090] Rename mode (:master, :agent, :user) to run_modeMatt Robinson2010-07-0120-65/+65
| | | | | | | | Mode is a terribly overused word. Files use it, puppetdoc uses it, and certs use it, and those are just the places that I happened to stumble upon. It makes reading code very confusing and finding things in code difficult. I know namespacing allows us to reuse words for method and variable names, but that doesn't mean we should.
* [#4089] Replace internal usage of :check with :auditNick Lewis2010-07-018-11/+11
| | | | | | Per Luke's replacement of :check with :audit, and deprecation of :check, I've replaced all of our internal uses of :check with :audit. Importantly, this silence the deprecation warnings during regular usage from eg. ralsh.
* [#3961] puppet cert --generate implies ca_location = :localJesse Wolfe2010-06-301-1/+5
|
* [#3961] Rename cert's @mode to @cert_mode to reduce confusionJesse Wolfe2010-06-302-19/+19
|
* maint: Confine a test that depends on sqliteMatt Robinson2010-06-282-0/+4
| | | | I'm also going to update the wiki to mention sqlite is a test dependency
* [#3994-part 3] rename spec tests from *_spec_spec to *_spec.rbMarkus Roberts2010-06-28344-0/+0
| | | | Part 2 re-did the change on the spec files, which it shouldn't have.
* Fix for test ordering sporadic failureMarkus Roberts2010-06-281-1/+1
| | | | | The spec/unit/provider/ssh_authorized_key/parsed_spec_spec.rb was trying to use Dir.tempdir but getting ours.
* [#3994-part 2] rename integration tests to *_spec.rbMarkus Roberts2010-06-28397-0/+0
| | | | | | | | | Some spec files like active_record.rb had names that would confuse the load path and get loaded instead of the intended implentation when the spec was run from the same directory as the file. Author: Matt Robinson <matt@puppetlabs.com> Date: Fri Jun 11 15:29:33 2010 -0700
* Merge branch 'testing' into tweak/testing/file_fix_root_spec_failureMarkus Roberts2010-06-288-18/+16
|\
| * Merge branch 'testing' into tweak/testing/silence_spec_outputMarkus Roberts2010-06-285-11/+13
| |\
| | * maint: Fixing tests that fail when run as rootMatt Robinson2010-06-281-0/+2
| | | | | | | | | | | | | | | | | | | | | Commit ae520057280c2454bc44c64ac1e6686bf2eb086d introduced some code that used 'asuser' which does nothing when not run as root, but in these tests tries to run as a non-existent user. Stubbing out the asuser method to just yield prevents test failures when running as root.
| | * Cleaning up various warnings in specsMarkus Roberts2010-06-284-11/+11
| | | | | | | | | | | | | | | There were a bunch of "warning: parenthesize argument(s) for future version" messages; now there aren't.
| * | maint: Fixes some noisy specsNick Lewis2010-06-283-7/+3
| |/ | | | | | | | | This change removes some irrelevant output (debugging information, warnings, etc) from a few specs.
* / maint: A test specified that a file wasn't writeable, but was writeableMatt Robinson2010-06-281-1/+2
|/ | | | | | when run as root, which caused the test to fail. Changing the test so that a directory is in place of the writeable file so not even root can write to it.
* Removing obsolete nodescope conceptLuke Kanies2010-06-282-9/+1
| | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
* Fix #3665 - part 2, node inheritance fixesBrice Figureau2010-06-282-5/+47
| | | | | | | | We were looking only to the class hierarchies when trying to find an ancestor to the current type. Thus we were never trying to climb up the hierarchy of nodes when evaluating nodes. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix failing tests in spec/unit/resources/type.rbBrice Figureau2010-06-281-3/+2
| | | | Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix #3665 - main class shouldn't be a subscope of itselfBrice Figureau2010-06-282-1/+9
| | | | | | | | During the refactoring of AST hostclass/node to non AST objects, we lost the fact that the main class already comes with a scope (ie the top one), so when we evaluate its code we shouldn't create a subscope for it. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* maint: Fixes broken order-dependent Tidy specsNick Lewis2010-06-281-4/+4
| | | | | | A few specs were using a global variable rather than a local, causing an order-dependent failure in which they were replacing the object under test.
* Fix for pre 1.8.7 compatibility in namvar patchMarkus Roberts2010-06-282-12/+5
| | | | | | | | There was a subtle 1.8.7 dependence in the composite key / namevar patch; Nick discovered that our assumtion that hashes could be used as hash keys does not hold in earlier bersions of ruby. This patch replaces the hash valued uniqueness_key with an array of the values of the (ordered) key attributes.
* Breaking require-loopMarkus Roberts2010-06-271-1/+0
| | | | | | Merging some of the branches creates a require-loop; this commit breaks it by removing the most recently added link (which I believe to have been unneeded / unrelated to the patch in which it snuck in).
* Fix for #3985 typo causing warningMarkus Roberts2010-06-261-1/+1
| | | | There was a comma missing from a raise, which caused a warning message on each run.
* Fix: puppet apply trying to use XMLRPC constantJesse Wolfe2010-06-251-5/+1
|
* Remove an old test that had been unintentionally reintroduced by a mistake ↵Jesse Wolfe2010-06-251-48/+0
| | | | in a conflict resolution
* Tweak an old test due to new error handling.Jesse Wolfe2010-06-251-1/+1
|
* Restore error handling for value=Jesse Wolfe2010-06-251-10/+11
|
* Fix tests broken by level-violation fixJesse Wolfe2010-06-252-6/+5
|
* Simplify the newattr method by removing a level violationJesse Wolfe2010-06-254-25/+12
| | | | and update the specs that were testing it.
* maint: Rework testing of Reports http processor to be self containedRein Henrichs2010-06-251-5/+19
| | | | | * do not monkey patch Net::HTTP in a way that breaks other specs * Use fakes to sense behavior of Net::HTTP
* [#3139] Fixed a problem with the value method for parametersNick Lewis2010-06-251-1/+1
| | | | | The value method was failing to return any value in the case where the value was false.
* [#3139] Fixed a broken integration spec in type tidyNick Lewis2010-06-251-0/+5
| | | | | A change to the way host_config is determined caused this spec to call store when it didn't before, so it needed to be mocked.
* maint: Fixing test to reflect that host environment assignment now takes an ↵Matt Robinson2010-06-251-1/+1
| | | | object instead of a string
* Fix some tests broken by changing the call to newattrJesse Wolfe2010-06-251-2/+2
|
* Fixing oversensitive testMarkus Roberts2010-06-241-1/+1
| | | | The test checked for false when all we cared about was that it was not truthy.
* maint: Fix failing test that needed more methods stubbedMatt Robinson2010-06-241-2/+2
|
* Fixed require warning documentationJames Turnbull2010-06-241-3/+2
|
* Fixed mcx documentation errorJames Turnbull2010-06-241-1/+1
|
* Documentation fixesJames Turnbull2010-06-241-8/+8
|
* [#4006] Fix test failures caused by reverting ticket 2890Matt Robinson2010-06-241-1/+1
| | | | | | | | | When Markus reverted changes made by 2890 he reintroduced a method certificate_matches_key? that then caused failures in network/xmlrpc/client.rb. I just stubbed that method to return true since the failing tests weren't trying to test that methods behavior. Reviewed-by: Markus Roberts
* Bug 3731. Applied Fix suggested by Doug Warner to always flatten out the arrayBryan Kearney2010-06-241-0/+1
|
* maint: Have 'rake spec' output in colorMatt Robinson2010-06-241-1/+1
| | | | | | | | Ideally it would be nice if the rake task used personalized RSpec settings on a per user basis, but until someone figures that out color would be nice Signed-off-by: Matt Robinson <matt@puppetlabs.com>
* [#3810] Do not create a reports settings blockRein Henrichs2010-06-241-4/+2
| | | | | Puts reportdir and reporturl back in the "main" block because this makes tests break for reasons I don't understand.
* Tweak for fix for #1175 to fix test failuresMarkus Roberts2010-06-243-3/+7
| | | | | | Tests that weren't managing the environment but were still expecting to have functions defined in it were appalled when the functions/environments binding actually started working. This patch fixes those tests.
* maint: Fixing a test typo s/stub/stubs/Matt Robinson2010-06-241-1/+1
|
* maint: Fixing a failing spec by stubbing a method on a stubbed object that ↵Matt Robinson2010-06-241-0/+1
| | | | | | | should have been stubbed. This failure was introduced in commit 94390de11d046d4906842f33aa9865f6c3835633, which just had the message 'foo'.
* remove tests for removed codeJesse Wolfe2010-06-241-24/+0
|
* [#2646] Fixes the change to onetime made in b96cd6cNick Lewis2010-06-242-4/+7
| | | | | | This change allows the --onetime command line option to be set by the Puppet[:onetime] global option or read from the config file, rather than forcing it to be read from the config file.
* [#3139] Make newattr idempotentJesse Wolfe2010-06-242-14/+6
| | | | | audit's munge was not idempotent because newattr was not idempotent. This patch simplifies newattr such that it becomes idempotent.
* [#3994] rename the specs to have _spec.rb at the endMarkus Roberts2010-06-23344-0/+0
| | | | | | | | | Some spec files like active_record.rb had names that would confuse the load path and get loaded instead of the intended implentation when the spec was run from the same directory as the file. Author: Matt Robinson <matt@puppetlabs.com> Date: Fri Jun 11 15:29:33 2010 -0700
* [#4064] Modify the Rails spec to use the block form of confineRein Henrichs2010-02-171-1/+1
| | | | | | This prevents the lookup of the ActiveRecord constant from being performed until after we know that the Rails feature is available (from checking the confine of the parent describe block).
generated by cgit (git 2.34.1) at 2025-09-26 20:06:22 +0000