summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* maint: fix stubbing in catalog_spec.rbJesse Wolfe2010-07-021-0/+4
| | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* Maint: Improve the speed of setting settings.Nick Lewis2010-07-021-12/+19
| | | | | Our settings were slow because I was querying Application objects for their run_mode repetitively
* maint: file_spec heisenbugsJesse Wolfe2010-07-021-0/+7
| | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* Heisenbug: settings as catalog trying to create directoriesJesse Wolfe2010-07-021-0/+1
| | | | | Specs in settings were allowing the settings-as-catalog to escape onto the system.
* maint: spec_helper should reset settings directories on *every* testJesse Wolfe2010-07-021-5/+11
| | | | | Previously, spec_helper's attempts to set :confdir, and :vardir to /dev/null were getting thwarted by the Settings.clear in after_all
* maint: Remove a heisentest that wasn't testing what it claimedJesse Wolfe2010-07-021-25/+0
| | | | | | This test in agent_spec.rb was no longer testing any of Puppet::Application::Agent, but rather exercising Util::Settings in a naive way. Deleted.
* maint: spec_helper should only get loaded onceJesse Wolfe2010-07-021-0/+5
| | | | | | Added a C-style if-defined? guard to spec_helper.rb to make sure that it only gets evaluated once. (The file is getting loaded multiple times because ruby gets confused by relative paths in `require` statements)
* maint: :mutable_defaults to improve spec consistencyJesse Wolfe2010-07-023-4/+18
| | | | | | Added a Puppet::Util::Settings layer called :mutable_defaults to emulate the interaction between Puppet::Application and defaults.rb that was getting thwarted by rspec.
* [#4090] Fix the run_mode for certs and put tests on the applications to ↵Matt Robinson2010-07-026-6/+20
| | | | | | | assert their run_mode Also cleanup of an unecessary puts line, make master tests run when on their own, and moving a require to a more usual spot.
* [#4059] fix the specs to correctly mock the Puppet::Resource.new call signatureJesse Wolfe2010-07-021-2/+2
|
* [#4059] Minor errors preventing ralsh from runningJesse Wolfe2010-07-011-2/+1
|
* [#2713] Enable ELSIFJesse Wolfe2010-07-013-864/+923
|
* [#3172] puppet kick can take hostnames as bare argumentsJesse Wolfe2010-07-013-8/+12
|
* [#4108] Missing constants fail deliberately and with a messageNick Lewis2010-07-011-1/+6
| | | | | | | Previously, any failed call to Puppet::Application.find would result in an error being raised by const_get, resulting in a messy crash with a stack trace. Now that error is handled, and the application will print a message and exit.
* [#4092] Changed notify message to defined instead of changedNick Lewis2010-07-011-1/+1
| | | | | | Notify was returning a nil current value, rather than :absent, which caused puppet to think the message had been changed from blank to its new value, rather than defined as that value.
* Fix for #4091 -- require loop in executablesMarkus Roberts2010-07-012-2/+0
| | | | | The describe and resource (ralsh) applications required puppet, creating a loop & thus crashing them.
* [#4090] Change how RunMode instances are created so that an object for each ↵Matt Robinson2010-07-016-5/+11
| | | | | | | RunMode is only created once instead of every time it's called Got lots of unpredictable test failures, presumably because a new RunMode was being created every time we accessed the RunMode.
* [#4090] Fix last few tests and renames of mode to run_modeMatt Robinson2010-07-015-15/+5
|
* [#4090] Git rid of the idea that run_mode is a configurable option with defaultsMatt Robinson2010-07-018-18/+75
| | | | | Along the way this fixes an issue with 2.6 alpha that sections of the puppet config file were getting ignored.
* [#4090] Rename mode (:master, :agent, :user) to run_modeMatt Robinson2010-07-0120-65/+65
| | | | | | | | Mode is a terribly overused word. Files use it, puppetdoc uses it, and certs use it, and those are just the places that I happened to stumble upon. It makes reading code very confusing and finding things in code difficult. I know namespacing allows us to reuse words for method and variable names, but that doesn't mean we should.
* [#4089] Replace internal usage of :check with :auditNick Lewis2010-07-018-11/+11
| | | | | | Per Luke's replacement of :check with :audit, and deprecation of :check, I've replaced all of our internal uses of :check with :audit. Importantly, this silence the deprecation warnings during regular usage from eg. ralsh.
* [#3961] puppet cert --generate implies ca_location = :localJesse Wolfe2010-06-301-1/+5
|
* [#3961] Rename cert's @mode to @cert_mode to reduce confusionJesse Wolfe2010-06-302-19/+19
|
* maint: Confine a test that depends on sqliteMatt Robinson2010-06-282-0/+4
| | | | I'm also going to update the wiki to mention sqlite is a test dependency
* [#3994-part 3] rename spec tests from *_spec_spec to *_spec.rbMarkus Roberts2010-06-28344-0/+0
| | | | Part 2 re-did the change on the spec files, which it shouldn't have.
* Fix for test ordering sporadic failureMarkus Roberts2010-06-281-1/+1
| | | | | The spec/unit/provider/ssh_authorized_key/parsed_spec_spec.rb was trying to use Dir.tempdir but getting ours.
* [#3994-part 2] rename integration tests to *_spec.rbMarkus Roberts2010-06-28397-0/+0
| | | | | | | | | Some spec files like active_record.rb had names that would confuse the load path and get loaded instead of the intended implentation when the spec was run from the same directory as the file. Author: Matt Robinson <matt@puppetlabs.com> Date: Fri Jun 11 15:29:33 2010 -0700
* Merge branch 'testing' into tweak/testing/file_fix_root_spec_failureMarkus Roberts2010-06-288-18/+16
|\
| * Merge branch 'testing' into tweak/testing/silence_spec_outputMarkus Roberts2010-06-285-11/+13
| |\
| | * maint: Fixing tests that fail when run as rootMatt Robinson2010-06-281-0/+2
| | | | | | | | | | | | | | | | | | | | | Commit ae520057280c2454bc44c64ac1e6686bf2eb086d introduced some code that used 'asuser' which does nothing when not run as root, but in these tests tries to run as a non-existent user. Stubbing out the asuser method to just yield prevents test failures when running as root.
| | * Cleaning up various warnings in specsMarkus Roberts2010-06-284-11/+11
| | | | | | | | | | | | | | | There were a bunch of "warning: parenthesize argument(s) for future version" messages; now there aren't.
| * | maint: Fixes some noisy specsNick Lewis2010-06-283-7/+3
| |/ | | | | | | | | This change removes some irrelevant output (debugging information, warnings, etc) from a few specs.
* / maint: A test specified that a file wasn't writeable, but was writeableMatt Robinson2010-06-281-1/+2
|/ | | | | | when run as root, which caused the test to fail. Changing the test so that a directory is in place of the writeable file so not even root can write to it.
* Removing obsolete nodescope conceptLuke Kanies2010-06-282-9/+1
| | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
* Fix #3665 - part 2, node inheritance fixesBrice Figureau2010-06-282-5/+47
| | | | | | | | We were looking only to the class hierarchies when trying to find an ancestor to the current type. Thus we were never trying to climb up the hierarchy of nodes when evaluating nodes. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix failing tests in spec/unit/resources/type.rbBrice Figureau2010-06-281-3/+2
| | | | Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix #3665 - main class shouldn't be a subscope of itselfBrice Figureau2010-06-282-1/+9
| | | | | | | | During the refactoring of AST hostclass/node to non AST objects, we lost the fact that the main class already comes with a scope (ie the top one), so when we evaluate its code we shouldn't create a subscope for it. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* maint: Fixes broken order-dependent Tidy specsNick Lewis2010-06-281-4/+4
| | | | | | A few specs were using a global variable rather than a local, causing an order-dependent failure in which they were replacing the object under test.
* Fix for pre 1.8.7 compatibility in namvar patchMarkus Roberts2010-06-282-12/+5
| | | | | | | | There was a subtle 1.8.7 dependence in the composite key / namevar patch; Nick discovered that our assumtion that hashes could be used as hash keys does not hold in earlier bersions of ruby. This patch replaces the hash valued uniqueness_key with an array of the values of the (ordered) key attributes.
* Breaking require-loopMarkus Roberts2010-06-271-1/+0
| | | | | | Merging some of the branches creates a require-loop; this commit breaks it by removing the most recently added link (which I believe to have been unneeded / unrelated to the patch in which it snuck in).
* Fix for #3985 typo causing warningMarkus Roberts2010-06-261-1/+1
| | | | There was a comma missing from a raise, which caused a warning message on each run.
* Fix: puppet apply trying to use XMLRPC constantJesse Wolfe2010-06-251-5/+1
|
* Remove an old test that had been unintentionally reintroduced by a mistake ↵Jesse Wolfe2010-06-251-48/+0
| | | | in a conflict resolution
* Tweak an old test due to new error handling.Jesse Wolfe2010-06-251-1/+1
|
* Restore error handling for value=Jesse Wolfe2010-06-251-10/+11
|
* Fix tests broken by level-violation fixJesse Wolfe2010-06-252-6/+5
|
* Simplify the newattr method by removing a level violationJesse Wolfe2010-06-254-25/+12
| | | | and update the specs that were testing it.
* maint: Rework testing of Reports http processor to be self containedRein Henrichs2010-06-251-5/+19
| | | | | * do not monkey patch Net::HTTP in a way that breaks other specs * Use fakes to sense behavior of Net::HTTP
* [#3139] Fixed a problem with the value method for parametersNick Lewis2010-06-251-1/+1
| | | | | The value method was failing to return any value in the case where the value was false.
* [#3139] Fixed a broken integration spec in type tidyNick Lewis2010-06-251-0/+5
| | | | | A change to the way host_config is determined caused this spec to call store when it didn't before, so it needed to be mocked.
generated by cgit (git 2.34.1) at 2025-09-25 22:08:00 +0000