summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fixing #3407 Failing tests in spec/unit/node/environment.rbJesse Wolfe2010-03-223-19/+21
| | | | | | | | | A naked rescue in Puppet::Node::Environment was hiding expectation violations from the Mocha mocks. Specifically, 'modulepath' expectations were failing, as Puppet::Module now calls Puppet::Node::Environment#modulepath internally. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
* Bug #3406 augeas spec fails if there is not a default providerJesse Wolfe2010-03-221-0/+2
| | | | | | So I stubbed out the default provider. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
* Bug #3402 Stub returning invalid type for :noopJesse Wolfe2010-03-221-1/+2
| | | | | A stub was causing a test failure by returning a string for a parameter that requires a boolean.
* Bug #3401 Spec failed due to missing manditory setting in mockJesse Wolfe2010-03-221-2/+6
| | | | | Puppet::Util::Settings#use now requires the :noop setting to exist, and this test was not providing one in its mocked default structure.
* Bug #3400 Bad mocks causing failing testsJesse Wolfe2010-03-221-1/+3
| | | | | | New code was calling a mocked method that was stubbed too broadly, causing the whole thing to act strangely. I've tightened the existing stub and stubbed the new method call.
* Fix #3167 Duplicate constant warnings in dpkg.rbJesse Wolfe2010-02-172-8/+8
| | | | | | | | | | | | | | There's a limitation in Ruby 1.8.x that makes constants behave differently than developers seem to expect: Constants defined inside a do/end block do not get inserted into the namespace of 'self', they instead go into the toplevel (Object) namespace. These providers exhibit bugs since they use constants with the same name in the same namespace. Other providers and other dynamically generated classes using constants without an explicit namespace should be considered to have a code smell. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
* Merge branch '0.25.x'Markus Roberts2010-02-0958-1440/+1056
|\ | | | | | | | | | | | | | | | | | | Conflicts: lib/puppet/agent.rb lib/puppet/application/puppet.rb lib/puppet/configurer.rb man/man5/puppet.conf.5 spec/integration/defaults.rb spec/unit/configurer.rb
| * Fixed #3162 - tidy does not remove empty files when "size => 0" is setJames Turnbull2010-02-092-1/+7
| | | | | | | | | | | | Thanks to Stig Sandbeck Mathisen for the fix See also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513309
| * Fixed #3128 - Updated man pages and moved puppet.conf.8 to puppet.conf.5James Turnbull2010-02-097-1090/+723
| |
| * Add version number to puppetlast display.Mark Plaksin2010-02-081-1/+1
| | | | | | | | | | | | Move "cache expired" to the end of puppetlast lines. This way the number of seconds and puppet version are always in the same column.
| * Forgot fakedata called in specJames Turnbull2010-02-041-0/+1
| |
| * Fixing #2669 puppetmasterd integration has leaky stateJesse Wolfe2010-02-041-9/+20
| | | | | | | | | | | | | | | | | | | | | | This patches two leaks in the puppetmasterd integration tests that were preventing the script from succesfully connecting to its child puppetmasterd process more than once: 1) a race condition in shutting down puppetmasterd before restarting it 2) holding onto stale SSH certificate information. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fix for #2327, check the return types from augeas and fail where appropriateBryan Kearney2010-02-011-4/+10
| |
| * 2047: Add a not_include into matchBryan Kearney2010-02-013-0/+15
| |
| * Minor unit test fixesJames Turnbull2010-01-302-6/+6
| |
| * vim: Improve function matching when functions contain ')'Todd Zullinger2010-01-301-2/+4
| | | | | | | | | | | | | | This fixes #3017 (VIM syntax highlight for regsubst fails) by converting puppetFunction from a simple keyword to a region. Signed-off-by: Todd Zullinger <tmz@pobox.com>
| * vim: puppetDefArguments is contained by puppetDefineTodd Zullinger2010-01-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The argument list for a definition must be contained, otherwise it matches too much text. For example: define test($arg) { $foo = regsubst("$name", '(.*)', '\1') # The parentheses within the above regsubst are matched as part # of puppetDefArguments and the highlighting after is incorrect. } Marking puppetDefArguments as contained by puppetDefine fixes this. Signed-off-by: Todd Zullinger <tmz@pobox.com>
| * Fix for #3094 (libdir should take ":" delimited path)Markus Roberts2010-01-302-3/+4
| | | | | | | | | | | | | | | | Actually, File::PATH_SEPARATOR, which is generally, but not always, ":"). Since libdir is also the default for the plugin handler, users will need to specify it explicitly if a multipart libdir is given (and it will need to be one of the segments given in the libdir for the plugins to be found).
| * Fix #1842 Net::HTTP#enable_post_connection_check doesn't work anymoreJesse Wolfe2010-01-308-27/+9
| | | | | | | | | | | | | | | | | | | | The setting enable_post_connection_check doesn't exist on very many versions of ruby, and on those systems there's no way to disable domain name checking on HTTPS. The recommended work-around is to replace certificates when they have incorrect hostnames. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fix for #3035 (redhat services use init for source)Markus Roberts2010-01-301-1/+1
| | | | | | | | | | | | | | Redhat services generated a slew of errors because they "duplicated" the same services from the init provider on which the redhat provider is based (cf yum). Declaring the source suppresses these erroneous errors.
| * Fix for #3077 (unit tests broken in 0.25.1-->0.25.4)Markus Roberts2010-01-306-73/+18
| | | | | | | | | | | | Most of these were caused by alias --> host_aliases; one was caused by the canonicalization of resource references and one by the removal of puppet_module.
| * Fix for #3085 (user_role_add pulls from same source as useradd)Markus Roberts2010-01-301-1/+1
| |
| * Fix for #3114 (ruby's arbitrary limit on process groups too low)Markus Roberts2010-01-301-0/+1
| | | | | | | | | | | | In some circumstances ruby's arbitrary limit on process groups is too low (32). This patch raises the limit in the recommended manner, to a value which should suffice in all practical cases (1024).
| * Updated CHANGELOG for 0.25.4James Turnbull2010-01-291-103/+15
| |
| * Partial reversion of patch for #3088 to fix #3104 (Exception misreported)Markus Roberts2010-01-2412-16/+16
| | | | | | | | | | | | | | In my patch for #3088 I made a erroneous assumption about the ruby exception hierarchy and thus missed the fact that Timeout::error descends from both SignalError and Interrupt. This is a partial reversion of the patch for #3088 to let these through so that more useful error messages can be produced.
| * Updated CHANGELOG for 0.25.4rc3James Turnbull2010-01-251-10/+39
| |
| * Fix for #3088 (catching Exception also traps SystemExit)Markus Roberts2010-01-2412-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | Changing rescues from the default to Exception (to catch errors that don't descend from StandardError) had the unintended consequence of catching (and suppressing) SystemExit. This patch restores the behavior of by reraising the exception. Of the other exceptions that fall through the same crack (NoMemoryError, SignalException, LoadError, Interrupt, NotImplementedError, and ScriptError) this patch also reraises NoMemoryError, SignalException, and Interrupt in the same way and leaves the rest captured.
| * Fix for #3089 (timestamp may now be a time object, not a string)Markus Roberts2010-01-221-1/+1
| |
| * Fix for #3093 (also need to be able to call pkgget_with_cat on class)Markus Roberts2010-01-221-2/+2
| | | | | | | | Fixed to deal with scopig issues.
| * Uncommeniting the fix for #3001Markus Roberts2010-01-211-1/+1
| |
| * Updated CHANGELOG for 0.24.5rc2James Turnbull2010-01-201-290/+103
| |
| * Minimal fix for #3001 (failing to fetch metadata on dangling symlink)Markus Roberts2010-01-191-1/+1
| | | | | | | | | | | | | | FileTest.exists? returns false if the target of a symlink is missing; in such cases we still want to continue if the resource is a symlink, as we may be managing a dangling symlink. Continuing in such case either gives the desired behavior or a more specific/informative error message.
| * Fixing #2914 - pre/post hooks now work for transactionsLuke Kanies2010-01-186-6/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was built to be used with etckeeper to version control files in /etc, but can be used for essentially anything. This patch was built to be added to 0.25.4, so it's a least-modify approach. A better approach would be to refactor application/puppet.rb just a bit so it uses Configurer more. This is a simple patch - it just defines 'prerun_command' and 'postrun_command' settings, and runs the appropriate command around each transaction if they're set. Signed-off-by: Luke Kanies <luke@reductivelabs.com>
| * Fix for #3075 (sshkey host_aliases ignored)Markus Roberts2010-01-152-9/+28
| | | | | | | | | | | | | | In the alias --> host_aliases conversion, I overlooked parsed file provider for sshkeys. Now with tests.
| * Updated version and CHANGELOG for 0.25.4James Turnbull2010-01-142-43/+144
| |
| * Revert "Fix #2845 Cron entries using "special" parameter lose their title ↵James Turnbull2010-01-142-25/+9
| | | | | | | | | | | | | | | | when changed" This reverts commit c99f394bf8c10d13f3fa7d3ab7ab43ecf454c081. The fix broke cron jobs in 0.25.3 and was reverted for the 0.25.4 release.
* | Fixed Rails database testsJames Turnbull2010-01-281-10/+25
| |
* | Fix #3117 - cert fingerprinting uses a method not available in ruby <= 1.8.6Brice Figureau2010-01-282-3/+6
| | | | | | | | | | | | | | | | OpenSSL::Digest.hexdigest is not available on older ruby versions. This patch accesses directly to the digest instead (which hopefully support hexdigest). Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* | Fixed test error message.James Turnbull2010-01-281-1/+1
| |
* | First shot at the OpenSolaris pkg(5) providerMartin Englund2010-01-272-0/+177
| |
* | Feature #2839 - fingerprint certificateBrice Figureau2010-01-1914-59/+367
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds several things: * certificate fingerprinting in --list mode * a puppetca action called "--fingerprint" to display fingerprints of given certificates (or all including CSR) * a --fingerprint puppetd option to display client certificates * each time a CSR is generated, its fingerprint is displayed in the log It is also possible to use --digest in puppetca and puppetd to specify a specific digest algorithm. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* | Fix a few puppetd specs testsBrice Figureau2010-01-191-1/+2
| | | | | | | | Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* | Revert "Feature #2839 - fingerprint certificate"James Turnbull2010-01-197-185/+39
| | | | | | | | | | | | This reverts commit a9fb82b0026e75a670fec553b17de3b0f091c2a5. An older branch was pulled
* | Fixing #1054 - transaction reports are always sentLuke Kanies2010-01-188-131/+252
| | | | | | | | | | | | | | | | | | | | | | | | | | This refactors how reports, catalogs, configurers, and transactions are all related - the Configurer class manages the report, both creating and sending it, so the transaction is now just responsible for adding data to it. I'm still a bit uncomfortable of the coupling between transactions, the report, and configurer, but it's better than it was. This also fixes #2944 and #2973. Signed-off-by: Luke Kanies <luke@madstop.com>
* | Removing some unneeded validation code from Transaction.newLuke Kanies2010-01-181-8/+2
| | | | | | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* | Removing unused configurer codeLuke Kanies2010-01-181-6/+0
| | | | | | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* | Fix #2894 - exclude .pp files under modules files directoriesBrice Figureau2010-01-182-0/+7
| | | | | | | | | | | | | | | | | | | | Selinux modules files also ends in ".pp". Puppetdoc tries to parse them as if they are regular puppet files and then fails. This patch makes sure puppetdoc tells RDoc to exclude parsing .pp files in the modules files section. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* | Adapt to method name change since 8971d8Brice Figureau2010-01-183-5/+22
| | | | | | | | | | | | | | | | | | When the definition/hostclass/node AST types were removed, the parentclass method was renamed to 'parent'. This patch fixes the incorrect rdoc usage (and some deeper integration test so that it won't happen again). Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* | Feature #2839 - fingerprint certificateBrice Figureau2010-01-187-39/+185
| | | | | | | | | | | | | | | | | | | | | | | | This patch adds two things: * certificate fingerprinting in --list mode * a puppetca action called "--fingerprint" to display fingerprints of given certificates It is also possible to use --digest to specify a specific digest algorithm. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* | Feature #2395 - revoke when cleaning a certificate with puppetcaBrice Figureau2010-01-182-0/+11
| | | | | | | | | | | | | | | | As the ticket says: "the certificates would still be valid even if cleaned, therefore, it makes more sense revoke them instead." Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>