summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | (#7013) Return bound methods for when_rendering hooks.Daniel Pittman2011-04-192-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | We can return a method bound to the current face instance when we access the 'when_rendering' hook, which allows us to directly call them. Make that change, and add appropriate testing. Reviewed-By: Max Martin <max@puppetlabs.com>
| * | (#7013) Support 'when_rendering' and 'render_as' in actions.Daniel Pittman2011-04-197-58/+256
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These define the API used by folks writing actions that supports their rendering hooks. 'when_rendering' defines a helper method on the interface, which runs the users code in their expected context. 'render_as' just sets the default rendering format; by default this is :for_humans. Reviewed-By: Max Martin <max@puppetlabs.com>
| * | (#7013) better default rendering support for facesDaniel Pittman2011-04-192-4/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have some specific requirements around rendering, including the ability of authors of actions to add nice, custom rendering. To support that we want solid "basic" rendering for human-focused output. This implements that generic rendering correctly and to spec, to give a sound basis that we can build on for extensible rendering. (#7013) better default rendering support for faces We have some specific requirements around rendering, including the ability of authors of actions to add nice, custom rendering. To support that we want solid "basic" rendering for human-focused output. This implements that generic rendering correctly and to spec, to give a sound basis that we can build on for extensible rendering. Reviewed-By: Max Martin <max@puppetlabs.com>
| * | maint: make sure we don't ever default to being default...Daniel Pittman2011-04-191-1/+6
| | | | | | | | | | | | | | | | | | | | | We tested that we could make something a default action, but we also want to assert that we never accidentally make everything the default action. Paired-With: Max Martin <max@puppetlabs.com>
| * | maint: print 'false' in the default render method.Daniel Pittman2011-04-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We used to skip printing if the return value from an action was false; this made it impossible to display "false" to the user, which was a more meaningful output in some cases than nothing. maint: print 'false' in the default render method. We used to skip printing if the return value from an action was false; this made it impossible to display "false" to the user, which was a more meaningful output in some cases than nothing. Reviewed-By: Max Martin <max@puppetlabs.com>
| * | maint: delete README.strings, which is out of date.Daniel Pittman2011-04-191-115/+0
| | | | | | | | | | | | | | | | | | | | | This documentation has not been kept up to date with changes in the product, since it originated way back in the prototype of interfaces. Reviewed-By: Randall Hansen <randall@puppetlabs.com>
| * | maint: test the 'help' face has the default action 'help'Daniel Pittman2011-04-192-2/+7
| | | | | | | | | | | | | | | | | | | | | We had a pending test for this, but forgot to write it way back when we were implementing the feature. Add it now. Reviewed-By: Max Martin <max@puppetlabs.com>
* | | Merge branch 'bug/2.7.x/7132-a-summary-with-a-newline-is-accepted' into 2.7.xDaniel Pittman2011-04-195-39/+100
|\ \ \
| * | | maint: drop multi-version support from action loading.Daniel Pittman2011-04-191-20/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now we have no other support for multi-version loading in the code; we should strip out support from the action loading to mirror. Reviewed-By: Max Martin <max@puppetlabs.com>
| * | | (#6962) Add 'description' to faces and action.Daniel Pittman2011-04-195-44/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds the 'description' method to the faces and actions, as well as structured testing to ensure that the DSL works as expected. Reviewed-By: Max Martin <max@puppetlabs.com>
| * | | (#7132) Reject 'summary' text with newlines embedded.Daniel Pittman2011-04-194-20/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our summary documentation is used to provide single-line context to faces, actions, and other items. To support this we hard-fail if someone tries to use the summary to embed the long documentation, and point them to the right place to add the extended text. Reviewed-By: Max Martin <max@puppetlabs.com>
* | | | Merge branch 'ticket/2.7.x/7108' into 2.7.xnfagerlund2011-04-182-32/+17
|\ \ \ \ | |_|/ / |/| | |
| * | | (#7108) Update help/man text for puppet kicknfagerlund2011-04-181-25/+10
| | | | | | | | | | | | | | | | | | | | Puppet kick's help referred only to the outdated authconfig (namespaceauth.conf) file, rather than the modern rest_authconfig (auth.conf).
| * | | (#7108) Modernize description of --listen in defaults.rbnfagerlund2011-04-181-4/+4
| | | | | | | | | | | | | | | | --listen's description referred to the older XMLRPC authorization path.
| * | | Maint: puppetmaster -> puppet master in defaults.rbnfagerlund2011-04-181-3/+3
|/ / /
* | | (Maint) Fix a leaking spec, patching intermittent failures.Pieter van de Bruggen2011-04-181-7/+7
| | | | | | | | | Reviewed-By: Matt Robinson.
* | | Merge remote-tracking branch 'community/feature/puppet-device' into 2.7.xPieter van de Bruggen2011-04-1838-210/+1370
| | | | | | | | | | | | Reviewed-By: Mike Stahnke
* | | Merge branch 'ticket/2.7.x/7131-optional-arguments' into 2.7.xMax Martin2011-04-183-28/+32
|\ \ \ | | | | | | | | | | | | | | | | * ticket/2.7.x/7131-optional-arguments: (#7131) Remove support for optional arguments to options
| * | | (#7131) Remove support for optional arguments to optionsMax Martin2011-04-183-28/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per the design decision documented in #7131, optional arguments to options will no longer be supported. This patch causes such optional arguments to raise an error, and tests for this behavior. Also cleaned up some confusing use of the term "subject" in specs. Paired-with: Daniel Pittman
* | | | (Maint) Fixing an order-dependent failure.Pieter van de Bruggen2011-04-182-2/+1
|/ / / | | | | | | | | | | | | | | | Running spec/unit/option_spec.rb before requiring puppet/interface caused a circular require, and a failure. Paired-With: Max Martin
* | | Merge branch ↵Daniel Pittman2011-04-177-13/+64
|\ \ \ | | | | | | | | | | | | 'bug/2.7.x/7013-interfaces-should-be-able-to-mark-options-as-required' into 2.7.x
| * | | (#7013) Add support for required options.Pieter van de Bruggen2011-04-177-13/+64
| |/ / | | | | | | | | | | | | | | | | | | | | | This adds another hook into the generated wrapper, which invokes a method to validate arguments. This is used to raise an exception when required options have not been passed to the method. Reviewed-By: Daniel Pittman <daniel@puppetlabs.com>
* | | (Maint) Code cleanup.Pieter van de Bruggen2011-04-151-4/+21
| | | | | | | | | Reviewed-By: Daniel Pittman
* | | Merge branch 'maint/2.7.x/fix-spec' into 2.7.xNick Lewis2011-04-151-1/+1
|\ \ \
| * | | maint: Fix the missed failure from the previous commitNick Lewis2011-04-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | There were two times being used, and the previous fix only fixed one of them. Reviewed-By: Jacob Helwig
* | | | Merge branch 'maint/2.7.x/fix-spec' into 2.7.xNick Lewis2011-04-151-1/+1
|\| | | | |/ / |/| |
| * | maint: Fix a broken Puppet::Node::Facts specNick Lewis2011-04-151-1/+1
|/ / | | | | | | | | This was breaking in other timezones because it was comparing to a string literal representation of a time, which really varies between timezones.
* | Merge branch ↵Daniel Pittman2011-04-1518-85/+437
|\ \ | | | | | | | | | 'feature/2.7.x/6978-face-and-action-options-should-have-hooks-for-various-actions' into 2.7.x
| * | maint: speed up testing output of the help face.Daniel Pittman2011-04-151-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | We were generating the help output multiple times and testing it for multiple properties; now we generate it once and test it multiple times. This makes for less clear error reporting, but saving dozens of calls at ~ 1/3rd a second each is worth it. Paired-With: Max Martin <max@puppetlabs.com>
| * | (#7059) Use option hooks for the indirector terminus option.Daniel Pittman2011-04-152-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | We used to open-code terminus setting, which had a bunch of duplicate code. Now, instead, we use the option hooks, resulting in the same behaviour with much less code. Paired-With: Max Martin <max@puppetlabs.com>
| * | (#6978) Enforce the calling convention of option hooks.Daniel Pittman2011-04-153-17/+57
| | | | | | | | | | | | | | | | | | | | | | | | We require that hooks take exactly three arguments; now we enforce that in the DSL, to ensure we give good, and early, errors to users who do the wrong thing. Paired-With: Max Martin <max@puppetlabs.com>
| * | (#7059) Set the CA location using option hooks.Daniel Pittman2011-04-152-19/+18
| | | | | | | | | | | | | | | | | | | | | | | | Now that we support option hooks, we can use those to set the CA location rather than open-coding each chunk of support. As a side benefit we also set the CA location for inherited actions, as we should. Reviewed-By: Max Martin <max@puppetlabs.com>
| * | (#6978) Add before and after decorators to actions from options.Daniel Pittman2011-04-1512-44/+357
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Options can now add before_action and after_action blocks; these are invoked before or after any action is invoked on the face. This allows these options to declare common behaviour and have it automatically applied to the actions invoked. Option hooks have no defined order of invocation: they will run in a completely random order. Where there are dependencies they should be on the value of the options hash passed to the invocation, not on side-effects of the other invocations. You are not able to influence the arguments, options, or calling of the action body in a before or after decorator. This is by design. The invocation passes to the hook: 1. The action object representing this action. 2. The arguments to the action, as an array. 3. The options for the action, as a hash. Paired-With: Max Martin <max@puppetlabs.com>
| * | maint: delete an empty describe block containing no tests.Daniel Pittman2011-04-151-4/+0
| | | | | | | | | | | | Reviewed-By: Max Martin <max@puppetlabs.com>
* | | Merge branch 'tickets/2.7.x/7115' into 2.7.xPieter van de Bruggen2011-04-158-16/+98
|\ \ \
| * | | (#7115) Enable default actions.Pieter van de Bruggen2011-04-158-16/+98
| | |/ | |/| | | | | | | | | | | | | | | | This also enables the 'help' action on the 'help' face to serve as a default action. Reviewed-By: Daniel Pittman Reviewed-By: Nick Lewis
* | | Merge branch 'tickets/2.7.x/7111-deprecation-warning-wordsmithing' into 2.7.xJacob Helwig2011-04-151-3/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | * tickets/2.7.x/7111-deprecation-warning-wordsmithing: Cleanup trailing whitespace (#7111) Clarify scoping deprecation warning
| * | | Cleanup trailing whitespaceJacob Helwig2011-04-141-2/+2
| | | |
| * | | (#7111) Clarify scoping deprecation warningJacob Helwig2011-04-141-1/+1
| | |/ | |/| | | | | | | | | | | | | | | | | | | This modifies the deprecation warning to explicitly point out that the specified behavior is deprecated, when it is slated to be removed, along with what the user can do to prepare for its removal. Paired-with: Randall Hansen <randall@puppetlabs.com>
* | | Merge branch 'tickets/next/7080-serializable_indirector_requests' into 2.7.xLuke Kanies2011-04-1412-31/+405
|\ \ \ | |/ / |/| |
| * | Adding json-specific matchersLuke Kanies2011-04-144-24/+136
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These make the JSON tests much easier to read and write. They're the first custom matchers that I can find, so they're breaking a bit of new ground, but the JSON tests were pretty hard to read and there was a lot of duplication, so it seemed worth it. Note that for some reason they're not working on Facts - it seems to get immediately turned into a full instance by the JSON parsing subsystem, and I've no idea why. Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | Making watchr resilient to syntax errors in testsLuke Kanies2011-04-141-1/+5
| | | | | | | | | | | | | | | Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | Adding json support to Puppet::NodeLuke Kanies2011-04-142-0/+86
| | | | | | | | | | | | | | | Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | Fixing a failing test resulting from a fixed bugLuke Kanies2011-04-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | We were not correctly pulling request attributes out in all cases, but now we do, which caused this test to start failing. We special case the 'ip' attribute in the test now. Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | (7080) Adding json support to Indirector RequestLuke Kanies2011-04-142-2/+148
| | | | | | | | | | | | | | | | | | | | | We'll be using this to do RPC over mcollective. Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | Fixing Facts pson methods more resilientLuke Kanies2011-04-142-9/+31
| |/ | | | | | | | | | | | | | | | | | | | | They were currently failing if any values were nil, which happened a lot. We also prefer not to include nil values, since it muddies the json unnecessarily. Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * Merge branch 'ticket/next/6928' into nextNick Lewis2011-04-141-1/+4
| |\
| | * (#6928) Add a notice to Parser#validate action when using defaultNick Lewis2011-04-141-1/+4
| | | | | | | | | | | | | | | | | | | | | It was unclear what the action was validating when no arguments were specified, so now it notifies the user. Paired-With: Jesse Wolfe
| * | Merge branch 'ticket/next/7103' into nextNick Lewis2011-04-132-15/+11
| |\ \
| | * | (#7103) Fix HEAD requests in the HTTP handlerNick Lewis2011-04-132-15/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HEAD request support was implemented in 2.6.x, and the internal API in the HTTP handler changed in 2.7.x. So when the branches were merged together, HEAD requests ended up using the wrong API without any visible merge conflicts or spec failures. This fixes them to use the correct API. Reviewed-By: Matt Robinson
generated by cgit (git 2.34.1) at 2025-09-26 13:55:01 +0000