summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Targeted fix for #3851Markus Roberts2010-02-171-1/+1
| | | | | | Older / user written providers may just return a bare string from their ___cmd functions instead of an array. This forces the command as used to be an array without breaking the cases where they (correctly) do return an array.
* [#3810] Add http reports processor and `reporturl` settingRein Henrichs2010-02-174-7/+85
| | | | | | | | | | | | Example puppet.conf: [puppetmasterd] reports = store, http reporturl = http://localhost:3000/reports * Group reporturl and reportdir in new reports section of Puppet::Settings * Add specs for both
* [#3804] Fixed one failing spec for RackRESTNick Lewis2010-02-171-2/+2
| | | | | | | | | | | A new version of Rack::MockRequest automatically uppercases the HTTP method, expecting that any method passed in should properly be uppercase. e.g. GET, PUT, POST This behavior is on line 81 of Rack::MockRequest: http://rack.rubyforge.org/doc/classes/Rack/MockRequest.src/M000230.html Reviewed by Matt Robinson
* Fixes #3514 - CR/LF line ending in puppet.conf cause silent failureJames Turnbull2010-02-171-2/+2
| | | | Patch thanks to Alan Barrett
* [#3409] fix test failures from ldap environment patchJesse Wolfe2010-02-172-21/+19
|
* [#3409] environment is not checked when nodes are in ldapJesse Wolfe2010-02-171-11/+51
| | | | This is the patch as submitted by vichharaks ros <vichharaks.ros@hp.com>
* Fixes #3395 - CR+LF line endings in manifests cause syntax errorJames Turnbull2010-02-171-1/+1
| | | | Thanks to Alan Barrett for the patch
* [#3388] Setting host_aliases from [] to [] no longer results in any changesNick Lewis2010-02-172-4/+6
| | | | | | | The message was "host_aliases changed from 'absent' to ''". When reading from the hosts file, a host without aliases was considered to have "absent" host_aliases. The host_aliases list is now considered to be present but empty if it is absent.
* Fixing #3139 - all properties can now be auditedLuke Kanies2010-02-178-48/+217
| | | | | | | | | | | | | | | This provides a full audit trail for any parameter on any resource Puppet can manage. Just use: file { "/my/file": audit => [content, owner] } And Puppet will generate an event any time either of those properties change. This commit also deprecates the 'check' parameter in favor of a new 'audit' parameter. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
* Working #3139 - Adding Settings.clear Spec#afterLuke Kanies2010-02-171-0/+1
| | | | | | This is another cleanup method we need to run. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
* Working #3139 - Removing Property#checkableLuke Kanies2010-02-171-16/+0
| | | | | | | | | | | It was called in the 'check' attribute but not set anywhere else. The whole point of being a property is that you can retrieve the current state of that property - not being checkable/auditable is nonsensical. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
* Working #3139 - Catalogs default to host_configLuke Kanies2010-02-175-25/+18
| | | | | | | | | | | The whole host_config concept is a bit outdated now that Configurer exists, I think, (since any catalog it uses should be a host_config). However, fixing that is outside of the scope of this series. In the meantime, this does a better job of making sure every catalog except the Settings catalogs are host_configs. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
* Working #3139 - ResourceHarness does cachingLuke Kanies2010-02-176-25/+38
| | | | | | | | | | | | | | | | | | This is again about moving transactional behaviour out of Puppet::Type and into the transactional code. I initially moved this code into Resource::Status, but it seemed to make more sense in the Harness - the Status object should be thin and have no code that doesn't make sense on both sides of the pipe, it seemed. The interface gets a bit uglier as a result, but this is all about good design != good OO (because we're increasing the argument count of methods by moving them outside of the target class). Signed-off-by: Luke Kanies <luke@puppetlabs.com>
* Working #3139 - removing obsolete checking in StorageLuke Kanies2010-02-173-49/+7
| | | | | | | | | We were type-checking the use of Storage for no good reason. I've removed all of that, so we can use either resources or their Refs for caching. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
* Working #3139 - scheduling moved to resource harnessLuke Kanies2010-02-177-118/+161
| | | | | | | | | | We previously had the schedule checking code in Puppet::Type, but it's more of a transactional function, and in order to do proper auditing in the transactional area, we need the cache checking done there. Scheduling is one of the few functions that actually uses cached data currently. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
* Improving fix for #1175; tightening thread safetyMarkus Roberts2010-02-173-10/+14
| | | | | | | | The previous code maintained thread safety up to work-duplication (so that a collision would, at worse, result in effective cache flushing and cause some additional work to be done). The preceding patch addressed the single thread issue of environment specific functions; this patch brings the thread safety up to the previous standard.
* Part 2 of fix for #1175 (functions in environments)Markus Roberts2010-02-1710-52/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Jesse and I are shooting for the minimal viable fix here, with the idea that a great deal of refactoring is needed but isn't appropriate at this time. The changes in this commit are: * Index the function-holding modules by environment * We need to know the "current environment" when we're defining a function so we can attach it to the proper module, and this information isn't dynamically available when user-defined functions are being created (we're being called by user written code that doesn't "know" about environments) so we cheat and stash the value in Puppet::Node::Environment * since we must do this anyway, it turns out to be cleaner & safer to do the same when we are evaluating a functon. This is the main change from the prior version of this patch. * Add a special *root* environment for the built in functions, and extend all scopes with it. * Index the function characteristics (name, type, docstring, etc.) by environment * Make the autoloader environment aware, so that it uses the modulepath for the specified environment rather than the default * Turn off caching of the modulepath since it potentially changes for each node * Tweak tests that weren't environment aware
* [#1621] Composite keys for resourcesJesse Wolfe2010-06-2120-235/+160
| | | | | | | | | | | | | | | | This patch implements the fundamental pieces of the move to composite keys: * Instead of having a single namevar, we have a non-empty collection of them, and two resources are the same if and only if all of them match. Note that the present situation is a special case of this, where the collection always has exactly one member. * As currently, namevar is determined by the type. * Instead just of inferring the single namevar from the title we let types decompose the title into values for several (perhaps all) of the namevar components; note that the present situation is again a special case of this. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
* Use the 'root' feature rather than directly checking the uidMarkus Roberts2010-02-1711-15/+15
| | | | Jesse fixed all these but David and others moved them and introduced some more so...
* fix tests to reflect methods moved from type/file/owner to provider/file/posixJesse Wolfe2010-02-171-14/+21
|
* variable name error in refactorJesse Wolfe2010-02-171-1/+1
|
* Remove over-eager error branch in a complicated IfJesse Wolfe2010-02-171-4/+0
|
* Confine out a lib that puppet was failing to load on non-win32Jesse Wolfe2010-02-171-1/+1
|
* Confine out tests that fail on unixJesse Wolfe2010-02-171-0/+2
|
* Behavior change for //UNC_Paths broke an old testJesse Wolfe2010-02-171-1/+1
|
* Resolving conflicts with jes5199:ticket/master/2935-settings-modeMarkus Roberts2010-02-171-2/+8
| | | | | | Jesse moved the code David was patching; the conflict resolution omits David's change (since the code isn't there to be changed) and this moves the change to the new location.
* Fix Exec typeDavid Schmitt2010-02-171-2/+2
|
* Move syslog into a featureDavid Schmitt2010-02-172-3/+5
|
* Adapt Util::Storage specs and avoid trying to lock on directoriesDavid Schmitt2010-02-172-5/+10
|
* Relax path qualification check on FileServing::FilesetDavid Schmitt2010-02-171-1/+1
|
* Implement quoting on the exec commands and repair specsDavid Schmitt2010-02-172-91/+124
|
* Avoid trying to symlink() on windowsDavid Schmitt2010-02-173-120/+195
|
* Implement "forking" for WindowsDavid Schmitt2010-02-171-24/+46
|
* Avoid non-win32 signals on win32 runtimeDavid Schmitt2010-02-171-1/+4
|
* Avoid trying to set uid/gid on windowsDavid Schmitt2010-02-171-1/+2
|
* Start extracting the owner managment for files into providersDavid Schmitt2010-02-173-98/+194
|
* Expand file type to be able to handle Win32 and UNC pathsDavid Schmitt2010-02-172-20/+136
| | | | | | | Win32 paths start with a drive letter, a colon and a slash; UNC paths start with two slashes, the name of the server and another slash. Signed-off-by: David Schmitt <david@dasz.at>
* Updated version to 2.6.0James Turnbull2010-06-101-1/+1
|
* Fixed RSpec deprecation notice in lexer testsJames Turnbull2010-06-101-1/+1
|
* Make specs work on win32David Schmitt2010-02-1713-125/+171
| | | | | | | | | | | | | | | | | | | | lib/: * Fix Puppet::Parser::Files * Fix Puppet::Util::Settings spec/: * unit/application/kick.rb: only run on posix * unit/application.rb * unit/parser/compiler.rb * unit/parser/files.rb * unit/resource.rb * unit/resource/catalog.rb * unit/resource/type_collection.rb * unit/transaction.rb * unit/type/tidy.rb * unit/util/settings.rb * unit/util/settings/file_setting.rb * unit/application.rb
* Delete tempfiles on win32David Schmitt2010-02-171-1/+8
|
* Fix path handlingDavid Schmitt2010-02-173-5/+6
| | | | | *) Use File.expand_path as indicator for being an absolute path *) Use basename instead of parsing the path manually
* Print stacktraces if requestedDavid Schmitt2010-02-171-0/+2
|
* Adapt defaults to Win32 environmentDavid Schmitt2010-02-171-1/+1
| | | | This needs the workaround from http://rubyforge.org/tracker/index.php?func=detail&aid=28206&group_id=85&atid=411
* More win32? feature defDavid Schmitt2010-02-171-1/+1
|
* Define posix and win32 featuresDavid Schmitt2010-02-171-0/+11
|
* Improve error messageDavid Schmitt2010-02-171-1/+1
|
* Fix ProviderDpkg specs to avoid any real executionsDavid Schmitt2010-02-171-0/+4
|
* Avoid setting the timeout before we know which timeout we should set.David Schmitt2010-02-172-4/+24
| | | | Signed-off-by: David Schmitt <david@dasz.at>
* Bug: tidy specs need FileBucket::DipperDavid Schmitt2010-02-171-0/+1
|