summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | (#7059) Set the CA location using option hooks.Daniel Pittman2011-04-152-19/+18
| | | | | | | | | | | | | | | | | | | | | | | | Now that we support option hooks, we can use those to set the CA location rather than open-coding each chunk of support. As a side benefit we also set the CA location for inherited actions, as we should. Reviewed-By: Max Martin <max@puppetlabs.com>
| * | (#6978) Add before and after decorators to actions from options.Daniel Pittman2011-04-1512-44/+357
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Options can now add before_action and after_action blocks; these are invoked before or after any action is invoked on the face. This allows these options to declare common behaviour and have it automatically applied to the actions invoked. Option hooks have no defined order of invocation: they will run in a completely random order. Where there are dependencies they should be on the value of the options hash passed to the invocation, not on side-effects of the other invocations. You are not able to influence the arguments, options, or calling of the action body in a before or after decorator. This is by design. The invocation passes to the hook: 1. The action object representing this action. 2. The arguments to the action, as an array. 3. The options for the action, as a hash. Paired-With: Max Martin <max@puppetlabs.com>
| * | maint: delete an empty describe block containing no tests.Daniel Pittman2011-04-151-4/+0
| | | | | | | | | | | | Reviewed-By: Max Martin <max@puppetlabs.com>
* | | Merge branch 'tickets/2.7.x/7115' into 2.7.xPieter van de Bruggen2011-04-158-16/+98
|\ \ \
| * | | (#7115) Enable default actions.Pieter van de Bruggen2011-04-158-16/+98
| | |/ | |/| | | | | | | | | | | | | | | | This also enables the 'help' action on the 'help' face to serve as a default action. Reviewed-By: Daniel Pittman Reviewed-By: Nick Lewis
* | | Merge branch 'tickets/2.7.x/7111-deprecation-warning-wordsmithing' into 2.7.xJacob Helwig2011-04-151-3/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | * tickets/2.7.x/7111-deprecation-warning-wordsmithing: Cleanup trailing whitespace (#7111) Clarify scoping deprecation warning
| * | | Cleanup trailing whitespaceJacob Helwig2011-04-141-2/+2
| | | |
| * | | (#7111) Clarify scoping deprecation warningJacob Helwig2011-04-141-1/+1
| | |/ | |/| | | | | | | | | | | | | | | | | | | This modifies the deprecation warning to explicitly point out that the specified behavior is deprecated, when it is slated to be removed, along with what the user can do to prepare for its removal. Paired-with: Randall Hansen <randall@puppetlabs.com>
* | | Merge branch 'tickets/next/7080-serializable_indirector_requests' into 2.7.xLuke Kanies2011-04-1412-31/+405
|\ \ \ | |/ / |/| |
| * | Adding json-specific matchersLuke Kanies2011-04-144-24/+136
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These make the JSON tests much easier to read and write. They're the first custom matchers that I can find, so they're breaking a bit of new ground, but the JSON tests were pretty hard to read and there was a lot of duplication, so it seemed worth it. Note that for some reason they're not working on Facts - it seems to get immediately turned into a full instance by the JSON parsing subsystem, and I've no idea why. Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | Making watchr resilient to syntax errors in testsLuke Kanies2011-04-141-1/+5
| | | | | | | | | | | | | | | Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | Adding json support to Puppet::NodeLuke Kanies2011-04-142-0/+86
| | | | | | | | | | | | | | | Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | Fixing a failing test resulting from a fixed bugLuke Kanies2011-04-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | We were not correctly pulling request attributes out in all cases, but now we do, which caused this test to start failing. We special case the 'ip' attribute in the test now. Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | (7080) Adding json support to Indirector RequestLuke Kanies2011-04-142-2/+148
| | | | | | | | | | | | | | | | | | | | | We'll be using this to do RPC over mcollective. Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * | Fixing Facts pson methods more resilientLuke Kanies2011-04-142-9/+31
| |/ | | | | | | | | | | | | | | | | | | | | They were currently failing if any values were nil, which happened a lot. We also prefer not to include nil values, since it muddies the json unnecessarily. Reviewed-by: Daniel Pittman <daniel@puppetlabs.com> Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| * Merge branch 'ticket/next/6928' into nextNick Lewis2011-04-141-1/+4
| |\
| | * (#6928) Add a notice to Parser#validate action when using defaultNick Lewis2011-04-141-1/+4
| | | | | | | | | | | | | | | | | | | | | It was unclear what the action was validating when no arguments were specified, so now it notifies the user. Paired-With: Jesse Wolfe
| * | Merge branch 'ticket/next/7103' into nextNick Lewis2011-04-132-15/+11
| |\ \
| | * | (#7103) Fix HEAD requests in the HTTP handlerNick Lewis2011-04-132-15/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HEAD request support was implemented in 2.6.x, and the internal API in the HTTP handler changed in 2.7.x. So when the branches were merged together, HEAD requests ended up using the wrong API without any visible merge conflicts or spec failures. This fixes them to use the correct API. Reviewed-By: Matt Robinson
* | | | Merge branch 'ticket/2.7.x/6408' into 2.7.xnfagerlund2011-04-141-47/+51
|\ \ \ \
| * | | | (#6408) Update puppet cert help for new subcommand action syntax.nfagerlund2011-04-141-47/+51
|/ / / / | | | | | | | | | | | | | | | | Puppet cert now allows bareword actions, which brings it more in-line with the Faces subcommands. Updating the help text accordingly.
* | | | Merge branch 'feature/master/4258-pkgutil' into 2.7.xMatt Robinson2011-04-142-0/+357
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * feature/master/4258-pkgutil: (29 commits) (#4258) Fix pkgutil spec test to have the correct provider (#4258) Remove superfluous command check that called pkgutil (#4258) Fix fd leak opening pkgutil config files (#4258) Permit variations of -nv in both pkgutil.conf files (#4258) Stop file and config checks from breaking spec (#4258) Check wgetopts in pkgutil.conf (#4258) Fix hash duplication affecting canonical provider instance (#4258) Use pkgutil -a to reliably determine package common names/aliases (#4258) Update pkgutil spec for recent impl changes (#4258) pkgutil: bug fix: if shortname is not equal to package name (#4258) pkgutil provider: better handling of short package names (#4258) pkgutil provider: misc enhancements Add spec tests for pkgutil package provider * Fix exception on parse failure of pkgutil output * Fix exception when querying latest version for unknown package Fixing indentation Removing blastwave references and unused PAGER Changing indentation to 2-spaces as per 2.6+ style Single package queries made more robust when dealing with pkgutil noise Fixing wget verbose regex These regular expressions will not match anything. pkgutil doesn't output anything that can be matched. ...
| * | | | (#4258) Fix pkgutil spec test to have the correct providerMatt Robinson2011-04-141-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The resource being used for testing didn't explicitly set the provider, so it ended up using whatever the default provider was on the system on which it was run. This was problematic when running the specs on a Mac since the default provider is pkgdmg and that provider doesn't seem to be upgradeable. So when you tried: @resource[:ensure] = :latest You got the error: 1) Puppet::Type::Package::ProviderPkgutil when installing should use a command without versioned package Failure/Error: @resource[:ensure] = :latest Puppet::Error: Parameter ensure failed: Provider must have features 'upgradeable' to set 'ensure' to 'latest' # ./lib/puppet/parameter.rb:171:in `fail' # ./lib/puppet/parameter.rb:257:in `validate' # ./lib/puppet/property.rb:300:in `should=' # ./lib/puppet/property.rb:300:in `each' # ./lib/puppet/property.rb:300:in `should=' # ./lib/puppet/property.rb:337:in `value=' # ./lib/puppet/type.rb:416:in `[]=' # ./spec/unit/provider/package/pkgutil_spec.rb:35 Reviewed-by: Daniel Pittman <daniel@puppetlabs.com>
| * | | | (#4258) Remove superfluous command check that called pkgutilDominic Cleal2011-04-131-8/+4
| | | | |
| * | | | (#4258) Fix fd leak opening pkgutil config filesDominic Cleal2011-04-131-2/+3
| | | | |
| * | | | (#4258) Permit variations of -nv in both pkgutil.conf filesDominic Cleal2011-04-131-2/+4
| | | | |
| * | | | (#4258) Stop file and config checks from breaking specDominic Cleal2011-04-132-9/+14
| | | | | | | | | | | | | | | | | | | | | | | | | Moved all file and config checks into healthcheck method which is then stubbed in the spec.
| * | | | (#4258) Check wgetopts in pkgutil.confJuerg Walz2011-04-131-0/+7
| | | | |
| * | | | (#4258) Fix hash duplication affecting canonical provider instanceDominic Cleal2011-03-221-1/+1
| | | | |
| * | | | (#4258) Use pkgutil -a to reliably determine package common names/aliasesDominic Cleal2011-03-192-29/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Populate instances with both the real package name ("CSWsvn") and the alias name ("subversion") from separate "pkgutil -a" call. Fixed cases where pkgutil noise was parsed as aliased package names and also breaking "not in catalog" detection. Updated pkgutil_spec test to show various edge cases.
| * | | | (#4258) Update pkgutil spec for recent impl changesDominic Cleal2011-03-181-13/+9
| | | | | | | | | | | | | | | | | | | | | | | | | Fix test output of pkgutil for commands using --single Fix expected upgrade command to match impl
| * | | | (#4258) pkgutil: bug fix: if shortname is not equal to package nameJuerg Walz2011-03-101-2/+2
| | | | |
| * | | | (#4258) pkgutil provider: better handling of short package namesJuerg Walz2011-03-081-1/+5
| | | | |
| * | | | (#4258) pkgutil provider: misc enhancementsJuerg Walz2011-02-221-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Several enhancements and bug-fixes for the pkgutil package provider: - handle "Not in catalog" - fix "SAME" version detection - allow short package name (w/o CSW) to match (-> no need to specify a different package name for different operating systems, ex. "ruby") - use the "-u" command line switch for updates
| * | | | Add spec tests for pkgutil package providerDominic Cleal2011-02-201-0/+132
| | | | |
| * | | | * Fix exception on parse failure of pkgutil outputDominic Cleal2011-02-201-13/+6
| | | | | | | | | | | | | | | | | | | | * Fix exception when querying latest version for unknown package
| * | | | Merge branch 'master' into tickets/master/4258-devDominic Cleal2011-02-19602-3514/+4029
| |\ \ \ \
| * | | | | Fixing indentationDominic Cleal2010-11-291-3/+3
| | | | | |
| * | | | | Removing blastwave references and unused PAGERDominic Cleal2010-11-291-10/+8
| | | | | |
| * | | | | Changing indentation to 2-spaces as per 2.6+ styleDominic Cleal2010-11-291-106/+106
| | | | | |
| * | | | | Single package queries made more robust when dealing with pkgutil noiseDominic Cleal2010-11-291-2/+8
| | | | | |
| * | | | | Fixing wget verbose regexDominic Cleal2010-11-271-1/+1
| | | | | |
| * | | | | Merge remote branch 'remotes/rgevaert/master' into tickets/masters/4258Dominic Cleal2010-11-271-3/+1
| |\ \ \ \ \
| | * | | | | These regular expressions will not match anything. pkgutil doesn't output ↵rgevaert2010-11-171-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | anything that can be matched.
| | * | | | | Add comments that explain what we are ignoring in the package and remove ↵rgevaert2010-11-161-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | legacy output
| * | | | | | Merge branch 'master' of github.com:domcleal/puppet into master-oldDominic Cleal2010-11-27394-9217/+11982
| |\ \ \ \ \ \ | | |/ / / / / | |/| | | | |
| * | | | | | Ignoring lines from use_gpg and catalog fetchingDominic Cleal2010-11-151-0/+5
| | | | | | |
| * | | | | | Adding patch from Rudy Gevaert to fix not installed detectionDominic Cleal2010-11-151-3/+3
| | | | | | |
| * | | | | | Resolved a conflict in the pkgutil provider.Maciej Blizinski2010-07-221-15/+21
| |\ \ \ \ \ \
| | * | | | | | pkgutil provider: Using the --single option which speeds up execution.Maciej Blizinski2010-07-221-0/+3
| | | | | | | |