summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* (#5073) Download plugins even if you're filtering on tagsMatt Robinson2011-03-153-11/+31
| | | | | | | | | | | | | | | | | | | | | When we eval a resource in transaction.rb it was being skipped when filtering on tags and downloading the plugins. There's a lot of complicated conditions for whether to skip a resource, but this is a condensed version of the path that was causing plugins not to be downloaded. skip? missing_tags? !ignore_tags? !host_config The Puppet::Configurer::Downloader creates separate catalogs and applies them to get custom facts and plugins, so should be setting host_config to false. Puppet::Util::Settings also sets host_config to false when you call use on settings, while normal catalog application defaults to true. Thanks to Stefan Schulte <stefan.schulte@taunusstein.net> for suggesting the implementation fix.
* Merge branch 'ticket/2.6.next/5428-handle-0.25.x-storedconfig-data' into ↵Jacob Helwig2011-03-152-18/+43
|\ | | | | | | | | | | | | | | | | | | | | 2.6.next * ticket/2.6.next/5428-handle-0.25.x-storedconfig-data: Remove extra trailing whitespace from lib/puppet/resource.rb (#5428) More fully "stub" Puppet::Resource::Reference for use with storedconfigs Conflicts: lib/puppet/resource.rb
| * Remove extra trailing whitespace from lib/puppet/resource.rbJacob Helwig2011-03-151-1/+1
| | | | | | | | Paired-with: Daniel Pittman <daniel@puppetlabs.com>
| * (#5428) More fully "stub" Puppet::Resource::Reference for use with storedconfigsJacob Helwig2011-03-152-18/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Puppet::Resource::Reference class wasn't stubbing enough of the 0.25.x behavior to satisfy the needs of storedconfigs. Since P::R::Reference, and Puppet::Resource were merged as part of 2.6.x, we can pretend that P::Resource is P::R::Reference for the purposes of loading data from storedconfigs. This should still satisfy the over-the-wire serialization needs of 0.25.x. This also changes internal references to @parameters in Puppet::Resource(::Reference) to go through a parameters method. This allows us to "initialize" this instance variable lazily, since loading via YAML bypasses the normal initialize method. Paired-with: Daniel Pittman <daniel@puppetlabs.com> Reviewed-by: Markus Roberts <markus@puppetlabs.com>
* | Merge branch 'ticket/2.6.next/6689' into 2.6.nextNick Lewis2011-03-151-1/+0
|\ \
| * | (#6689) Remove extraneous include of Puppet::Util in InventoryActiveRecordNick Lewis2011-03-151-1/+0
| | | | | | | | | | | | | | | | | | | | | This was added while developing in order to benchmark, but wasn't removed before committing. Reviewed-By: Jacob Helwig
* | | Merge branch 'ticket/2.6.x/5662' of https://github.com/stschulte/puppet into ↵Jesse Wolfe2011-03-142-1/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 2.6.next Manually Resolved Conflicts: spec/unit/provider/mount/parsed_spec.rb
| * | | (#5662) Fixed tests that didnt stub key_attributesStefan Schulte2010-12-232-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The parsedfile provider calls the method key_attributes of the resource class to decide what resourceparameters must be put in the property_hash. Tests that uses fake resources and only stub resource[:name] must also stub resource.class.key_attributes
| * | | (#5662) Parsedfile doesnt work with mult keyattrStefan Schulte2010-12-231-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When one wants to use the parsedfile provider for a type with more than one key_attribute (e.g. a type for entries in /etc/services with name and protocol as key_attributes) the provider will not store all key_attributes in property_hash and not all keyattributes will be visible in the to_line function. The create method of parsedfile will only put validproperties into the propertyhash. As result :name and all the other key_attributes will not be set. In the flush method however the :name parameter is put in the property_hash but the method does not handle other keyattributes. This patch modifies flush to put all key_attributes into the property hash (Note: @resource.name is basically just an alias for @resource[:name])
* | | | Merge branch 'ticket/2.6.x/5661' of https://github.com/stschulte/puppet into ↵Jesse Wolfe2011-03-141-4/+4
|\ \ \ \ | | | | | | | | | | | | | | | 2.6.next
| * | | | (#5661) Creating types dont work with >1 namevarStefan Schulte2010-12-231-4/+4
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The methods [] and []= of type.rb are handling :name in a special way. When someone wants to access resource[:name] puppet tries to replace :name with the name_var. If the type has more than one key_attribute name_var is always returning false so we'll get the error Resource type <resourcetype> does not support parameter false This patch doesnt try to substitute :name if we dont have a single namevar, aka. we have more than one key_attribute
* | | | Merge branch 'ticket/2.6.next/6707' into 2.6.nextnfagerlund2011-03-141-1/+1
|\ \ \ \
| * | | | (#6707) Fix typo in rest_authconfig.rbnfagerlund2011-03-141-1/+1
|/ / / / | | | | | | | | | | | | "Where" -> "were." Capitalize "ACL."
* | | | Merge branch 'ticket/2.6.next/6689' into 2.6.nextNick Lewis2011-03-115-25/+16
|\ \ \ \ | | |/ / | |/| |
| * | | (#6689) Make inventory_active_record terminus search quicklyNick Lewis2011-03-115-25/+16
|/ / / | | | | | | | | | | | | | | | | | | | | | This terminus behaves the same on all supported DB platforms, by performing a limited portion of its query in SQL, and the rest of the comparison in Ruby. Its results are consistent with the YAML terminus. Paired-With: Jesse Wolfe
* | | Merge branch 'ticket/2.6.next/5392' into 2.6.nextMatt Robinson2011-03-092-16/+21
|\ \ \ | | | | | | | | | | | | | | | | * ticket/2.6.next/5392: (#5392) Give a better error when realizing a non-existant resource
| * | | (#5392) Give a better error when realizing a non-existant resourceMatt Robinson2011-03-092-16/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | You can reproduce the error with a simple manifest Bogus_type <| title == 'foo' |> We used to fail because find_resource_type returned nil and we never checked if it was nil before calling methods on it. Reviewed-by: Max Martin <max@puppetlabs.com>
* | | | Merge branch 'tickets/2.6.x/2645' into 2.6.nextJesse Wolfe2011-03-095-4/+65
|\ \ \ \
| * | | | (#2645) Adding a less-stubby test to verify the "system" attribute's behaviorJesse Wolfe2011-03-092-5/+13
| | | | | | | | | | | | | | | | | | | | Paired-with: Jacob Helwig <jacob@puppetlabs.com>
| * | | | Fixed #2645 - Added support for creating system usersJames Turnbull2011-03-094-4/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Red Hat, Ubuntu, Debian and deriatives the -r flag allows creation of "system" users with a UID below that defined in /etc/login.defs. This commit adds support for a system parameter and a system_users feature which can be used like so: user { "foo": system => true, ensure => present, } This will create a user with a lower UID. The system parameter defaults to false.
* | | | | Merge branch 'maint/2.6.next/6338' into 2.6.nextNick Lewis2011-03-096-64/+54
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | maint: Remove serialization of InventoryFact valuesNick Lewis2011-03-093-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This is not necessary because fact values are always strings, and it wasn't doing the unnecessary job it was expected to do anyway.
| * | | | maint: Rename InventoryHost to InventoryNodeNick Lewis2011-03-096-54/+54
| | | | | | | | | | | | | | | | | | | | This had been conflating hosts and nodes, when nodes is the most accurate.
* | | | | Merge branch 'ticket/2.6.next/maint-cleanup_spec_output' into 2.6.nextMatt Robinson2011-03-085-5/+8
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | * ticket/2.6.next/maint-cleanup_spec_output: maint: Remove spec run noise
| * | | | maint: Remove spec run noiseMatt Robinson2011-03-085-5/+8
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were some warnings and stack traces in the spec output that aren't necessary. The only interesting fix is of the message: lib/puppet/module.rb:79 warning: multiple values for a block parameter (0 for 1) from lib/puppet/util/logging.rb:30 If you call any form of logging on a module you end calling the file method on the module just because logging always checks for that method and calls it if it's defined, but in this case it's not defined in the way that logging expected so passes the wrong paramters. The easy solution is just to call logging on Puppet, which makes sense in this case anyway, and I don't think it's worth a separate ticket to deal with that logging warning. Reviewed-by: Nick Lewis <nick@puppetlabs.com>
* | | | Merge branch 'ticket/2.6.next/6338' into 2.6.nextNick Lewis2011-03-086-0/+363
|\ \ \ \
| * | | | (#6338) Support searching on metadata in InventoryActiveRecord terminusNick Lewis2011-03-082-41/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Timestamps are currently the only supported metadata for searching. Paired-With: Max Martin Reviewed-By: Jacob Helwig
| * | | | (#6338) Implement search for InventoryActiveRecord facts terminusNick Lewis2011-03-083-0/+112
| | | | | | | | | | | | | | | | | | | | | | | | | Paired-With: Max Martin Reviewed-By: Jacob Helwig
| * | | | (#6338) Add an InventoryActiveRecord terminus for FactsNick Lewis2011-03-086-0/+202
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So far this terminus only supports find and save. Search is forthcoming. It uses two new tables (inventory_host and inventory_facts) so that it won't interact with storedconfigs. Paired-With: Jacob Helwig
* | | | | Merge branch 'maint/2.6.next/test_mount' into 2.6.nextMax Martin2011-03-081-35/+64
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | * maint/2.6.next/test_mount: Added integration tests for the mount provider
| * | | | | Added integration tests for the mount providerPaul Berry2011-03-081-35/+64
| | | | | | | | | | | | | | | | | | | | | | | | Paired-with: Max Martin <max@puppetlabs.com>
* | | | | | Merge branch 'tickets/2.6.next/5794-create-report-parentdir' of ↵Jacob Helwig2011-03-082-2/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://github.com/vvitayaudom/puppet into 2.6.next * 'tickets/2.6.next/5794-create-report-parentdir' of git://github.com/vvitayaudom/puppet: (#5794) create reports directory when creating host specific directory
| * | | | | | (#5794) create reports directory when creating host specific directoryValdis Victor Vitayaudom2011-03-052-2/+5
| | | | | | |
* | | | | | | Merge branch 'ticket/2.6.x/6513-propigate-environment-in-settings-values' ↵Jacob Helwig2011-03-082-3/+12
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 2.6.next * ticket/2.6.x/6513-propigate-environment-in-settings-values: (#6513) Propagate the environment when doing variable lookup in settings (#6513) Adjust P::U::Settings test name to reflect what it tests
| * | | | | | | (#6513) Propagate the environment when doing variable lookup in settingsJacob Helwig2011-03-082-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example with the following: test.conf: [master] rrddir = /var/lib/puppet/rrd templatedir = /var/lib/puppet/templates [env_a] templatedir = $rrddir/templates rrddir = /tmp/env_a/ The command: RUBYLIB=lib bin/puppet master --config ./test.conf --environment env_a --configprint templatedir originally produced '/var/lib/puppet/rrd/templates' instead of the expected '/tmp/env_a/templates' Reviewed-by: Jesse Wolfe <jesse@puppetlabs.com>
| * | | | | | | (#6513) Adjust P::U::Settings test name to reflect what it testsJacob Helwig2011-03-081-1/+1
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'should interpolate found values using the current environment' wasn't actually testing what it was describing, since the environment variable is special cased. Reviewed-by: Jesse Wolfe <jesse@puppetlabs.com>
* | | | | | | Merge branch 'ticket/2.6.next/5724-deprecate_DESTDIR_for_install.rb' of ↵Jacob Helwig2011-03-081-25/+20
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://github.com/elutfall/puppet into 2.6.next * 'ticket/2.6.next/5724-deprecate_DESTDIR_for_install.rb' of git://github.com/elutfall/puppet: (5724) Prep for deprecation of DESTDIR Refactoring duplicate code and logic in prep for DESTDIR deprecation.
| * | | | | | (5724) Prep for deprecation of DESTDIRElias Lutfallah2011-03-051-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In preparation of deprecating the DESTDIR env variable, I've added a warning when the DESTDIR variable is being used.
| * | | | | | Refactoring duplicate code and logic in prep for DESTDIR deprecation.Elias Lutfallah2011-03-051-25/+19
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | DESTDIR is slated to be deprecated. The block of code that checks for DESTDIR contained duplicate code as the block that checks for --destdir. The dupe code has been moved out of the destdir checks. I have also flipped the order of checking. Previously, if the DESTDIR env was set it would be used regardless of whether or not the --destdir flag was set. No env, no flag: ./install.rb destdir = nil Env only: DESTDIR="foo" ./install.rb destdir = foo Flag only: ./install.rb --destdir="bar" destdir = bar Both (uses flag): DESTDIR="foo" ./install.rb --destdir="bar" destdir = bar
* | | | | | Merge branch 'ticket/2.6.next/6632' into 2.6.nextPaul Berry2011-03-084-32/+14
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/2.6.next/6632: (#6632) Adding a new mount no longer causes error with umount
| * | | | | | (#6632) Adding a new mount no longer causes error with umountPaul Berry2011-03-084-32/+14
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were two problems: * In lib/puppet/type/mount.rb, we were calling provider.mounted? to determine whether we needed to execute "mount" after updating the in-memory fstab record. This wasn't working properly because provider.mounted? makes its decision based on the data stored in the in-memory fstab record. Since the fstab record had just been updated, provider.mounted? was incorrectly returning true even though the device wasn't actually mounted. Fixed this by checking provider.mounted? before updating the in-memory fstab record. * Calling mount from this point in lib/puppet/type/mount.rb is actually too early, because even though the in-memory fstab record has been created, its contents have not been written to `/etc/fstab` yet. Fixed this by storing a :needs_mount entry in the property_hash and checking it at the end of the flush() method. Reviewed-by: Jacob Helwig <jacob@puppetlabs.com>
* | | | | | Adjust Darwin mount provider tests to pass on LinuxPaul Berry2011-03-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mount, and umount are located under /bin, instead of /sbin on Linux, so we adjust the ExecutionStub to accept either location. Paired-with: Jacob Helwig <jacob@puppetlabs.com>
* | | | | | Merge branch 'maint/2.6.next/test_mount' into 2.6.nextPaul Berry2011-03-071-0/+93
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * maint/2.6.next/test_mount: Maint: Begin adding integration tests for the mount provider
| * | | | | | Maint: Begin adding integration tests for the mount providerPaul Berry2011-03-071-0/+93
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These tests form a starting point for integration testing the mount provider, using the new Puppet::Util::ExecutionStub mechanism to simulate the state of the machine in response to the execution of "mount" and "umount" commands. The tests currently work around some known bugs (6628, 6632, and 6633). Reviewed-by: Max Martin <max@puppetlabs.com>
* | | | | | Merge branch 'maint/2.6.next/make_execute_stubbable' into 2.6.nextPaul Berry2011-03-074-0/+67
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | * maint/2.6.next/make_execute_stubbable: Maint: Added the ability to replace the behavior of Puppet::Util.execute with an arbitrary code block for ease in spec testing.
| * | | | | Maint: Added the ability to replace the behavior ofPaul Berry2011-03-074-0/+67
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Puppet::Util.execute with an arbitrary code block for ease in spec testing. Reviewed-by: Max Martin <max@puppetlabs.com>
* | | | | Merge branch 'ticket/2.6.next/6606' into 2.6.nextnfagerlund2011-03-0411-11/+41
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | (#6606) Inline docs: Document all autorequire relationshipsnfagerlund2011-03-0411-11/+41
|/ / / / | | | | | | | | | | | | This patch appends **Autorequires:** notes to the @doc string of every type whose instances can autorequire other resources. This will put autorequire info right on the types reference where it can do the most good.
* | | | Merge branch 'ticket/2.6.next/6602' into 2.6.nextNick Lewis2011-03-041-1/+1
|\ \ \ \
| * | | | (#5148) Fix failing spec due to timezoneNick Lewis2011-03-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Time.parse(...) will yield a string in the local timezone. So when this spec was run in a non -0700 timezone, it was failing, because it was comparing a string in local time to a string in -0700. This fixes it to compare to the local string representation of the time.
generated by cgit (git 2.34.1) at 2025-09-26 07:29:48 +0000