summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* (#5242) Fix schedule specs that fail near daylight savingsMatt Robinson2010-11-101-43/+15
| | | | | | | | | I fixed a few of these in a previous patch, but Hudson found more. I replaced the pattern of using Time.now and then doing date math to calculate intervals with the pattern of hard setting the intervals using utc times for the test. Reviewed-by: Paul Berry <paul@puppetlabs.com>
* Kludge for #5206 -- port of fix for #3536 to yamlMarkus Roberts2010-11-102-1/+16
| | | | | | | | | | | | | | | | | | The internal format of parameters was changed between 0.25.x and 2.6.x, making them incompatible when serialized. This was fixed for PSON under ticket #3656 (by modifying the data as it was serialized) in: commit f66095d35bc5f9645eb19bbb8cefa342c0181d2d and commit 2edf7fe968ac3d8af9865f65100940747c1fa894 but nothing was done about the other serialization formats. This commit adds a callback to zaml property serialization and uses it to route data through the fixup method added in the commits above, thus fixing the problem "the same way" as it was fixed for PSON under #3656. It does nothing about marshal, mostly because I have not totaly gone over to the dark side (yet).
* (#5062) Add envpuppet helper script to ext/Jeff McCune2010-11-101-0/+80
| | | | | | | | This script helps people quickly test different branches of various puppet related projects like facter, puppet-scaffold, puppet-dashboard, etc... It allows the user to simply clone puppet and start running different puppet version without installing puppet or any other setup costs.
* [#5225] Fix spec failure that depended on time changeMatt Robinson2010-11-081-6/+2
| | | | | | | | | | | | Turns out that: zero = Time.now # Reset the current time to X:00:00 current = zero - (zero.hour * 3600) - (zero.min * 60) - zero.sec current is actually 1am on a day where the time falls back (Nov 7th), not midnight as the test expected. Reviewed-by: Paul Berry <paul@puppetlabs.com>
* (#5233) Randomize tmp dir pathsMatt Robinson2010-11-085-10/+8
| | | | | | | Standardize how we create tmpdirs by using the puppet function instead of Dir.tmpdir. Paired-with: Paul Berry <paul@puppetlabs.com>
* Updated CHANGELOG for 2.6.3rc2James Turnbull2010-10-291-0/+9
|
* Fixed #5112 - Launchd Service broke in 2.6.2 with OS X 10.4 Clients.donavan2010-10-291-1/+1
| | | | | | | | | | | | | | Just to follow up on 5112 I have a dirty patch that appears to work. Nominally tested it on 10.4, 10.5, & 10.6. 10.4 now applies catalogs instead of failing. All versions successfully manage a test services state as well. Does anyone have a better suggestion than '-o /dev/stdout'? Seems a mite hacky to me. Also I think that the 10.4 machines are going to a have a \ ( slash ) file in whatever puppets working dir was. plutil seems to have been interpreting as literal file name.
* Fixed #5137 - Removed no longer required TOC referencesJames Turnbull2010-10-291-2/+0
|
* Kludge for #5048 -- serialization compatibility with 0.25.xMarkus Roberts2010-10-271-0/+10
| | | | | | | | | | | | | | In 0.25.x the type & title of a resource were wrapped in a Puppet::Resource::Reference object whereas in 2.6.x they are attributes of the resource itself without the additional indirection (see 7089446697ad550c22012bc2b5572030727d67e1). When pson serialization is used this isn’t a problem but with formats in which we just blindly emit the structure either because we have no choice (marshal) or because we just use the default (yaml) it is a compatibility-breaking change. This patch resoloves the problem by adding a dummy reference object to cause the "correct" serialization; it is intended as a stop-gap for 2.6.x and should NOT be merged into next.
* (#4534/#4778) -- Normalize parameterized classesPaul Berry2010-10-276-127/+178
| | | | | | | | | | | | | | | | | | | This is a reconciliation/melding of Paul's (#4534) Class inheritance with parameterized classes is no longer ignored and Markus's Fix for #4778 -- evaluate parameterized classes when they are instantiated Extracted the code from Resource::Type#mk_plain_resource that evaluates parents and tags the catalog, and moved that into a new method called instantiate_resource. Instantiate_resource is now also called from Parser::Ast::Resource#evaluate, so that the notation "class { classname: }" now executes this code too. Likewise adds class evaluation so that it behaves the same (with regard to lazy / strict evaluation) as include classname
* Fix for #5022 -- Escaped newlines should be elidedMarkus Roberts2010-10-182-1/+3
| | | | | | | | | | | This was a regression, not covered by a test; previously the string "foo\ bar" would be interpreded as "foobar" but this was changed to "foo\\\nbar" in 2.6.x with my string interpolation refactor. This change restores the behaviour.
* Updated CHANGELOG and version for 2.6.3rc1James Turnbull2010-10-142-1/+8
|
* Fix for #4832 -- Making PSON handle arbitrary binary dataMarkus Roberts2010-10-132-12/+22
| | | | | | | | | The PSON library needlessly assumed that the data to be transmitted was well- formed unicode. This made Latin-1 users (and anyone who needed to serialize arbitrary binary data) sad. This patch goes some of the way to resolving the issues, by passing through non-unicode data rather than just failing, adds tests, and cleans up a pernicious assumption about escape characters in ruby regular expressions not marked "n" (no-encoding).
* Minimal fix for #4975 -- only call chage when managing password age rulesMarkus Roberts2010-10-134-8/+53
| | | | | This is intended to be a minimal fix, with tests, to prevent chage from running unless needed.
* Fix for #4963 -- Use correct commands for password expiry on solarisMarkus Roberts2010-10-132-4/+4
| | | | | This fixes the command / option issues of #4963 as suggested on the ticket; the setting-expiry when not needed aspects are deferred to #4975.
* Updated CHANGELOG for 2.6.2James Turnbull2010-10-081-0/+8
|
* Fix for #4945 -- explicitly check os to supress man page installationMarkus Roberts2010-10-061-1/+1
| | | | | | | | The fix for #4644 usurped an existing option flag to supress the installation of man pages on Microsoft Windows, when the desired behaviour was to only skip the installation on MSWin and not change the behaviour on other platforms. This patch implements the check explicitly to correctly express the desired behaviour.
* Reversion of 021d534482dd8edb863cb77d668ac3525362a0a6Markus Roberts2010-10-051-2/+1
| | | | This fix for #3707 was incorrect & just moved the problem (see #4929).
* Fixed #4919 - added parenths to fix error message:James Turnbull2010-10-021-1/+1
| | | | /usr/lib/ruby/site_ruby/1.8/puppet/util/metric.rb:62: warning: parenthesize argument(s) for future version
* Incremented version to 2.6.2James Turnbull2010-10-011-1/+1
|
* Updated CHANGELOG for 2.6.2rc1James Turnbull2010-10-011-195/+43
|
* Fixed documentation typoJames Turnbull2010-10-011-1/+1
|
* Fix for #4896 -- stray newline left over from removed diagnosticMarkus Roberts2010-09-302-2/+2
| | | | | A newline that was part of a diagnostic was left in, and this caused problems with the serialization of strings in "preserve newlines" mode.
* (#4772) Update SuSE .spec fileJacob Helwig2010-09-302-27/+13
|
* Fixes #4792 (Duplicate definition since 2.6.1 upgrade)Paul Berry2010-09-302-0/+22
| | | | | | | | | | | | | | | The evaluate_definitions method was first figuring out which resources needed to be evaluated (using unevaluated_resources), and then evaluating them one by one. As a result, if evaluating one resource triggered another resource to be evaluated, the latter resource could get evaluated twice. This bug could occur, for example, if both resources were classes that were included into the node by an external node classifier, and if the first of the two classes included the second. Modified Resource#evaluate to be idempotent. Also added an integration test to verify the fix.
* Improvement to #4025: made spec tests work on all platformsPaul Berry2010-09-291-1/+3
| | | | | | The spec test changes for ticket 4025 (binary plist support) failed on non-OSX systems because of a missing stub. Added the missing stub so that the spec tests can now run on all systems.
* Adds #3046 - support for password min/max ageNick Lewis2010-09-299-15/+131
| | | | | | | This adds a new feature to user providers "manages_password_age", along with properties password_min_age and password_max_age to the user type. These represent password min and max age in days. The useradd and user_role_add providers now support these new properties.
* [#4783] (#4783) Fix RRDGraph report generationMatt Robinson2010-09-296-2/+287
| | | | | | | | The code made assumptions about report structure that weren't valid for 2.6.x. The change has been verified to work with 0.25.x and 2.6.x report formats. Paired with: Rein Henrichs
* Add user account expiry to the useradd type and providerDean Wilson2010-09-294-2/+49
|
* Fixed #4025 (failure in launchd if certain plists are binary).Paul Berry2010-09-292-14/+22
| | | | | | | | | | Modified the launchd provider to use OSX's "plutil" command to read plists. This allows it to handle properly lists in both XML format and binary format. Launchd continues to write out propertly lists in XML format. This is not a problem because the operating system is able to understand both formats.
* Fix for #4649 -- avoid unsupported features on non-posix systemsMarkus Roberts2010-09-281-11/+15
| | | | | | | | | MS Windows is apparently only "posix curious;" many of the usual fcntl flags are not defined when running under MS Windows. It also appears that we are only using a small subset of the vendored event-loop library and could replace it with a handful of (portable) extracted methods. This, however, would be too agressive of a refactor for 2.6.2 and so this commit simply avoids referring to the unsupported flag values in environments where they are not defined.
* Fix for 4273 -- revert b7e2580ab49ecdb67fc9b522829c005fc3750fbeMarkus Roberts2010-09-281-12/+0
| | | | | | The debugging information added in commit b7e2580ab49ecdb67fc9b522829c005fc3750fbe was not thread safe and, as it turns out, not as useful as had been hoped. This commit reverts it.
* Fix for #4804 -- escaped backslashes in interpolated stringsMarkus Roberts2010-09-282-1/+9
| | | | | | | | Part of the ongoing refinement / cleanup of the string interpolation semantics. When scanning for an unescaped string terminator we now also allow an 0 or more pairs of backslashes (that is, escaped backslashes) before the terminator. Thanks to Jacob for the test I should have added.
* Fixes #4863 (Missing "require 'webrick'" causes nondeterministic spec failures)Paul Berry2010-09-281-0/+1
| | | | Added a missing require to webrick/rest.rb.
* (#4860) Add regression tests that would have caught bad params methodMatt Robinson2010-09-282-18/+18
| | | | | This is another case where our test objects were overly mocked so they didn't alert us to problems with our implementation.
* (#4860) Fix wrong method name.. params seems to be renamed to parametersSimon Effenberg2010-09-281-1/+1
|
* Fix for #4644: install.rb works properly on WindowsNick Lewis2010-09-281-13/+7
| | | | | | | | | We were failing to make the sbin directory, and so the install script was failing to install files to it. Also, we were trying to add man pages regardless of whether or not we actually wanted to. Changed operating system detection to use Facter["operatingsystem"], which is easier to check than RUBY_PLATFORM (there are multiple different values for Windows).
* Fix #4726 Update puppet rrdtool metric code to support modern rrd ruby bindingsJesse Wolfe2010-09-282-10/+40
| | | | | | | | | The rrd project has been shipping ruby bindings since 1.3.0, and the old rrdtool ruby library is no longer being maintained. This patch is based upon Davor Ocelic's submitted code, with the addition that I've added conditionals so it can still call the old rrdtool library if a modern rrd is not installed.
* Fix #4226 - Prepend 'Puppet CA: ' to fqdn for default root ca_nameJacob Helwig2010-09-285-14/+19
| | | | | | | | Having a root ca_name that matches the fqdn of the puppet master would cause certificate lookup problems on some clients, resulting in failed SSL negotiation. Signed-off-by: Jacob Helwig <jacob@puppetlabs.com>
* Port Puppet::SSLCertificates::CA test to rspecJacob Helwig2010-09-282-87/+99
| | | | Signed-off-by: Jacob Helwig <jacob@puppetlabs.com>
* Fixes #4852 - error messages involving Whits now mention Classes insteadNick Lewis2010-09-283-0/+16
| | | | | | | | | Whits are inserted into the dependency graph in the place where an empty class is being required. Unfortunately, when such a class is involved in a loop, the error message shows the cycle as involving Whit[Classname]. This patch changes it to say Class[Classname], which is much easier to understand. It also fixes puppetdoc from generating documentation on the Whit type.
* Fix #4267 - Create a backup before dropping permissionsJesse Wolfe2010-09-281-0/+7
| | | | | This change just forces a file to be written to the filebucket before we drop the permissions necessary to do so.
* (#4763) Don't call a method that was removed in Rails 3 activerecordMatt Robinson2010-09-224-10/+22
| | | | | | | | | | Calling this method caused storeconfigs not to run. ActiveRecord::Base.allow_concurrency was deprecated in Rails 2.2. We support activerecord 2.1 and higher, so we still need to call this method for 2.1. I factored out the code that determines our activerecord version to a method in util so that the code was easier to read and test.
* Fixed #4763 - Hardcoded ActiveRecord versionJames Turnbull2010-09-223-3/+3
|
* Fixes #4822 -- Puppet doc -o option brokenPaul Berry2010-09-223-46/+40
| | | | | | | | | | The global "-o" option ("--onetime") was overriding the application-specific option "-o" because global options were being sent to the OptionParser after application-specific options. Modified the order in which options are sent to the OptionParser to have the correct behavior. Also merged together the two methods that were applying options so that the order is more explicit.
* [#4798] Puppet doc manifests documentation mode brokenPaul Berry2010-09-223-7/+58
| | | | | | | | | | | | When running puppet doc, if the directory containing the user's specified manifest file overlaps with the modules directory (i.e. they are the same directory or one contains the other), Puppet doc would try to parse the overlapping files twice, triggering an exception which made the documentation run fail. Fixed the bug by adding a check to the RDoc::Parser#scan method to prevent re-parsing of files that have already been parsed. Also added a spec test to verify that this works.
* [#4692] undefined variables cause :undef to be passed to functionsPaul Berry2010-09-222-5/+15
| | | | | | | | | | The :undef symbol, which we use internally to distinguish between undefined variables and variables whose value is the empty string, is being leaked in calls to functions (e.g. "split"). This is a departure from 0.25.x behavior, where undefined variables evaluated to "". This patch restores the 0.25.x behavior.
* [#4787] Missing require causing failureJesse Wolfe2010-09-221-0/+1
| | | | This code was using a constant that might not always be loaded.
* Fix for #4746 -- Newline goes at the _end_ of the lineMarkus Roberts2010-09-221-1/+1
| | | | Fredrik Eriksson's suggested change, from the ticket.
* Fix #4743: Allow the audit meta-parameter to accept both 'all', and :allJacob Helwig2010-09-222-3/+10
|
generated by cgit (git 2.34.1) at 2025-09-26 13:09:30 +0000