summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | [#4114] Fix failures in the unit testsMatt Robinson2010-07-076-27/+16
| | | | | | | | | | | | The initial commit changed the name of a method (close -> close_all) and changed the way the array log destination worked before we saw that the unit tests were using it differently.
* | [#4114] Added queueing to the logNick Lewis2010-07-074-30/+65
| | | | | | | | | | The log will now queue any log messages created when there is no destination, and will flush the queue when a destination is added.
* | [#4110] Wrap Type#retrieve calls for backwards compatibilityJesse Wolfe2010-07-076-13/+19
| | | | | | | | | | | | | | | | This patch introduces Type#retrieve_resource as a wrapper for Type#resource, to coerce the return value from legacy types from Hash to Resource. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
* | Fix for #4120 No namevar running puppet doc -r typeMarkus Roberts2010-07-071-2/+2
| | | | | | | | Reworked it to use the new key_attributes instead.
* | [#2370] Allow OpenBSD to add packages with versions and flavorsMatt Robinson2010-07-062-9/+43
| | | | | | | | This patch is from Joe McDonagh <joseph.e.mcdonagh@gmail.com>
* | [#4108] Changed missing Application constant errorNick Lewis2010-07-061-1/+1
| | | | | | | | | | Changed the error message when searching for an Application constant which is undefined.
* | [#4149] Don't create two Resource::TypeCollectionsJesse Wolfe2010-07-062-2/+2
| | | | | | | | | | | | By asking the environment for known resources instead of creating a type collection ourselves, we avoid accidentally creating two Resource::TypeCollection objects.
* | [#3906] Fixed missing constant Puppet::Rails when using storeconfigsNick Lewis2010-07-062-5/+1
| | | | | | | | | | | | The hook for storeconfig will now require 'puppet/rails' if the setting is set to true. It was previously being indirectly required via parser/interpreter, which was removed.
* | [#4136] Specs should listen on localhostJesse Wolfe2010-07-063-5/+8
| | | | | | | | | | | | This patch prevents specs from opening IP ports to the world. Some specs had to be adjusted to unset this setting so they could test the non-spec default value.
* | [#3961] Part two: --destroy should also be localJesse Wolfe2010-07-062-1/+19
| |
* | Fix for #4148 (2.6 is greater than 0.25.x)Markus Roberts2010-07-061-1/+1
| | | | | | | | | | We had a hardcoded assumption that the version number would always start with a zero, and thus were failing to recognise 2.6.0 as greater than 0.25.x
* | Fix for #4142 stray use of JSON instead of PSONMarkus Roberts2010-07-061-1/+1
| | | | | | | | Somehow one use of JSON escaped the global find and replace of PSON --> JSON.
* | [#3172] Fix the arguments to Application::Kick.new, which I had brokenJesse Wolfe2010-07-022-1/+8
| |
* | Maint: Explicitly put test sqlite files in a temp directoryJesse Wolfe2010-07-021-0/+6
| | | | | | | | | | A spec was failing because it didn't know where to put a temporary sqlite database file
* | maint: fix stub failure in report_spec.rbJesse Wolfe2010-07-021-0/+3
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during an unrelated spec.
* | maint: fix stub failures in report_spec.rbJesse Wolfe2010-07-022-1/+4
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | maint: fix stubbing in package_spec.rbJesse Wolfe2010-07-021-148/+153
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | maint: fix stubs in transaction_spec.rbJesse Wolfe2010-07-021-0/+4
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | maint: fix stubbing in catalog_spec.rbJesse Wolfe2010-07-021-0/+4
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | Maint: Improve the speed of setting settings.Nick Lewis2010-07-021-12/+19
| | | | | | | | | | Our settings were slow because I was querying Application objects for their run_mode repetitively
* | maint: file_spec heisenbugsJesse Wolfe2010-07-021-0/+7
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | Heisenbug: settings as catalog trying to create directoriesJesse Wolfe2010-07-021-0/+1
| | | | | | | | | | Specs in settings were allowing the settings-as-catalog to escape onto the system.
* | maint: spec_helper should reset settings directories on *every* testJesse Wolfe2010-07-021-5/+11
| | | | | | | | | | Previously, spec_helper's attempts to set :confdir, and :vardir to /dev/null were getting thwarted by the Settings.clear in after_all
* | maint: Remove a heisentest that wasn't testing what it claimedJesse Wolfe2010-07-021-25/+0
| | | | | | | | | | | | This test in agent_spec.rb was no longer testing any of Puppet::Application::Agent, but rather exercising Util::Settings in a naive way. Deleted.
* | maint: spec_helper should only get loaded onceJesse Wolfe2010-07-021-0/+5
| | | | | | | | | | | | Added a C-style if-defined? guard to spec_helper.rb to make sure that it only gets evaluated once. (The file is getting loaded multiple times because ruby gets confused by relative paths in `require` statements)
* | maint: :mutable_defaults to improve spec consistencyJesse Wolfe2010-07-023-4/+18
| | | | | | | | | | | | Added a Puppet::Util::Settings layer called :mutable_defaults to emulate the interaction between Puppet::Application and defaults.rb that was getting thwarted by rspec.
* | [#4090] Fix the run_mode for certs and put tests on the applications to ↵Matt Robinson2010-07-026-6/+20
| | | | | | | | | | | | | | assert their run_mode Also cleanup of an unecessary puts line, make master tests run when on their own, and moving a require to a more usual spot.
* | [#4059] fix the specs to correctly mock the Puppet::Resource.new call signatureJesse Wolfe2010-07-021-2/+2
| |
* | [#4059] Minor errors preventing ralsh from runningJesse Wolfe2010-07-011-2/+1
| |
* | [#2713] Enable ELSIFJesse Wolfe2010-07-013-864/+923
| |
* | [#3172] puppet kick can take hostnames as bare argumentsJesse Wolfe2010-07-013-8/+12
| |
* | [#4108] Missing constants fail deliberately and with a messageNick Lewis2010-07-011-1/+6
| | | | | | | | | | | | | | Previously, any failed call to Puppet::Application.find would result in an error being raised by const_get, resulting in a messy crash with a stack trace. Now that error is handled, and the application will print a message and exit.
* | [#4092] Changed notify message to defined instead of changedNick Lewis2010-07-011-1/+1
| | | | | | | | | | | | Notify was returning a nil current value, rather than :absent, which caused puppet to think the message had been changed from blank to its new value, rather than defined as that value.
* | Fix for #4091 -- require loop in executablesMarkus Roberts2010-07-012-2/+0
| | | | | | | | | | The describe and resource (ralsh) applications required puppet, creating a loop & thus crashing them.
* | [#4090] Change how RunMode instances are created so that an object for each ↵Matt Robinson2010-07-016-5/+11
| | | | | | | | | | | | | | RunMode is only created once instead of every time it's called Got lots of unpredictable test failures, presumably because a new RunMode was being created every time we accessed the RunMode.
* | [#4090] Fix last few tests and renames of mode to run_modeMatt Robinson2010-07-015-15/+5
| |
* | [#4090] Git rid of the idea that run_mode is a configurable option with defaultsMatt Robinson2010-07-018-18/+75
| | | | | | | | | | Along the way this fixes an issue with 2.6 alpha that sections of the puppet config file were getting ignored.
* | [#4090] Rename mode (:master, :agent, :user) to run_modeMatt Robinson2010-07-0120-65/+65
| | | | | | | | | | | | | | | | Mode is a terribly overused word. Files use it, puppetdoc uses it, and certs use it, and those are just the places that I happened to stumble upon. It makes reading code very confusing and finding things in code difficult. I know namespacing allows us to reuse words for method and variable names, but that doesn't mean we should.
* | [#4089] Replace internal usage of :check with :auditNick Lewis2010-07-018-11/+11
| | | | | | | | | | | | Per Luke's replacement of :check with :audit, and deprecation of :check, I've replaced all of our internal uses of :check with :audit. Importantly, this silence the deprecation warnings during regular usage from eg. ralsh.
* | [#3961] puppet cert --generate implies ca_location = :localJesse Wolfe2010-06-301-1/+5
| |
* | [#3961] Rename cert's @mode to @cert_mode to reduce confusionJesse Wolfe2010-06-302-19/+19
| |
* | maint: Confine a test that depends on sqliteMatt Robinson2010-06-282-0/+4
| | | | | | | | I'm also going to update the wiki to mention sqlite is a test dependency
* | [#3994-part 3] rename spec tests from *_spec_spec to *_spec.rbMarkus Roberts2010-06-28344-0/+0
| | | | | | | | Part 2 re-did the change on the spec files, which it shouldn't have.
* | Fix for test ordering sporadic failureMarkus Roberts2010-06-281-1/+1
| | | | | | | | | | The spec/unit/provider/ssh_authorized_key/parsed_spec_spec.rb was trying to use Dir.tempdir but getting ours.
* | [#3994-part 2] rename integration tests to *_spec.rbMarkus Roberts2010-06-28397-0/+0
| | | | | | | | | | | | | | | | | | Some spec files like active_record.rb had names that would confuse the load path and get loaded instead of the intended implentation when the spec was run from the same directory as the file. Author: Matt Robinson <matt@puppetlabs.com> Date: Fri Jun 11 15:29:33 2010 -0700
* | Merge branch 'testing' into tweak/testing/file_fix_root_spec_failureMarkus Roberts2010-06-288-18/+16
|\ \
| * \ Merge branch 'testing' into tweak/testing/silence_spec_outputMarkus Roberts2010-06-285-11/+13
| |\ \
| | * | maint: Fixing tests that fail when run as rootMatt Robinson2010-06-281-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit ae520057280c2454bc44c64ac1e6686bf2eb086d introduced some code that used 'asuser' which does nothing when not run as root, but in these tests tries to run as a non-existent user. Stubbing out the asuser method to just yield prevents test failures when running as root.
| | * | Cleaning up various warnings in specsMarkus Roberts2010-06-284-11/+11
| | | | | | | | | | | | | | | | | | | | There were a bunch of "warning: parenthesize argument(s) for future version" messages; now there aren't.
| * | | maint: Fixes some noisy specsNick Lewis2010-06-283-7/+3
| |/ / | | | | | | | | | | | | This change removes some irrelevant output (debugging information, warnings, etc) from a few specs.