| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ |
|
| |
|
| |
|
| |
|
|
|
|
| |
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resource parameters whose values are a resource reference (ie require,
notify...) where always DELETEd/INSERTed because the code comparing
resource reference compared object instances instead of their values
(since Puppet::Parser::Resource::Reference doesn't override == ), leading
to storeconfig performance issues.
The correct fix would have been to define == in Puppet::Parser::Resource::Reference
but that might introduce some side effects I don't know.
Hence, the fix introduces a local compare() method that knows how to
compare Puppet::Parser::Resource::Reference.
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resources whose references are of the form:
Main::Sub1::Sub2
are extracted from the database under the form:
Main::sub1::sub2
Puppet then fails to match them against compiled resources of same
references which are capitalized as they should, and
tries to overwrite them on every storeconfig run, leading to tons
of cascading DELETE/INSERT, hurting performance.
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|
|
|
|
|
|
|
|
| |
This is a workaround.
Since rails seems to have difficulties to map associations to
Puppet classes, we explain it carefully what to expect.
Changelog
|
|
|
|
|
|
| |
Turns on the ICMP echo testing against the target host. Defaults to off.
111111111
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
|
|
| |
We should deprecate the method_missing stuff in 0.25.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
| |
Signed-off-by: Luke Kanies <luke@madstop.com>
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shadow
variables that the puppet template should otherwise see. Specific changes:
* Added testing of the Scope#to_hash method, which returns a hash of name and
value pairs in a scope or, optionally, in the scope and enclosing scopes.
* Use member variables rather than methods in the function tests.
* Fix up tests that fail once we move over to instance variables rather than
methods: Puppet can no longer detect an undefined variable reference, so we
end up failing any test that expected to get a parser error.
* Several tests have manual checks introduced to simulate an end user manually
writing the checks that used to be automatic, and others drop the validation
that parsing fails when a variable is not in scope.
* Added tests for legacy variable lookup and that the shadowing of local
variables by Kernel methods is still in effect.
Signed-off-by: Daniel Pittman <daniel@rimspace.net>
(cherry picked from commit 5c5f315cceadc52203e53883b77bc01c1d7a2e7f)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
wrapper.
This helps resolve redmine #1427, by providing a safe mechanism to access variables.
* Implement Puppet::Parser::Scope#to_hash, which returns a hash containing all the
variable bindings in the current and, optionally, parent scope.
* Use that to set instance member variables into Puppet::Parser::Templatewrapper
* Report the time taken for variable binding at debug level, to help identify any
performance regression that is encountered in the real world.
* Rename the @scope and @file members of the template wrapper, to avoid clashing
with a scope variable exposed within puppet.
Signed-off-by: Daniel Pittman <daniel@rimspace.net>
(cherry picked from commit ba220b41e4f509f2632e2664d332e49b20a70ea7)
|
|
|
|
|
|
|
| |
interpolation, not both, to avoid issues where a #{} interpolated value
contains a % character.
Signed-off-by: Daniel Pittman <daniel@rimspace.net>
|
|
|
|
| |
--mandir --destdir in install.rb
|
|
|
|
| |
Updated, I was calling .base myself instead of the actual string
|
| |
|
|
|
|
| |
This performs a glob on the YAML directory, and instances everything it finds
|
|
|
|
| |
This reverts commit 971af69b7388cf5155bb124246f2a697578cc6e9.
|
| |
|
| |
|
| |
|
|
|
|
| |
each certificate signing
|
|
|
|
| |
Tidied up some of the code a little
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
lib/puppet/provider/service/redhat.rb
nothing to commit (working directory clean)
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
| |
I couldn't get this to fail in a targeted regression test,
but if it's not working, it causes a failure in the webrick
tests.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
|
|
| |
I wonder if anyone's actually using this...
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
|
|
|
| |
Darwin has a case-insensitive FS, so the test was failing
because it was specifically testing case sensitivity.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
| |
This reverts commit f16da4250c16aeab932a81a349df059c69d7ee23.
|
| |
|
|
|
|
|
|
| |
Issue 1437
In two cases, I removed the assertion that caused the failure.
In one case, I changed the assertion to expect an exception.
|
|
|
|
| |
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
|
|
|
|
| |
This looks like a much larger commit than it is -- it doesn't change
any behaviour at all, it just adds some integration tests (which expose
the problem) and then switches from an ad-hoc api to a request-based api.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
|
|
|
|
|
|
| |
with 'yaml' still being the default but 'marshal' being an option.
This is because testing has shown drastic performance differences
between the two, with up to 70% of compile time being spent
in YAML code. Use the 'catalog_format' setting to choose your format,
and the setting must be set on the client.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
|
|
|
| |
This reverts commit ac7f59618a80b6a4aac777f6184e7fa6a0614079.
The reason for this revert is that the problem never really existed;
Ruby's true and false are always used unless you quote them.
|
|
|
|
|
|
|
|
|
|
| |
I.e., you can't do confine :operatingsystem => %w{a b} and then
confine :operatingsystem => %w{b c}; you'd need to do them in one command.
This now-obsolete behaviour does not seem to be used anywhere.
The fix for #1431 is actually just removing the tests that exposed
this change; the change happened when I refactored how confines work.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Here were the main changes necessary:
* Fixed the class loader so it only loads mongrel if it's available.
* Fixed the test runner to skip example groups contained in non-runnable
example groups.
* Fixed the Mongrel tests to use quoted class names instead of constants,
since the constants themselves would be absent.
Signed-off-by: Luke Kanies <luke@madstop.com>
|