summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | [#2730] mount ensure present shouldn't unmountJesse Wolfe2010-07-092-16/+78
| | | | | | | | | | | | | | | | | | Ensuring "defined" on a mount just demands that the entry appears in the fstab file. Ensure "present" is now an alias for ensure "defined", so drives are no longer unmounted unless the resource is set to ensure "unmounted" This patch is based on a patch submitted by Aurelien Degremont.
* | Fixed subscribe exampleJames Turnbull2010-07-091-1/+1
| |
* | Fix for environments in startup script.Ken Barber2010-07-091-9/+9
| | | | | | | | | | | | | | | | - Dropped the forced --manifest switch in the suse startup script to allow for environments to re-define this. Otherwise, environments will not work as puppet override configuration with command line arguments.
* | Redmine: 2474 - Fix for mount fstype documentationSteven Jenkins2010-07-091-1/+1
| |
* | Fix for #4137 -- Oracle needs text for strings > 255Markus Roberts2010-07-081-1/+1
| | | | | | | | | | | | Oracle has a maximum VARCHAR (string) column length of 255 characters. Any column that is larger than 255 characters needs to be cast as a :text column instead of :string.
* | Fix for #2807 Puppet settings available as variablesMarkus Roberts2010-07-072-1/+22
| | | | | | | | | | | | | | This is Luke's patch plus a change to fix a test that it broke. It creates a new sub-scope off the top scope, called "settings" and adds each of the environment's settings to it as variables, thus satisfying the ticket while taking us one step further from being able to implement futures. *sigh*
* | [#4161] RDoc fails to parse some of our ruby syntaxJesse Wolfe2010-07-072-0/+12
| | | | | | | | | | | | | | | | RDoc's parser produces errors on this sort of statement: def (variable).method This patch wraps our occurances of those definitions with comments that suspend RDoc parsing.
* | [#3169] Adds more debugging to SSL cert verificationNick Lewis2010-07-071-0/+14
| | | | | | | | | | This patch (via Nicholas Veeser) adds more debugging when SSL cert verification fails.
* | Fix for #4167 -- overriding file permissions in conf fileMarkus Roberts2010-07-072-1/+2
| | | | | | | | | | The logic which iterates over the searchpath in reverse does not translate the name. Therefore file overrides in :master or :agent are not picked up.
* | [#4114] Fixes test failures caused by previous 4114 fixesNick Lewis2010-07-072-1/+2
| | | | | | | | | | An array was being used as a hash index, and still being pushed to, making Log::close fail to find and close it.
* | saving work for my unit tests. The redhat one still fails...Dan Bode2010-07-073-3/+75
| | | | | | | | | | | | [4123] [4124] - combined unit test for both fixes since they share some common code. proper unit tests to verify features for both patches.
* | [4123] - allows self.instances to correctly report state of services.Dan Bode2010-07-072-2/+3
| | | | | | | | | | | | Added hasstatus => true as attribute for new provider instance in init. redhat checks the hasstatus in the provider to determine service status.
* | created init provider method self.get_services which accepts an array of ↵Dan Bode2010-07-072-3/+11
| | | | | | | | | | | | | | | | filenames to exclude when processing defpath. also updated redhat provider to pass in a list of services to ignore. didnt need to munch exclude to an array, include? is safe to call on strings
* | [#4114] Fix failures in the unit testsMatt Robinson2010-07-076-27/+16
| | | | | | | | | | | | The initial commit changed the name of a method (close -> close_all) and changed the way the array log destination worked before we saw that the unit tests were using it differently.
* | [#4114] Added queueing to the logNick Lewis2010-07-074-30/+65
| | | | | | | | | | The log will now queue any log messages created when there is no destination, and will flush the queue when a destination is added.
* | [#4110] Wrap Type#retrieve calls for backwards compatibilityJesse Wolfe2010-07-076-13/+19
| | | | | | | | | | | | | | | | This patch introduces Type#retrieve_resource as a wrapper for Type#resource, to coerce the return value from legacy types from Hash to Resource. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
* | Fix for #4120 No namevar running puppet doc -r typeMarkus Roberts2010-07-071-2/+2
| | | | | | | | Reworked it to use the new key_attributes instead.
* | [#2370] Allow OpenBSD to add packages with versions and flavorsMatt Robinson2010-07-062-9/+43
| | | | | | | | This patch is from Joe McDonagh <joseph.e.mcdonagh@gmail.com>
* | [#4108] Changed missing Application constant errorNick Lewis2010-07-061-1/+1
| | | | | | | | | | Changed the error message when searching for an Application constant which is undefined.
* | [#4149] Don't create two Resource::TypeCollectionsJesse Wolfe2010-07-062-2/+2
| | | | | | | | | | | | By asking the environment for known resources instead of creating a type collection ourselves, we avoid accidentally creating two Resource::TypeCollection objects.
* | [#3906] Fixed missing constant Puppet::Rails when using storeconfigsNick Lewis2010-07-062-5/+1
| | | | | | | | | | | | The hook for storeconfig will now require 'puppet/rails' if the setting is set to true. It was previously being indirectly required via parser/interpreter, which was removed.
* | [#4136] Specs should listen on localhostJesse Wolfe2010-07-063-5/+8
| | | | | | | | | | | | This patch prevents specs from opening IP ports to the world. Some specs had to be adjusted to unset this setting so they could test the non-spec default value.
* | [#3961] Part two: --destroy should also be localJesse Wolfe2010-07-062-1/+19
| |
* | Fix for #4148 (2.6 is greater than 0.25.x)Markus Roberts2010-07-061-1/+1
| | | | | | | | | | We had a hardcoded assumption that the version number would always start with a zero, and thus were failing to recognise 2.6.0 as greater than 0.25.x
* | Fix for #4142 stray use of JSON instead of PSONMarkus Roberts2010-07-061-1/+1
| | | | | | | | Somehow one use of JSON escaped the global find and replace of PSON --> JSON.
* | [#3172] Fix the arguments to Application::Kick.new, which I had brokenJesse Wolfe2010-07-022-1/+8
| |
* | Maint: Explicitly put test sqlite files in a temp directoryJesse Wolfe2010-07-021-0/+6
| | | | | | | | | | A spec was failing because it didn't know where to put a temporary sqlite database file
* | maint: fix stub failure in report_spec.rbJesse Wolfe2010-07-021-0/+3
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during an unrelated spec.
* | maint: fix stub failures in report_spec.rbJesse Wolfe2010-07-022-1/+4
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | maint: fix stubbing in package_spec.rbJesse Wolfe2010-07-021-148/+153
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | maint: fix stubs in transaction_spec.rbJesse Wolfe2010-07-021-0/+4
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | maint: fix stubbing in catalog_spec.rbJesse Wolfe2010-07-021-0/+4
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | Maint: Improve the speed of setting settings.Nick Lewis2010-07-021-12/+19
| | | | | | | | | | Our settings were slow because I was querying Application objects for their run_mode repetitively
* | maint: file_spec heisenbugsJesse Wolfe2010-07-021-0/+7
| | | | | | | | | | Puppet::Util::Storage was trying to create state.yaml during unrelated specs.
* | Heisenbug: settings as catalog trying to create directoriesJesse Wolfe2010-07-021-0/+1
| | | | | | | | | | Specs in settings were allowing the settings-as-catalog to escape onto the system.
* | maint: spec_helper should reset settings directories on *every* testJesse Wolfe2010-07-021-5/+11
| | | | | | | | | | Previously, spec_helper's attempts to set :confdir, and :vardir to /dev/null were getting thwarted by the Settings.clear in after_all
* | maint: Remove a heisentest that wasn't testing what it claimedJesse Wolfe2010-07-021-25/+0
| | | | | | | | | | | | This test in agent_spec.rb was no longer testing any of Puppet::Application::Agent, but rather exercising Util::Settings in a naive way. Deleted.
* | maint: spec_helper should only get loaded onceJesse Wolfe2010-07-021-0/+5
| | | | | | | | | | | | Added a C-style if-defined? guard to spec_helper.rb to make sure that it only gets evaluated once. (The file is getting loaded multiple times because ruby gets confused by relative paths in `require` statements)
* | maint: :mutable_defaults to improve spec consistencyJesse Wolfe2010-07-023-4/+18
| | | | | | | | | | | | Added a Puppet::Util::Settings layer called :mutable_defaults to emulate the interaction between Puppet::Application and defaults.rb that was getting thwarted by rspec.
* | [#4090] Fix the run_mode for certs and put tests on the applications to ↵Matt Robinson2010-07-026-6/+20
| | | | | | | | | | | | | | assert their run_mode Also cleanup of an unecessary puts line, make master tests run when on their own, and moving a require to a more usual spot.
* | [#4059] fix the specs to correctly mock the Puppet::Resource.new call signatureJesse Wolfe2010-07-021-2/+2
| |
* | [#4059] Minor errors preventing ralsh from runningJesse Wolfe2010-07-011-2/+1
| |
* | [#2713] Enable ELSIFJesse Wolfe2010-07-013-864/+923
| |
* | [#3172] puppet kick can take hostnames as bare argumentsJesse Wolfe2010-07-013-8/+12
| |
* | [#4108] Missing constants fail deliberately and with a messageNick Lewis2010-07-011-1/+6
| | | | | | | | | | | | | | Previously, any failed call to Puppet::Application.find would result in an error being raised by const_get, resulting in a messy crash with a stack trace. Now that error is handled, and the application will print a message and exit.
* | [#4092] Changed notify message to defined instead of changedNick Lewis2010-07-011-1/+1
| | | | | | | | | | | | Notify was returning a nil current value, rather than :absent, which caused puppet to think the message had been changed from blank to its new value, rather than defined as that value.
* | Fix for #4091 -- require loop in executablesMarkus Roberts2010-07-012-2/+0
| | | | | | | | | | The describe and resource (ralsh) applications required puppet, creating a loop & thus crashing them.
* | [#4090] Change how RunMode instances are created so that an object for each ↵Matt Robinson2010-07-016-5/+11
| | | | | | | | | | | | | | RunMode is only created once instead of every time it's called Got lots of unpredictable test failures, presumably because a new RunMode was being created every time we accessed the RunMode.
* | [#4090] Fix last few tests and renames of mode to run_modeMatt Robinson2010-07-015-15/+5
| |
* | [#4090] Git rid of the idea that run_mode is a configurable option with defaultsMatt Robinson2010-07-018-18/+75
| | | | | | | | | | Along the way this fixes an issue with 2.6 alpha that sections of the puppet config file were getting ignored.