summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixes #2367 - Mongrel::HTTPRequest returns a StringIO objectJames Turnbull2009-07-082-2/+2
| | | | | | | | When the PUT body is large enough that Mongrel::HTTPRequest#body returns a StringIO object instead of a String. StringIO#to_s then returns "<StringIO#8236987299>" instead of the string contents. When that string is passed to YAML it returns false which is then passed to save_object without any real time checking. This is a combination of patches from Jordan Curzon and Ricky Zhou.
* Fix #2082 - puppetca shouldn't list revoked certificatesBrice Figureau2009-07-076-10/+37
| | | | | | | | This patch does two things: * it enhance puppetca to list revoked certificates (prefixed by -) * it fixes the ca crl verification which was broken Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix #2348 - Allow authstore (and REST auth) to match allow/deny against ↵Brice Figureau2009-07-072-10/+13
| | | | | | | | | | | | | | | opaque strings This patch removes the limitation of allow/deny which were only matching ip addresses or hostname (or pattern of). It makes sure any kind of string can be matched (by strict equality) while still keeping the old behaviour. Opaque strings can only contains: alphanumeric characters, - _ and @. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix #2392 - use Content-Type for REST communicationBrice Figureau2009-07-0513-48/+209
| | | | | | | | | | | | | | | | | | | There were two problems: * server->client communications is using Content-Type with the direct format name instead of the format mime-type. * client->server communications is not using Content-Type to send the format of the serialized object. Instead it is using the first member of the Accept header. The Accept header is usually reserved for the other side, ie what the client will accept when the server will respond. This patch makes sure s->c communication contains correct Content-Type headers. This patch also adds a Content-Type header containing the mime-type of the object sent by the client when saving. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fixed #2293 - Added cron syntax X-Y/Z and '7' for sundayJames Turnbull2009-07-051-3/+8
|
* Switching to LoadedCode from ASTSetLuke Kanies2009-07-0518-216/+163
| | | | | | | | I also took the opportunity to clean up and simplify the interface to the parts of the parser that interact with this. Mostly it was method renames. Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding a special class to handle loaded classes/defines/nodesLuke Kanies2009-07-052-0/+191
| | | | | | | | | This class is extracted from the Parser class, and the main driver for it is to enable us to put mutexes around some of the hashes to see if they're the source of a race condition. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fix #2383, an incompatibility with early ruby 1.8 versionsChristian Hofstaedtler2009-07-051-1/+2
| | | | | Earlier ruby 1.8 versions do not have start_with? for Strings. Found by John Barbuto.
* Fixing #2238 In some cases blank? is not available on String.Jordan Curzon2009-07-041-1/+1
| | | | Signed-off-by: Jordan Curzon <curzonj@gmail.com>
* Fixing #2238 - Deal with nil hash keys from mongrel paramsJordan Curzon2009-07-022-0/+7
| | | | | | | | Mongrel::HttpRequest.query_parse outputs a params hash with nil keys given certain query strings. Network::HTTP::Handler.decode_params needs to check the incoming values. Signed-off-by: Jordan Curzon <curzonj@gmail.com>
* Final fix to CI test rakesJames Turnbull2009-06-281-2/+2
|
* Set ENV['PATH'] to an empty string if non-existentNigel Kersten2009-06-281-1/+1
| | | | Signed-off-by: Nigel Kersten <nigelk@google.com>
* Fix to CI rake tasksJames Turnbull2009-06-271-2/+2
|
* Fixing #2197 - daemontools tests now passLuke Kanies2009-06-262-31/+74
| | | | | | | This actually involved a bit of rewriting of the code, but the code's simpler now, too. Signed-off-by: Luke Kanies <luke@madstop.com>
* Change the diff default output to "unified"Stig Sandbeck Mathisen2009-06-261-1/+1
|
* Added missing colon to suntabMartin Englund2009-06-261-1/+2
|
* Fixed #2087 and refactored the code that gets the smf service stateMartin Englund2009-06-261-31/+19
|
* Using the logging utilities to clean up module warningsLuke Kanies2009-06-192-2/+27
| | | | | | | This just makes it easier to add context to warnings and other logs from the module. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #1064 - Deprecating module 'plugins' directoriesLuke Kanies2009-06-192-9/+44
| | | | | | | | | You should now use 'lib' instead of 'plugins'. The old directory still works, but you get a warning for every module that uses it. Signed-off-by: Luke Kanies <luke@madstop.com>
* Removing deprecated :pluginpath settingLuke Kanies2009-06-192-9/+3
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2094 - filebucket failures are clearer nowLuke Kanies2009-06-162-1/+22
| | | | | | We just add a bit of information to the exception. Signed-off-by: Luke Kanies <luke@madstop.com>
* Refactoring part of the file/filebucket integrationLuke Kanies2009-06-145-110/+93
| | | | | | | | | | The goal of this commit is to fix ordering issues that could result when the filebuckets are added to the catalog after the resources that use them. This condition showed up somewhat arbitrarily. Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding tests for file/backup behaviourLuke Kanies2009-06-141-0/+42
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixed pi binary so --meta option works and updated documentationDavid Lutterkort2009-06-132-3/+7
| | | | Signed-off-by: James Turnbull <james@lovedthanlost.net>
* Fixing #2323 - Modules use environments correctlyLuke Kanies2009-06-122-4/+6
| | | | | | | | Previously, modules were not using their environments when looking up their paths, which meant that they often found files in the wrong environment. Signed-off-by: Luke Kanies <luke@madstop.com>
* Merge branch 'tickets/master/2102'James Turnbull2009-06-131-1/+1
|\
| * Fixed #2102 - Rails feature update fixed for Debian and UbuntuJames Turnbull2009-06-131-1/+1
| |
* | Fixed #2052 - Added -e option to puppet --help outputJames Turnbull2009-06-121-1/+4
|/
* Fix #2333 - Make sure lexer skip whitespace on non-tokenBrice Figureau2009-06-123-1/+12
| | | | | | | | | Comments and multi-line comments produces no token per-se during lexing, so the lexer loops to find another token. The issue was that we were not skipping whitespace after finding such non-token. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Updated split function and add split function unit tests (courtesy of Thomas ↵James Turnbull2009-06-126-6/+73
| | | | Bellman)
* * provider/augeas: strip whitespace and ignore blank linesDavid Lutterkort2009-06-122-0/+15
| | | | Signed-off-by: James Turnbull <james@lovedthanlost.net>
* Fixed pi testsJames Turnbull2009-06-122-2/+9
|
* Fixed #2222 - Cleanup pi binary options and --help outputJames Turnbull2009-06-122-20/+38
|
* Fixing #2329 - puppetqd tests now passLuke Kanies2009-06-121-1/+1
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Cleaning up scope tests a bitLuke Kanies2009-06-111-4/+3
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2336 - qualified variables only throw warningsLuke Kanies2009-06-113-56/+106
| | | | | | | | | We were previously throwing exceptions. This also ports all of the tests for variable lookup over to rspec. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fix #2246 - take2: make sure we run the rails tag query only when neededBrice Figureau2009-06-112-2/+19
| | | | | | | | | Adding the tags to the rails collect query can reduce performance because there are 2 more tables to join with. So we make sure to include tags in the query only when it is necessary. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix collector specs which were not workingBrice Figureau2009-06-111-9/+12
| | | | | | | | | The various collector specs covering the rails query code were not in fact covering anything. This patch fixes the specs to integration tests that actually verify the rails query building code works fine. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Make sure overriding a tag also produces a tagBrice Figureau2009-06-112-3/+16
| | | | | | | This is so that overriding the "tag" metaparameter ends-up in the resource tags on the server. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Removed a unit test which tested munging which is no longer done in the typeBryan Kearney2009-06-101-7/+0
|
* Clearn up a parsing error reported by the testsBryan Kearney2009-06-101-2/+2
|
* vim: several improvements + cleanupMarc Fournier2009-06-101-20/+38
| | | | | | | | | | | | | | | * added highlighting for different type of keywords: * if/else * undef * puppet function names * parameters passed to "ensure" * unquoted digits * fixed regexps to match resources containing "::", "-" and "_" * handled escaped variables (variable which don't belong to puppet) * removed unused definitions and added comments
* Fixed #2229 - Red Hat init script errorJames Turnbull2009-06-101-1/+1
|
* Fix #1907 (or sort) - 'require' puppet functionBrice Figureau2009-06-103-0/+97
| | | | | | | | This function acts exactly as the 'include' function, but also adds an ordering relation between the included class and the class where the require function is. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* #2332: Remove trailing slashes from path commands in the pluginBryan Kearney2009-06-092-0/+7
|
* Changing the preferred serialization format to jsonLuke Kanies2009-06-064-13/+5
| | | | | | | | | This won't affect most people, but it's a good default to have for those who can support it. Signed-off-by: Luke Kanies <luke@madstop.com> Minor changes to previous commit
* Switching Queueing to using JSON instead of YAMLLuke Kanies2009-06-066-53/+158
| | | | | | This provides about a 75x speedup, so it's totally worth it. The downside is that queueing requires json, but only on the server side.
* Adding JSON support to CatalogsLuke Kanies2009-06-064-0/+267
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Providing JSON support to the Resource classLuke Kanies2009-06-062-3/+221
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding a JSON utility module for providing Ruby compatLuke Kanies2009-06-062-0/+34
| | | | | | | This provides the class-method behaviour that Ruby's JSON support expects but that we don't provide. Signed-off-by: Luke Kanies <luke@madstop.com>