| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
Reworked it to use the new key_attributes instead.
|
| |
| |
| |
| | |
This patch is from Joe McDonagh <joseph.e.mcdonagh@gmail.com>
|
| |
| |
| |
| |
| | |
Changed the error message when searching for an Application constant
which is undefined.
|
| |
| |
| |
| |
| |
| | |
By asking the environment for known resources instead of creating a type
collection ourselves, we avoid accidentally creating two
Resource::TypeCollection objects.
|
| |
| |
| |
| |
| |
| | |
The hook for storeconfig will now require 'puppet/rails' if the setting
is set to true. It was previously being indirectly required via
parser/interpreter, which was removed.
|
| |
| |
| |
| |
| |
| | |
This patch prevents specs from opening IP ports to the world.
Some specs had to be adjusted to unset this setting so they could test
the non-spec default value.
|
| | |
|
| |
| |
| |
| |
| | |
We had a hardcoded assumption that the version number would always start with
a zero, and thus were failing to recognise 2.6.0 as greater than 0.25.x
|
| |
| |
| |
| | |
Somehow one use of JSON escaped the global find and replace of PSON --> JSON.
|
| | |
|
| |
| |
| |
| |
| | |
A spec was failing because it didn't know where to put a temporary
sqlite database file
|
| |
| |
| |
| |
| | |
Puppet::Util::Storage was trying to create state.yaml during an
unrelated spec.
|
| |
| |
| |
| |
| | |
Puppet::Util::Storage was trying to create state.yaml during unrelated
specs.
|
| |
| |
| |
| |
| | |
Puppet::Util::Storage was trying to create state.yaml during unrelated
specs.
|
| |
| |
| |
| |
| | |
Puppet::Util::Storage was trying to create state.yaml during unrelated
specs.
|
| |
| |
| |
| |
| | |
Puppet::Util::Storage was trying to create state.yaml during unrelated
specs.
|
| |
| |
| |
| |
| | |
Our settings were slow because I was querying Application objects for
their run_mode repetitively
|
| |
| |
| |
| |
| | |
Puppet::Util::Storage was trying to create state.yaml during unrelated
specs.
|
| |
| |
| |
| |
| | |
Specs in settings were allowing the settings-as-catalog to escape onto
the system.
|
| |
| |
| |
| |
| | |
Previously, spec_helper's attempts to set :confdir, and :vardir to
/dev/null were getting thwarted by the Settings.clear in after_all
|
| |
| |
| |
| |
| |
| | |
This test in agent_spec.rb was no longer testing any of
Puppet::Application::Agent, but rather exercising Util::Settings in a
naive way. Deleted.
|
| |
| |
| |
| |
| |
| | |
Added a C-style if-defined? guard to spec_helper.rb to make sure that it
only gets evaluated once. (The file is getting loaded multiple times
because ruby gets confused by relative paths in `require` statements)
|
| |
| |
| |
| |
| |
| | |
Added a Puppet::Util::Settings layer called :mutable_defaults to emulate
the interaction between Puppet::Application and defaults.rb that was
getting thwarted by rspec.
|
| |
| |
| |
| |
| |
| |
| | |
assert their run_mode
Also cleanup of an unecessary puts line, make master tests run when
on their own, and moving a require to a more usual spot.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Previously, any failed call to Puppet::Application.find would result
in an error being raised by const_get, resulting in a messy crash with
a stack trace. Now that error is handled, and the application will
print a message and exit.
|
| |
| |
| |
| |
| |
| | |
Notify was returning a nil current value, rather than :absent,
which caused puppet to think the message had been changed from
blank to its new value, rather than defined as that value.
|
| |
| |
| |
| |
| | |
The describe and resource (ralsh) applications required puppet, creating a
loop & thus crashing them.
|
| |
| |
| |
| |
| |
| |
| | |
RunMode is only created once instead of every time it's called
Got lots of unpredictable test failures, presumably because a new
RunMode was being created every time we accessed the RunMode.
|
| | |
|
| |
| |
| |
| |
| | |
Along the way this fixes an issue with 2.6 alpha that sections of the
puppet config file were getting ignored.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Mode is a terribly overused word. Files use it, puppetdoc uses it, and
certs use it, and those are just the places that I happened to
stumble upon. It makes reading code very confusing and finding things
in code difficult. I know namespacing allows us to reuse words for
method and variable names, but that doesn't mean we should.
|
| |
| |
| |
| |
| |
| | |
Per Luke's replacement of :check with :audit, and deprecation of :check,
I've replaced all of our internal uses of :check with :audit. Importantly,
this silence the deprecation warnings during regular usage from eg. ralsh.
|
| | |
|
| | |
|
| |
| |
| |
| | |
I'm also going to update the wiki to mention sqlite is a test dependency
|
| |
| |
| |
| | |
Part 2 re-did the change on the spec files, which it shouldn't have.
|
| |
| |
| |
| |
| | |
The spec/unit/provider/ssh_authorized_key/parsed_spec_spec.rb was trying to
use Dir.tempdir but getting ours.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Some spec files like active_record.rb had names that would confuse the
load path and get loaded instead of the intended implentation when the
spec was run from the same directory as the file.
Author: Matt Robinson <matt@puppetlabs.com>
Date: Fri Jun 11 15:29:33 2010 -0700
|
|\ \ |
|
| |\ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Commit ae520057280c2454bc44c64ac1e6686bf2eb086d introduced some code
that used 'asuser' which does nothing when not run as root, but in these
tests tries to run as a non-existent user. Stubbing out the asuser
method to just yield prevents test failures when running as root.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
There were a bunch of "warning: parenthesize argument(s) for future version"
messages; now there aren't.
|
| |/ /
| | |
| | |
| | |
| | | |
This change removes some irrelevant output (debugging information,
warnings, etc) from a few specs.
|
|/ /
| |
| |
| |
| |
| | |
when run as root, which caused the test to fail. Changing the test so
that a directory is in place of the writeable file so not even root can
write to it.
|
| |
| |
| |
| | |
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
We were looking only to the class hierarchies when trying to find an
ancestor to the current type. Thus we were never trying to climb up
the hierarchy of nodes when evaluating nodes.
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|