summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | | | | | | | | | | Merge branch 'maint/master/fix-order-dependent-spec-failures'Nick Lewis2011-03-222-6/+11
| | |\ \ \ \ \ \ \ \ \ \ \ | | | |/ / / / / / / / / / | | |/| | | | | | | | | |
| | | * | | | | | | | | | maint: Fix order-dependent spec failuresNick Lewis2011-03-222-6/+11
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The specs for InterfaceCollection were clearing the list of interfaces at the end of the spec run, which caused later specs to fail because they couldn't re-require interfaces they needed. This fixes the InterfaceCollection specs to save and restore the interfaces at the end of the file. Reviewed-By: Matt Robinson
| | * | | | | | | | | | Merge branch 'maint/master/always-use-interface-method'Nick Lewis2011-03-2234-340/+229
| | |\ \ \ \ \ \ \ \ \ \
| | | * | | | | | | | | | maint: Implement an InterfaceCollection class to manage interfacesNick Lewis2011-03-2234-340/+229
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having an instance variable on class Interface is insufficient for Interface::Indirector. This also changes the semantics of "Interface.interface" to handle registration and loading actions, and for "Interface.new" to only instantiate an Interface. Thus, consumers of the API should typically use "Interface.interface", unless they have reasons to not want an interface automatically registered. Paired-With: Pieter van de Bruggen
| | * | | | | | | | | | Merge branch 'ticket/master/6814'Nick Lewis2011-03-221-0/+1
| | |\ \ \ \ \ \ \ \ \ \
| | | * | | | | | | | | | (#6814) Add missing require for specsNick Lewis2011-03-221-0/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | Merge branch 'maint/master/make-catalog-select-args-explicit'Nick Lewis2011-03-222-9/+9
| | |\ \ \ \ \ \ \ \ \ \ \
| | | * | | | | | | | | | | maint: Make args to Catalog.select explicitNick Lewis2011-03-222-9/+9
| | |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No other args are used, so passing *args and shifting is unnecessary.
| | * | | | | | | | | | | Merge branch 'ticket/master/6814'Nick Lewis2011-03-2213-108/+323
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: lib/puppet/interface/catalog.rb lib/puppet/interface/catalog/select.rb lib/puppet/interface/configurer.rb
| | | * | | | | | | | | | (#6814) Create a dedicated Action classNick Lewis2011-03-2213-108/+323
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This class will represents an action, and allows us to store metadata for an action, and programmatically introspect and invoke them. A helper class ActionBuilder represents the DSL for defining an action. Also defined an "invoke" DSL method to handle the functionality of defining the method for an action. Reviewed-By: Daniel Pittman
| | * | | | | | | | | | | Merge branch 'tickets/master/6786'Pieter van de Bruggen2011-03-2220-82/+72
| | |\ \ \ \ \ \ \ \ \ \ \ | | | |/ / / / / / / / / / | | |/| | | | | | | | | |
| | | * | | | | | | | | | (#6786) Change interface storage and access.Pieter van de Bruggen2011-03-2220-82/+72
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby's namespace mechanism introduced a number of problems, including incorrect name resolution for common and simple cases. Given that, we've refactored back to class-level data structures with accessor methods available. The current method names are unlikely to be the final UI. Reviewed-By: Daniel Pittman
| | * | | | | | | | | | Merge branch 'tickets/master/maint'Pieter van de Bruggen2011-03-213-28/+0
| | |\ \ \ \ \ \ \ \ \ \
| | | * | | | | | | | | | (Maint.) Remove Puppet::Interface#unload_interfacePieter van de Bruggen2011-03-213-28/+0
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reviewed-By: Nick Lewis
| | * | | | | | | | | | Merge branch 'ticket/master/6805'Nick Lewis2011-03-218-0/+155
| | |\ \ \ \ \ \ \ \ \ \
| | | * | | | | | | | | | (#6805) Add a "configurer" applicationNick Lewis2011-03-218-0/+155
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This application is similar in basic functionality to the "agent" application, but implemented in terms of interfaces. It currently will retrieve facts, retrieve a catalog, apply the catalog, and submit a report. Options such as noop and daemonize are still to come. Reviewed-By: Pieter van de Bruggen
| | * | | | | | | | | | Fixing a load-order issue in Puppet::InterfaceLuke Kanies2011-03-212-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The application classes were having issues loading the Interface class in certain circumstances because of load order. This just pushes the loading as late as possible. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Merge branch ↵Daniel Pittman2011-03-212-5/+32
| | |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'bug/master/6806-improve-error-checking-and-testing-of-interface-naming'
| | | * | | | | | | | | | (#6806) Improve error checking and reporting for interface naming.Daniel Pittman2011-03-212-5/+32
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We didn't do enough input checking and sanitization, and missed some edge-cases for naming interfaces. This adds testing, and cleans up some edge cases to handle things better. Reviewed-By: Pieter van de Bruggen <pieter@puppetlabs.com>
| | * | | | | | | | | | Merge branch 'tickets/master/6785'Pieter van de Bruggen2011-03-211-3/+3
| | |\ \ \ \ \ \ \ \ \ \
| | | * | | | | | | | | | (#6785) Internal consistency for `--terminus`.Pieter van de Bruggen2011-03-211-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Paired-With: Richard Crowley
| | | * | | | | | | | | | Merge branch 'master' into tickets/master/6785Pieter van de Bruggen2011-03-2114-29/+34
| | | |\ \ \ \ \ \ \ \ \ \ | | | |/ / / / / / / / / / | | |/| | | | | | | | | |
| | * | | | | | | | | | | Merge branch 'tickets/master/6786'Pieter van de Bruggen2011-03-2114-29/+34
| | |\ \ \ \ \ \ \ \ \ \ \
| | | * | | | | | | | | | | (#6786) Fixing a number of failing tests.Pieter van de Bruggen2011-03-2115-30/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The initial merge of this branch hadn't actually been run against the full suite of specs; a number of specs began failing shortly afterward. Reviewed-By: Daniel Pittman
| | * | | | | | | | | | | | Merge branch 'tickets/master/6785'Pieter van de Bruggen2011-03-212-5/+5
| | |\ \ \ \ \ \ \ \ \ \ \ \ | | | | |/ / / / / / / / / / | | | |/| | | | | | | | | |
| | | * | | | | | | | | | | (#6785) Rename the --from option to --terminus.Pieter van de Bruggen2011-03-212-5/+5
| | |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Paired-With: Richard Crowley
| | * | | | | | | | | | | Merge branch 'tickets/master/6786'Pieter van de Bruggen2011-03-212-33/+18
| | |\| | | | | | | | | |
| | | * | | | | | | | | | (#6786) Removing the #interface method.Pieter van de Bruggen2011-03-212-33/+18
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since constants are already being defined for each interface, the #interface method does little but provide another way to access the same data. Reviewed-By: Nick Lewis
| | * | | | | | | | | | Modifying Facts.upload a bitLuke Kanies2011-03-021-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The functionality is basically the same, but we're no longer using caching, and we log that it happened. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Fixing #16 - nodes default to yamlLuke Kanies2011-03-022-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't have json support for node output yet. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Fixing #13 - showconfig moved to indirectorLuke Kanies2011-03-024-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I renamed it to 'info', too. It only showed indirector-related info, so this makes sense. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Adding a test for fix to #14Luke Kanies2011-03-022-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | (14) updated interface_base to support multiple command line argumentsDan Bode2011-03-011-1/+2
| | | | | | | | | | | |
| | * | | | | | | | | | Pretty-printing json using "jj"Luke Kanies2011-02-271-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Attempting to skip loading of duplicate actionsLuke Kanies2011-02-241-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Fixing plugin usageLuke Kanies2011-02-243-7/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I had broken some usages of plugins by incorrectly selecting command-line arguments. The fix was to remove the #main method contained in the IndirectionBase subclass. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Adding Application options to InterfacesLuke Kanies2011-02-234-16/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows all of the actions to react to the CLI options. I've also removed the unnecessary 'name' variables I was using in various places - they were just the first of the arguments, and they weren't actually always names. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Adding render and exit_code override supportLuke Kanies2011-02-222-3/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is mostly in response to feature requests from Dan. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Fixing 'puppet interface list'Luke Kanies2011-02-224-43/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also added a test to hopefully confirm it won't break again. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Adding a simple "config" appLuke Kanies2011-02-224-0/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Splitting the Application base classLuke Kanies2011-02-2229-58/+313
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We now have an indirection_base class along with interface_base. I've also added some basic tests for most of the interfaces. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Adding a string form to interfacesLuke Kanies2011-02-222-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Switching Interfaces to be instancesLuke Kanies2011-02-2227-103/+617
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They were previously classes, which made a lot of things stupider than they needed to be. This will likely involve some porting, but not much. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Renaming 'data_baseclass' to 'interface_base'Luke Kanies2011-02-2213-25/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Fixing indentationLuke Kanies2011-02-211-47/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Updating readme to reflect requirementsLuke Kanies2011-02-211-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | Fixing Interface listingLuke Kanies2011-02-203-10/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It got broke when the Indirector base class was extracted. Signed-off-by: Luke Kanies <luke@puppetlabs.com>
| | * | | | | | | | | | (#3) Base application should catch SYSINTDan Bode2011-02-201-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should exit cleanly rather than throw traces.
| | * | | | | | | | | | (#2) Should not assume interfaces have indirectorsDan Bode2011-02-2015-92/+109
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The initial work assumed that all interfaces were just skins on an indirected data type, but some interfaces will be more abstract than that. This commit removes that assumption by extracting all of the indirector work into a new Indirector subclass of Interface and then makes all of the new interfaces a subclass of that rather than of Interface itself.
| | * | | | | | | | | | Only printing output if there is anyLuke Kanies2011-02-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Luke Kanies <luke@puppetlabs.com>