summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Removed misguided case sensitivity testsMarkus Roberts2009-08-182-19/+0
| | | | | | | | Removed two failing tests added in the process of reproducing #2493 because they enforced case-insensitivity in excess of that provided by 0.24.8 and thus contrary to user expectations. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixes #2513. debian service provider now uses invoke-rc.d to determine ↵Nigel Kersten2009-08-182-11/+108
| | | | enabled? status
* Fixing fact-missing problem when puppet.conf is reparsedLuke Kanies2009-08-182-0/+20
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fix for #2531; adds tests to confirm problem and related cases,Markus Roberts2009-08-182-1/+97
| | | | | | | notes fixes specific issue by eliminating the specal case for opaque strings which caused them to be strings when everything else was arrays; adds nots and pending tests where FQDN support could be added but stops short of a full refactor.
* Fixed #2530 - Fixed status setting in the SMF providerJames Turnbull2009-08-151-1/+1
|
* Fixed spec typoJames Turnbull2009-08-151-1/+1
|
* Fixes #2493Markus Roberts2009-08-146-44/+128
| | | | | | | | | | | | Added downcasing into find_or_load (which replaced fqfind) to get back the old behaviour. Adjusted tests so that they would catch the problem & confirmed that they fail without the downcasing. Added tests to confirm the existance of #2493; improved existing autoload tests (removed inter-test interactions) and noted (with a TODO) that there was dead code in the feature loading test; added analogus case sensitivity tests where apropriate.
* conf/redhat/*.init: Fix condrestart/try-restartTodd Zullinger2009-08-132-4/+14
| | | | | | | | | | | Previously, the Red Hat init scripts used the $pidfile or $lockfile as a test for whether to restart the daemons. This caused condrestart to start the daemons even when they were not running, in cases where they had died or been killed without cleaning up the $pidfile/$lockfile. This was reported by Ingvar Hagelund in Red Hat bug #480600. Signed-off-by: Todd Zullinger <tmz@pobox.com>
* conf/redhat/client.init: Fix #2123, status options on older RHELTodd Zullinger2009-08-131-2/+6
| | | | | | | | On RHEL < 5, the status function does not accept a -p option. Using it causes 'service puppet status' to produce erroneous output. This was also reported by Aaron Dummer in Red Hat bug #501577. Signed-off-by: Todd Zullinger <tmz@pobox.com>
* Updates to Solaris smf files to reflect new binary locationsJames Turnbull2009-08-132-3/+3
|
* Fix #2517 - Stack overflow when CA cert missingMarkus Roberts2009-08-132-8/+13
| | | | | | | | | | | | | | This was a "There's A Hole In The Bucket" problem caused when trying to establish a connection to get a certificate before there was a certificate with which to establish the connection, ad infinitum. The solution was to test for the presence of the CA cert as well as the host cert before attempting to use them. This patch modifies existing tests to pass with the new code (by stubbing out the additional FileTests) and adds a new test which catches the original problem. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fix #2516 - Fix format detection when content-type contains charsetBrice Figureau2009-08-136-3/+34
| | | | | | | | | | | | | | | | | | Even though Puppet never transmist a charset information in its response/request content-type, some proxy (especially Apache with the infamous AddDefaultCharset configuration) may add this "incorrect" information. This patch makes sure that only the mime-type is used when looking for the format associated with a response or a request. The patch also provides a better error message when the client or server code is fed with a request whose mime-type can not be mapped to a known format. It also fixes a typo noticed by the original reporter. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix #2507 - Add missing integration testsBrice Figureau2009-08-132-4/+65
| | | | | | | | Some of the integration tests were either missing or not complete, especially tests about exported non virtual resources or virtual and exported resources. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix #2507 - Exported resources were not correctly collected.Brice Figureau2009-08-1312-19/+46
| | | | | | | | | | | | | | | | | | | | | | #2507 contains two issues: * a crash when we filters-out an unwanted resource which had edges pointing to it. * resources are losing their virtuality when they are transformed from Puppet::Parser::Resource to Puppet::Resource. This means we weren't able to distinguish anymore between an exported resource collected in the same node as it was exported and an exported resource collected in another node. The net result is that we can't apply exported resources that are collected in the same node because they are filtered out by the catalog filter (see the commits for #2391 for more information). The fix is to keep the virtuality of the resources so that we can differentiate those two types of exported resources. We keep this until the catalog is ready to be sent, where we filter out the virtual resouces only, the other still exported ones needs to be sent to the client. To be real sure, the transaction also skips virtual resources. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fixes #2503Markus Roberts2009-08-131-2/+8
| | | | | | | | | | | Added a random suffex to the temporary file name and verify that the name is not in use (retry on collison). No additional tests added as the lifetime of the temporary file is bound by the routine, making spec driven tests impraticable. Includes logic to account for dead-end symlinks as well, as per Luke. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixes #2360 - Removed annoying log messageAndrew Shafer2009-08-132-9/+15
| | | | | | This change will effect all the properties implemented with list.rb (groups, roles, auths, profiles). The change will match [] values for should as insync when none exist. (so no more log message)
* Fixed #2525 - Wrong method being overridden in Red Hat servicesJames Turnbull2009-08-111-1/+1
|
* Fixing more tests broken from missing librariesLuke Kanies2009-08-106-15/+31
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing ActiveRecord Indirector tests to skip w/out RailsLuke Kanies2009-08-104-6/+9
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2489 - queue integration tests are skipped w/out jsonLuke Kanies2009-08-102-3/+4
| | | | | | | | | All of the tests were failing because we had a call outside of any of the tests, just to autoload the constant. Removed that call and stubbed things so the tests don't run without json. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2508 - removing mention of ActiveRecord 2.3Luke Kanies2009-08-101-1/+1
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2541 - file cache is more resilient to failureLuke Kanies2009-08-102-8/+42
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* vim: Mark puppetFunction values as containedTodd Zullinger2009-08-091-1/+1
| | | | | | | This prevents 'file' from being highlighted as a function when it is used as a resource. Signed-off-by: Todd Zullinger <tmz@pobox.com>
* Add shellquote() function.Thomas Bellman2009-08-082-0/+133
| | | | | | | | | | This adds a new function shellquote() which can be used for quoting arguments in shell commands used in the exec type. This only supports Unixoid operating systems. Other systems would likely require some other quoting. Signed-off-by: Thomas Bellman <bellman@nsc.liu.se>
* Fixes #2499. Allows execs to specify an array for the returns parameterNigel Kersten2009-08-082-8/+21
|
* Updated fix for #2481James Turnbull2009-08-051-3/+5
|
* Revert "Fxied #2481 - Added status and restart overrides for Red Hat service ↵James Turnbull2009-08-051-4/+4
| | | | | | provider." This reverts commit 967eb9f52938d8849b99686bf2c0b9da9a183399.
* Fixed #2498 - logcheck updateJames Turnbull2009-08-051-1/+1
|
* Removed extraneous debuggingroot2009-08-041-4/+0
|
* Updated two more testsJames Turnbull2009-08-042-0/+5
|
* Logs now assume resource params have metadataLuke Kanies2009-08-032-8/+1
| | | | | | | | | | | We were previously not assuming they had it, because I figured there were just a couple that didn't. On closer inspection, none of them did. The previous commit fixed that, so this commit fixes the assumption. Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding metadata delegation from param to resourceLuke Kanies2009-08-034-19/+34
| | | | | | | | | | This is for file, line, version, and tags, with the parameter name added to the tags. This is mostly so logs generated by the parameters work better. Signed-off-by: Luke Kanies <luke@madstop.com>
* Removing unnecessary debug outputLuke Kanies2009-08-031-1/+0
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding integration tests for #2371 (backup refactor)Luke Kanies2009-08-032-119/+106
| | | | | | Also removed old conflicting file tests. Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding many tests for #2371, and slightly refactoringLuke Kanies2009-08-032-47/+139
| | | | | | | | This mostly focuses on adding all of the detailed tests for this new code, but it also cleans the code up just a little bit. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixes for Redmine 2371.Steven Jenkins2009-08-033-125/+157
| | | | | | | | | | | This changes the condition checking of handlebucket, as well as moves it (and remove_backup) into a separate module. It additionally refactors common code out of handlebucket into separate private methods. Some new RSpec tests which use mock and stubs are added as well, including removing the old test/ral/type/filebucket.rb tests since they are already covered by RSpec tests.
* Fixes #2464, #2457. Deprecate reportserver for report_server. Add ↵Nigel Kersten2009-08-044-3/+64
| | | | report_port setting. Add tests.
* Fixing #2484 - "format missing" messages are betterLuke Kanies2009-08-041-2/+2
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixes #2483 - Log only copies metadata from RAL objectsLuke Kanies2009-08-042-16/+36
| | | | | | | | | | | | | | | | | | | We were previously trying to figure out what data was available based on what methods existed, but that caught a different method profile from modules. This fixes it so we only look for this data from Puppet::Type or Puppet::Parameter instances. I had to add the ability to skip data that's not available, since File's 'ensure' parameter doesn't have 'file' data, I assume because of the metaprogramming we do around the 'file' value for 'ensure'. It's a workaround for now, and there's a test in there to verify it, anyway. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixed #2486 - Missing require 'monitor' in parser_support.rbJames Turnbull2009-08-041-0/+1
|
* Added R.I.Pienaar's extlookup.rb to the ext directoryJames Turnbull2009-08-031-0/+183
|
* Added example conf/puppet-queue.confJames Turnbull2009-08-031-0/+10
|
* Fxied #2481 - Added status and restart overrides for Red Hat service provider.James Turnbull2009-08-031-4/+4
|
* rack: SSL Env vars can be in Request.env or ENVChristian Hofstaedtler2009-08-034-12/+33
| | | | | | | Fix #2386, by checking either Request.env or ENV for the SSL environment variables. This is necessary as Passenger 2.2.3 changed the location of these vars, even though the Rack spec says nothing about ENV or these variables.
* rack: don't directly use the forbidden HTTP_CONTENT_TYPE env var (fixes rack ↵Christian Hofstaedtler2009-08-032-3/+3
| | | | specification conformance)
* Removing old filebucket testLuke Kanies2009-08-031-110/+0
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Cleaning up tests for #2469Luke Kanies2009-08-032-43/+70
| | | | | | | This is a small refactor of the filebucket type, and a larger refactor of the tests. Signed-off-by: Luke Kanies <luke@madstop.com>
* default server in remote filebucketsTill Maas2009-08-033-23/+62
| | | | | | | | | | | | With the path parameter set to false, the server defaults to Puppet[:server]. This allows to use a remote filebucket without syncing the servername there with the one used on the config file. To use the default server, this manifest can be used: filebucket { main: path => false } A related bug report is: http://projects.reductivelabs.com/issues/2456
* Fixes #2444 - Various JSON test failuresMarkus Roberts2009-08-031-3/+17
|
* Fixed #2294 - Classes sometimes cannot be foundMarkus Roberts2009-08-032-53/+134
| | | | | | | | | | | | | | | | | | | | | | | | This patch should fix the race condition causing ticket 2294; it extends the loading logic so that: * initial load attempts are processed (as before), * recursive load attempts return immediately (as before), * but subsequent concurrent load attempts from different threads wait on a semaphore (condition variable) and then retry (e.g. use the now-valid results of the first thread). This is a slight modification of the solution I'd originally proposed, to prevent a deadlock that could have arisen if three or more threads simultaneously attempted to load the same item. Though it solves the bug as reported, it has room for improvement: * Failures aren't cached, so repeated attempts will be made to import invalid items each time they are encountered * It doesn't address any of the underlying referential ambiguity (module vs. filename) * The threading logic should probably be refactored into a separate class (as a start I encapsulated it in an ad hoc singleton class, so at least it isn't cluttering up the load method) Signed-off-by: Markus Roberts <Markus@reality.com>
generated by cgit (git 2.34.1) at 2025-09-25 14:29:28 +0000