summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * A slide down the RFC-1123 slope towards MS Windows compatibility and chaosMarkus Roberts2009-12-222-5/+6
| |
| * Fixing #2960 Test Failed: 'Puppet::Type::Mount::ProviderParsed when ↵Jesse Wolfe2009-12-221-1/+3
| | | | | | | | | | | | | | | | | | | | modifying the filesystem tab should write the mount to disk when :flush is called I found this doing idempotency tests (#2879), but there are apparently other ways for external state to leak into this test, as reported by James. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fixing testsMarkus Roberts2009-12-221-30/+11
| | | | | | | | Signed-off-by: Markus Roberts <Markus@reality.com>
| * Fix for #2943 (Make puppet --apply respect --preferred_serialization_format)Markus Roberts2009-12-211-1/+1
| | | | | | | | Signed-off-by: Markus Roberts <Markus@reality.com>
| * Fix #2970 spec/unit/provider/ssh_authorized_key/parsed.rb has order dependenciesJesse Wolfe2009-12-201-1/+3
| | | | | | | | | | | | | | | | Some tests in this file were leaking a global setting, some other tests depended on those changes, and some tests were incompatible with that setting. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fix #2816 MySQL server has gone awayJesse Wolfe2009-12-202-4/+7
| | | | | | | | | | | | As suggested in the ticket, set :reconnect to true. Our in-house Rails experts suggest that this is unlikely to cause any problems. The setting is silently ignored before Rails 2.3
| * Fix for #2813 (alias propety v. alias metapram)Markus Roberts2009-12-203-19/+17
| | | | | | | | | | | | | | Renamed :alias property to :host_aliases / :port_aliases (in the sidelined port code) and corrected the comments. Signed-off-by: Markus Roberts <Markus@reality.com>
| * Fix for #2765 (--no-fqdn regression in puppetrun)Markus Roberts2009-12-204-13/+40
| | | | | | | | | | | | | | | | | | This is basically the fix suggested on the ticket, cleaned up and ruby-ized, with tests. The only functional modification is leaving the default on entry2hash as --no-fqdn to preserve 0.25.1 behaviour as the default. Signed- ff-by: Markus Roberts <Markus@reality.com>
| * Fix for #2657 (retain old setting if config has syntax error)Markus Roberts2009-12-202-25/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This appears to be regression introduced by threading changes. The fix was to rearrange things to keep the old behaviour (don't clear the settings until you know the config file parses) and the new (don't nest calls to synchronize) by: 1. Splitting clear into two parts--clear, which works as before, and unsafe_clear which it calls and which expects synchronization to be handled externally. 2. Rearranging the code to recover the previous calling order 3. Trapping syntax errors and turning them into logged messages and a no-op effect. 4. Fixing reparse to not wrap a call to this code with a synchronize. 5. Tests. Signed-off-by: Markus Roberts <Markus@reality.com>
| * Fix #2966 spec/unit/util/queue.rb can't be run twiceJesse Wolfe2009-12-201-2/+10
| | | | | | | | | | | | | | | | This spec wasn't cleaing up after itself, and raised several exceptions when trying to register the same queue type again. Part of the #2879 test idempotency suite. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fixing #2963 spec/unit/util/autoload.rb depends on global stateJesse Wolfe2009-12-201-0/+2
| | | | | | | | | | | | | | An Autoload spec was depending on files having not yet been autoloaded. Detected as part of #2879. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fix for #2965 (Chatty SELinux message)Markus Roberts2009-12-201-1/+1
| |
| * Fixed RSpec deprecation errorJames Turnbull2009-12-191-1/+1
| |
| * Fixing #2958 inconsistent errors in spec/integration/bin/puppetmasterd.rbJesse Wolfe2009-12-191-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was getting inconsistent errors in this file, and it's really two separate issues but they're both trivial. 1) The spec launches ./sbin/puppetmasterd, which may have trouble finding the puppet libraries. It could even load the system-installed puppet rather than the files in the repository -- I think this effect is why the tests were passing on Markus's machine, for example. 2) There's a race condition in this test, and puppetmasterd has gotten slower to start up (perhaps due to the #2877 fix?) Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fix for #2951 (SELinux test errors on OS X)Markus Roberts2009-12-182-4/+21
| | | | | | | | | | | | | | | | | | This makes the SELinux library marginally more robust by dealing consistently with a missing proc/mounts, and also resoves the test failures in a way that allows meaningful test runs on non-SELinux systems. Signed-off-by: Markus Roberts <Markus@reality.com>
| * Fix for #2890 (the cached certificates that would not die)Markus Roberts2009-12-198-135/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch implements the two-part suggestion from the ticket; 1) a client that receives a certificate that doesn't match its current private key does not accept, store or use the certificate--instead it removes any locally cached copies and acts as if the certificate had never been found. 2) a puppetmaster that receives a csr from a client for whom it already has a signed certificate now honors the request and considers it to supercede any previously signed certificates. In order to make the cache expiration work as expected, I changed a few assumptions in the caching system: * The expiration of a cached certificate is the earlier of the envelope expiration and the certificate's expiration, as opposed to just overriding the cache value * Telling the cache to expire an item now removes it from the cache if possible, rather than just setting an expiration date in the past and hoping that somebody notices. Signed-off-by: Markus Roberts <Markus@reality.com>
| * Fix for #2950 (parens needed warning)Markus Roberts2009-12-171-1/+1
| |
| * Fix #2924 Test Failed: Puppet::Indirector::FileContent::FileServer when ↵Jesse Wolfe2009-12-181-1/+2
| | | | | | | | | | | | | | | | | | finding files should find plugin file content in the environment specified in the request The change in #2590 (ea584787) clears the environment list that this spec relies on. Reordered the spec so that doesn't happen anymore. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fixed test typoJames Turnbull2009-12-181-1/+1
| |
| * Closed #2937 - Migrated a number of requires to featuresJames Turnbull2009-12-185-22/+11
| |
| * Fix for #2869 (SELinux tests failing under some load orderings)Markus Roberts2009-12-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem was that the setup for the tests was expecting the defaultprovider for Selboolean and Selmodule to be called, rather than stubbing it. This worked as long as no other spec which initializes the providers was run before it. The fix here (stubbing rather than expecting) is minimal but not ideal; if there were some other provider for these types it could result in a test indetermenacy (different results depending on which provider) but I'm not seeing an easy way to address that. Signed-off-by: Markus Roberts <Markus@reality.com>
| * Adds partial IPv6 support to authstoreMarkus Roberts2009-12-182-5/+186
| | | | | | | | | | | | | | | | This removes some of the IPv4 centricism from authstore's handling of IP addresses. It isn't full IPv6 support (and doesn't even fully handle all the cases within its limited scope, as ruby's IPAddr library does not work with hybrid addresses), but it should simplify adding IPv6 support when the time comes.
| * Fix for #2567 (Authstore does unintended/pointless DNS lookups)Markus Roberts2009-12-181-5/+0
| | | | | | | | | | This patch fixes #2567 by always pre-validating IP addresses with a strict regular expression check before calling IPAddr.new() on them.
| * Enabling steps for #2567 (Authstore does unintended/pointless DNS lookups)Markus Roberts2009-12-181-117/+46
| | | | | | | | | | | | | | | | | | | | This commit refactors the code in authstore to enable a fix for #2567, goes part of the way towards fixing #2708 (DNS/reverse DNS dependence), and is a start on #2623 (authstore needs to be refactored), though it stops short of fully addressing some of the more egregious structural issues ("opaque", ill-placed pattern transformations, etc.). Signed-off-by: Markus Roberts <Markus@reality.com>
| * Fix 2948 Failing rests in spec/unit/rails.rbJesse Wolfe2009-12-181-4/+4
| | | | | | | | | | | | Specs didn't reflect some recent changes. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fix #2923 failing tests in spec/unit/ssl/host.rbJesse Wolfe2009-12-171-2/+2
| | | | | | | | | | | | | | The fix for #2661 changed the behavior of Puppet::SSL::Host enough to confuse these mocks. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fix #2677 Proper OIDs on puppet.schema for LDAPJesse Wolfe2009-12-171-9/+5
| | | | | | | | We've got a real OID for LDAP, now.
| * Fix #2808 puppetqd doesn't give an error when no config is givenJesse Wolfe2009-12-171-2/+4
| | | | | | | | | | | | | | | | | | | | Added an info message about what database we're connecting to. In the case of the default database, it looks like: info: Connecting to sqlite3 database: /var/lib/puppet/state/clientconfigs.sqlite3 Also squashes the deprecation warning #2941, since fixing that makes this patch smaller.
| * Fixing 2851 spec/unit/network/rest_authconfig.rb test descriptions changeJesse Wolfe2009-12-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Some test names change arbitrarily since they were interpolating hashes instead of strings. This patch replaces, for example: - should insert methodfindacl/certificate_revocation_list/caauthenticatedtrue if not present with: - should insert /certificate_revocation_list/ca if not present Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fixing 2855 Inadvertent zlib dependencyJesse Wolfe2009-12-166-9/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | Disables the b64_zlib_yaml format if zlib cannot be loaded. I've added a --no-zlib to make it possible to test this on a single machine, but it might also be useful if someone finds themselves failing to connect to a server that doesn't have zlib installed. FactHandler' format is still hard-coded to YAML rather than using facts.class.default_format Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * 2850 spec/unit/application/puppetd.rb generates warnings if run with certain ↵Jesse Wolfe2009-12-161-0/+1
| | | | | | | | | | | | | | | | | | | | other tests Puppet[:libdir] is nil due to stubbing, causing an exception in autoload. Depending on the order of loaded libs, sometimes this exception is logged using Kernel#warn, but sometimes it's logged using Puppet.err Only Kernel#warn writes to the terminal during unit testing!
| * 2876 spec/unit/indirector/catalog/compiler.rb changes behaviourJesse Wolfe2009-12-161-1/+2
| | | | | | | | | | | | | | 1) Improve test so it doesn't fail if an autoload happens. 2) Improve test so it doesn't show a warning. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fix 2936 Insufficient mocks for webrick in spec/unit/network/http/webrick.rbJesse Wolfe2009-12-151-2/+2
| | | | | | | | | | Fixing #2877 introduced some spec failures, by using more of the webrick API than was mocked here.
| * Fix for #887 (safely setting pager to cat for blastwave)Markus Roberts2009-12-151-6/+7
| | | | | | | | This is Luke's suggested fix, from the ticket.
| * 2633 file and line info on bad params in type/fileJesse Wolfe2009-12-151-2/+2
| |
| * Fix for #2817 (links created even when links property set to follow)Markus Roberts2009-12-153-40/+21
| | | | | | | | | | | | | | | | | | Commit 82714246b913087292f04190e03a885c99723f52 lost the distinction between links that were being followed and links that were being managed. This reinstated the distinction and (taking Luke up on his offer) also includes various cleanups. Signed-off-by: Markus Roberts <Markus@reality.com>
| * 2875 spurious test failure in spec/integration/file_serving/content.rbJesse Wolfe2009-12-151-1/+1
| | | | | | | | | | | | Any test calling it_should_behave_like "Puppet::FileServing::Files" potentially was affected by this bug, as its stubbing was not sufficient if anything needs to be autoloaded.
| * 2877 race condition in webrickJesse Wolfe2009-12-151-1/+2
| | | | | | | | | | | | | | Make sure that we don't try to do anything to webrick until it has really started. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fix for #2921 (test not checking for what it really wanted)Markus Roberts2009-12-151-1/+1
| |
| * Fix for #2925 (accept higher versions of rspec)Markus Roberts2009-12-131-1/+1
| | | | | | | | | | | | What's there to say? Signed-off-by: Markus Roberts <Markus@reality.com>
| * Fix for #2911 (Allow capital letters in selinux contexts)Markus Roberts2009-12-121-1/+1
| | | | | | | | | | This is Matthias Saou's patch from the ticket; it adjusts the regular expression to permit capital letters where needed.
| * Fix for #2900 (rug output parsing too specific)Markus Roberts2009-12-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Andrew Forgue's suggested patch; changes the regular expression to accept any non-space characters, non-vertical bar characters in a version "number". Examples v | SLES10-SP1-Updates | | resmgr | 0.9.8_SVNr75-18.9 | x86_64 v | SLES10-SP1-Updates | | wireless-tools | 28pre13-22.16.2 | x86_64 Signed-off-by: Markus Roberts <Markus@reality.com>
| * Fix for #2786 (failed trying to backup directory in recursive purge)Markus Roberts2009-12-111-1/+2
| | | | | | | | | | | | The refactoring in 8f60f0c50ee3dfb6453644f5dcded58e6e80e8bb lost the return code--should be true in all non-exception cases--and this was causing a false failure when the result was checked higher up.
| * Fixing 2907 rspec crash when spec/unit/application/puppetrun.rb is run after ↵Jesse Wolfe2009-12-111-1/+1
| | | | | | | | | | | | | | | | | | spec/unit/util/ldap/connection.rb the ldap/connection spec creates a mock LDAP class that causes `require 'ldap'` to explode. If `require 'ldap'` happens first, then we're OK. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fixing 2870 Spurious failures in spec/integration/ssl/certificate_request.rbJesse Wolfe2009-12-111-0/+2
| | | | | | | | | | | | There's a dependency on Puppet::SSL::Host.ca_location Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fixing 2862 spec/integration/file_serving/metadata.rb fails unless run with ↵Jesse Wolfe2009-12-111-0/+1
| | | | | | | | | | | | | | | | | | other tests Due to some heavy mocking, this code was failing to load a dependency. If the `require` happens earlier, then the test passes. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Fixing 2858 spec/unit/application/puppetmasterd.rb fails if run twiceJesse Wolfe2009-12-101-0/+1
| | | | | | | | | | | | @puppetmasterd.options[:node] leaks from test to test Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
| * Minimal fix for #2822Markus Roberts2009-12-101-1/+1
| | | | | | | | | | | | Fail rathing than raising the exception so that the line and file are preserved. A more general solution to these sorts of issues is called for on the code smell list.
| * Fix for #2863 (calling each on uninitialized tag list)Markus Roberts2009-12-102-31/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | This is a fix for the core issue of #2863, calling each on a nil tag (instead of empty) tag list for a resource with no tags, combined with various cleanup in related code to forestall reintroduction of a similar bug. * Replace the direct @var access with an initializing getter * Rename it from @tags_hash to @tags_list since it's not a hash * Do the same with the otherwise identical params setup. * Eliminate the now-redundant external initialization for params. * Remove the parameters method as it was never used and obviously faulty (calling a non-existent get_params_hash method).
| * Feature 2827 Option to disable managing internal filesJesse Wolfe2009-12-093-4/+36
| | | | | | | | | | | | | | | | | | | | | | | | Add a flag "manage_internal_file_permissions" which is enabled by default. Disabling this flag prevents Puppet from managing the owner, group, or mode of files created from Puppet::Util::Settings::FileSetting I think this is a wide enough net to follow Luke's suggestion of "disable management of everything", and it certainly satisfies the requests I'm aware of, but if I've missed anything, let me know. Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
generated by cgit (git 2.34.1) at 2025-09-28 05:44:21 +0000