| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
|
| |
Along the way this fixes an issue with 2.6 alpha that sections of the
puppet config file were getting ignored.
|
| |
|
|
|
|
|
|
| |
Mode is a terribly overused word. Files use it, puppetdoc uses it, and
certs use it, and those are just the places that I happened to
stumble upon. It makes reading code very confusing and finding things
in code difficult. I know namespacing allows us to reuse words for
method and variable names, but that doesn't mean we should.
|
| |
|
|
|
|
| |
Per Luke's replacement of :check with :audit, and deprecation of :check,
I've replaced all of our internal uses of :check with :audit. Importantly,
this silence the deprecation warnings during regular usage from eg. ralsh.
|
| | |
|
| | |
|
| |
|
|
| |
I'm also going to update the wiki to mention sqlite is a test dependency
|
| |
|
|
| |
Part 2 re-did the change on the spec files, which it shouldn't have.
|
| |
|
|
|
| |
The spec/unit/provider/ssh_authorized_key/parsed_spec_spec.rb was trying to
use Dir.tempdir but getting ours.
|
| |
|
|
|
|
|
|
|
| |
Some spec files like active_record.rb had names that would confuse the
load path and get loaded instead of the intended implentation when the
spec was run from the same directory as the file.
Author: Matt Robinson <matt@puppetlabs.com>
Date: Fri Jun 11 15:29:33 2010 -0700
|
| |\ |
|
| | |\ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Commit ae520057280c2454bc44c64ac1e6686bf2eb086d introduced some code
that used 'asuser' which does nothing when not run as root, but in these
tests tries to run as a non-existent user. Stubbing out the asuser
method to just yield prevents test failures when running as root.
|
| | | |
| | |
| | |
| | |
| | | |
There were a bunch of "warning: parenthesize argument(s) for future version"
messages; now there aren't.
|
| | |/
| |
| |
| |
| | |
This change removes some irrelevant output (debugging information,
warnings, etc) from a few specs.
|
| |/
|
|
|
|
| |
when run as root, which caused the test to fail. Changing the test so
that a directory is in place of the writeable file so not even root can
write to it.
|
| |
|
|
| |
Signed-off-by: Luke Kanies <luke@puppetlabs.com>
|
| |
|
|
|
|
|
|
| |
We were looking only to the class hierarchies when trying to find an
ancestor to the current type. Thus we were never trying to climb up
the hierarchy of nodes when evaluating nodes.
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|
| |
|
|
| |
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|
| |
|
|
|
|
|
|
| |
During the refactoring of AST hostclass/node to non AST objects, we lost
the fact that the main class already comes with a scope (ie the top one),
so when we evaluate its code we shouldn't create a subscope for it.
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
|
| |
|
|
|
|
| |
A few specs were using a global variable rather than a local, causing
an order-dependent failure in which they were replacing the object
under test.
|
| |
|
|
|
|
|
|
| |
There was a subtle 1.8.7 dependence in the composite key / namevar patch;
Nick discovered that our assumtion that hashes could be used as hash keys
does not hold in earlier bersions of ruby. This patch replaces the hash
valued uniqueness_key with an array of the values of the (ordered) key
attributes.
|
| |
|
|
|
|
| |
Merging some of the branches creates a require-loop; this commit breaks it by
removing the most recently added link (which I believe to have been unneeded /
unrelated to the patch in which it snuck in).
|
| |
|
|
| |
There was a comma missing from a raise, which caused a warning message on each run.
|
| | |
|
| |
|
|
| |
in a conflict resolution
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
and update the specs that were testing it.
|
| |
|
|
|
| |
* do not monkey patch Net::HTTP in a way that breaks other specs
* Use fakes to sense behavior of Net::HTTP
|
| |
|
|
|
| |
The value method was failing to return any value in the case where
the value was false.
|
| |
|
|
|
| |
A change to the way host_config is determined caused this spec to
call store when it didn't before, so it needed to be mocked.
|
| |
|
|
| |
object instead of a string
|
| | |
|
| |
|
|
| |
The test checked for false when all we cared about was that it was not truthy.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
When Markus reverted changes made by 2890 he reintroduced a
method certificate_matches_key? that then caused failures in
network/xmlrpc/client.rb. I just stubbed that method to return true
since the failing tests weren't trying to test that methods behavior.
Reviewed-by: Markus Roberts
|
| | |
|
| |
|
|
|
|
|
|
| |
Ideally it would be nice if the rake task used personalized RSpec
settings on a per user basis, but until someone figures that out color
would be nice
Signed-off-by: Matt Robinson <matt@puppetlabs.com>
|
| |
|
|
|
| |
Puts reportdir and reporturl back in the "main" block because this makes
tests break for reasons I don't understand.
|
| |
|
|
|
|
| |
Tests that weren't managing the environment but were still expecting to have
functions defined in it were appalled when the functions/environments binding
actually started working. This patch fixes those tests.
|
| | |
|
| |
|
|
|
|
|
| |
should have been stubbed.
This failure was introduced in commit 94390de11d046d4906842f33aa9865f6c3835633,
which just had the message 'foo'.
|
| | |
|
| |
|
|
|
|
| |
This change allows the --onetime command line option to be set by the
Puppet[:onetime] global option or read from the config file, rather than
forcing it to be read from the config file.
|
| |
|
|
|
| |
audit's munge was not idempotent because newattr was not idempotent.
This patch simplifies newattr such that it becomes idempotent.
|
| |
|
|
|
|
|
|
|
| |
Some spec files like active_record.rb had names that would confuse the
load path and get loaded instead of the intended implentation when the
spec was run from the same directory as the file.
Author: Matt Robinson <matt@puppetlabs.com>
Date: Fri Jun 11 15:29:33 2010 -0700
|
