summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fixed #2589 - Renamed zfs delete to destroy and added testsJames Turnbull2009-09-052-3/+15
|
* Monkey patch to improve yaml compatibility between ruby versionsMarkus Roberts2009-09-052-0/+44
| | | | | | | | | Ruby 1.8.1 can not parse the yanl produced by later versions because it requires explict type tagging of symbols. This patch adds the tagging on to later versions so that mixed version instalations can use yaml. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixed typo in parser testJames Turnbull2009-09-051-1/+1
|
* Updated Red Hat spec file and RH patches for 0.25.0.James Turnbull2009-09-055-109/+69
| | | | Thanks to Todd Zullinger for the patch and the updates.
* Fixing #2592 - you can escape slashes in regexesLuke Kanies2009-09-042-3/+28
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2590 - modulepath is not cached inappropriatelyLuke Kanies2009-09-032-0/+13
| | | | | | | | | | | | | | | | It was getting cached by Environment instances too early, thus causing some executables to use the default even when it was overridden. We're taking the slightly extreme step of clearing the environment list if any parameter is set, but this is relatively inexpensive and is the only way to always be correct. The reason that the environments cache this value at all is that to build up their module path they have to search through every known module for a lib or plugins directory, which is then done every time a class is sought in the language. Caching it saves a *ton* of file accesses. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixed #2593: puppet init script status command not returning proper exit codeJohn A. Barbuto2009-09-041-0/+2
| | | | Signed-off-by: John A. Barbuto <jbarbuto@corp.sourceforge.com>
* Update documentation string to reflect actual intent of ↵Steven Jenkins2009-09-041-1/+1
| | | | Puppet::Node::Facts::Rest
* Fixes #2581. Use new 10.6 global launchd overrides file for service ↵Nigel Kersten2009-09-032-10/+140
| | | | status/enabled
* Fixed Naginator linkJames Turnbull2009-09-031-1/+1
|
* Fixing #2582 - / no longer autorequires /Luke Kanies2009-09-012-3/+21
| | | | | | This was obviously resulting in a dep cycle. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2577 - clarifying and demoting the deprecation noticeLuke Kanies2009-09-014-28/+40
| | | | | | | It's now just notice instead of a warning, and it clarifies that 0.24 clients can't be present. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2574 - autoloading finds plugins in modulesLuke Kanies2009-09-013-7/+40
| | | | | | | | We had some stupid errors that were preventing this from happening; this fixes them and adds an integration test. Signed-off-by: Luke Kanies <luke@madstop.com>
* The first regex node now matches firstLuke Kanies2009-09-012-11/+19
| | | | | | | Before it was undefined, but now we always match the first defined node. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2563 - multiple regex nodes now work togetherLuke Kanies2009-09-012-2/+50
| | | | | | | | | | The problem was that we were needing to convert one of the regexes to a string, which wasn't working well. This adds specific rules for how regexes vs. strings get compared. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixes #724 - false is equivalent to 'ruby -W1'Marc Fournier2009-09-011-1/+1
| | | | Signed-off-by: Marc Fournier <marc.fournier@camptocamp.com>
* Fix parser error outputTodd Zullinger2009-08-241-1/+1
| | | | | | The 'value' passed to on_error in Puppet::Parser::Parser is a hash, and we only want to print the 'value' key, rather than a flattened string of the hash.
* Fixing #2551 - fixing content changed logsLuke Kanies2009-08-231-0/+15
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fix for test isolation portion of Ticket #2511Markus Roberts2009-08-241-12/+11
| | | | | | | | | Ticket #2511 comprises two distinct problems with very similar symptoms. This patch addresses one of them, the test failures which result from spec/units/util/backups.rb directly requiering type/file. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixing #2549 - autoloading of top-level classes works againLuke Kanies2009-08-242-7/+20
| | | | | | | | This was broken in the recent refactor around autoloading, which didn't special-case classes that specified that they were top-level. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing a heisenbug resulting from a race conditionLuke Kanies2009-08-241-1/+3
| | | | | | | | | | | We had a case where an expectation could be triggered before the thread finished, in which case it was marked as a failure. We just stub the Thread.new to avoid creating a "real" thread, thus skipping the race condition. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2460 - puppetmasterd can now read the cert and keyLuke Kanies2009-08-242-4/+35
| | | | | | | | | | | | This follows on to the previous commits which made Puppet resilient to the service user being absent. This just changes the default owner of all of the cert-related files to now be the service user, which means that on the server all of these files will be owned by that user and on the client, at least when the service user does not exist, they will be owned by root. Signed-off-by: Luke Kanies <luke@madstop.com>
* Not using the service user in settings when it's unavailableLuke Kanies2009-08-245-45/+121
| | | | | | | | | This gets us most of the way toward fixing #2460 - we can now have the certificate information owned by the service user when it's available, thus making it so that puppetmasterd (not running as root) can read it. Signed-off-by: Luke Kanies <luke@madstop.com>
* Explicitly loading all facts in the directory service providerLuke Kanies2009-08-241-0/+3
| | | | | | | | We otherwise have load-order issues, where this provider tries to use the facts but they aren't currently autoloaded by default in Facter. Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding an 'exists?' delegator from user type to providerLuke Kanies2009-08-242-0/+11
| | | | | | | We need this knowledge from the Settings class, and it makes more sense to delegate than to use direct access to the provider. Signed-off-by: Luke Kanies <luke@madstop.com>
* Switching the owner/group settings to use symbolic valuesLuke Kanies2009-08-243-50/+130
| | | | | | | | | | | | | | We previously allowed the owner and group to be set to arbitrary values but we never actually used it -- we always just set them to '$user' or '$group'. This commit changes the model to allow 'root' or 'service', where 'service' is converted to the actual service user/group. This has the potential to have backward compatibility concerns, because users could have changed the owner/group in puppet.conf, but the chances of that are fantastically small. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing the yamldir group to be a group instead of userLuke Kanies2009-08-242-1/+6
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Moving Setting classes into separate filesLuke Kanies2009-08-249-409/+423
| | | | | | | | This isn't really a refactor, just moving code around. I did some simple method renaming, also. Signed-off-by: Luke Kanies <luke@madstop.com>
* Removing chuser on darwin restrictionLuke Kanies2009-08-241-4/+0
| | | | | | | | | | | For too long we have refused to change users on Darwin because a long time ago the ruby they shipped with was really, really broken. It's been fixed for a while, so this just removes the restriction. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing a ruby warning in the authstore testLuke Kanies2009-08-241-1/+1
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #2558 - propagating recent fileserving changesLuke Kanies2009-08-2412-139/+181
| | | | | | | | | | | | | | | | | | I'd made changes to the internals of the fileserving system to fix #2544 (mostly switched from passing the node around and then calculating the environment to just passing the environment around), but those changes weren't consistent throughout the fileserving code. In the process of making them consistent, I realized that the plain file server actually needs the node name rather than the environment, so I switched to passing the request around, because it has both pieces of information. Also added further integration tests which will hopefully keep this from cropping up again. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixes #2550 Handles case where metadata is nilMarkus Roberts2009-08-231-7/+6
| | | | | | | | | | | | | The checksum function assumed that if the source was present the metadata (including checksum) was also, and thus that the type of the checksum could be extracated with a simple RegExp match. When metadata is nil it returns nil for the source checksum and the modified function passes this on. Alternatives would be to default to :md5 or to pass on to checking the :checksum parameter as if there were no source. Signed-off-by: Markus Roberts <Markus@reality.com>
* Ticket 2559 -- parseonly ignored specified fileMarkus Roberts2009-08-221-0/+6
| | | | | | | | In the command-line option parsing refactor from 0.24.x the manifest specification was lost for --parseonly, so site.pp was always used. This patch adds the parsing back in. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixed #2562 - Recognize the usecacheonfailure option againJohn A. Barbuto2009-08-212-0/+15
| | | | Signed-off-by: John A. Barbuto <jbarbuto@corp.sourceforge.com>
* Refactoring the Module/Environment co-interfaceLuke Kanies2009-08-184-130/+71
| | | | | | | This simplifies who owns what code in these two classes, and the result should be much cleaner and simpler. Signed-off-by: Luke Kanies <luke@madstop.com>
* Fixing #1544 - plugins in modules now works againLuke Kanies2009-08-1811-68/+137
| | | | | | | | | | | | We had to fix the fileserving plumbing to use the request environment instead of trying to use the node environment. This was apparently never fixed after we added the environment to the URI in REST calls. There's still a bit of refactoring left to clean up the APIs used in some of this code. Signed-off-by: Luke Kanies <luke@madstop.com>
* Adding a global cleanup to the spec_helperLuke Kanies2009-08-181-3/+4
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Removed misguided case sensitivity testsMarkus Roberts2009-08-182-19/+0
| | | | | | | | Removed two failing tests added in the process of reproducing #2493 because they enforced case-insensitivity in excess of that provided by 0.24.8 and thus contrary to user expectations. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fixes #2513. debian service provider now uses invoke-rc.d to determine ↵Nigel Kersten2009-08-182-11/+108
| | | | enabled? status
* Fixing fact-missing problem when puppet.conf is reparsedLuke Kanies2009-08-182-0/+20
| | | | Signed-off-by: Luke Kanies <luke@madstop.com>
* Fix for #2531; adds tests to confirm problem and related cases,Markus Roberts2009-08-182-1/+97
| | | | | | | notes fixes specific issue by eliminating the specal case for opaque strings which caused them to be strings when everything else was arrays; adds nots and pending tests where FQDN support could be added but stops short of a full refactor.
* Fixed #2530 - Fixed status setting in the SMF providerJames Turnbull2009-08-151-1/+1
|
* Fixed spec typoJames Turnbull2009-08-151-1/+1
|
* Fixes #2493Markus Roberts2009-08-146-44/+128
| | | | | | | | | | | | Added downcasing into find_or_load (which replaced fqfind) to get back the old behaviour. Adjusted tests so that they would catch the problem & confirmed that they fail without the downcasing. Added tests to confirm the existance of #2493; improved existing autoload tests (removed inter-test interactions) and noted (with a TODO) that there was dead code in the feature loading test; added analogus case sensitivity tests where apropriate.
* conf/redhat/*.init: Fix condrestart/try-restartTodd Zullinger2009-08-132-4/+14
| | | | | | | | | | | Previously, the Red Hat init scripts used the $pidfile or $lockfile as a test for whether to restart the daemons. This caused condrestart to start the daemons even when they were not running, in cases where they had died or been killed without cleaning up the $pidfile/$lockfile. This was reported by Ingvar Hagelund in Red Hat bug #480600. Signed-off-by: Todd Zullinger <tmz@pobox.com>
* conf/redhat/client.init: Fix #2123, status options on older RHELTodd Zullinger2009-08-131-2/+6
| | | | | | | | On RHEL < 5, the status function does not accept a -p option. Using it causes 'service puppet status' to produce erroneous output. This was also reported by Aaron Dummer in Red Hat bug #501577. Signed-off-by: Todd Zullinger <tmz@pobox.com>
* Updates to Solaris smf files to reflect new binary locationsJames Turnbull2009-08-132-3/+3
|
* Fix #2517 - Stack overflow when CA cert missingMarkus Roberts2009-08-132-8/+13
| | | | | | | | | | | | | | This was a "There's A Hole In The Bucket" problem caused when trying to establish a connection to get a certificate before there was a certificate with which to establish the connection, ad infinitum. The solution was to test for the presence of the CA cert as well as the host cert before attempting to use them. This patch modifies existing tests to pass with the new code (by stubbing out the additional FileTests) and adds a new test which catches the original problem. Signed-off-by: Markus Roberts <Markus@reality.com>
* Fix #2516 - Fix format detection when content-type contains charsetBrice Figureau2009-08-136-3/+34
| | | | | | | | | | | | | | | | | | Even though Puppet never transmist a charset information in its response/request content-type, some proxy (especially Apache with the infamous AddDefaultCharset configuration) may add this "incorrect" information. This patch makes sure that only the mime-type is used when looking for the format associated with a response or a request. The patch also provides a better error message when the client or server code is fed with a request whose mime-type can not be mapped to a known format. It also fixes a typo noticed by the original reporter. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
* Fix #2507 - Add missing integration testsBrice Figureau2009-08-132-4/+65
| | | | | | | | Some of the integration tests were either missing or not complete, especially tests about exported non virtual resources or virtual and exported resources. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>