(#2128) Add support for setting node name based on a fact

This adds the node_name_fact setting, which specifies a fact to use to
determine the node name. This allows dynamically determining the node name
without having to modify puppet.conf or command line options.

Using this setting requires modifying auth.conf to allow nodes to request
catalogs not matching their certnames.

For example, this would allow any authenticated node to retrieve any catalog:

  # $confdir/auth.conf
  path ~ /catalog/.+
  allow *

The node_name_fact and node_name_value options are mutually exclusive, because
it is ambiguous which setting should take precedence.

Paired-With: Jacob Helwig <jacob@puppetlabs.com>

1 files changed, 16 insertions, 0 deletions

diff --git a/spec/unit/configurer/fact_handler_spec.rb b/spec/unit/configurer/fact_handler_spec.rb
index ddb541174..ced743ea6 100755
--- a/spec/unit/configurer/fact_handler_spec.rb
+++ b/spec/unit/configurer/fact_handler_spec.rb
@@ -61,6 +61,22 @@ describe Puppet::Configurer::FactHandler do
       @facthandler.find_facts.should == bar_facts
     end
 
+    it "should set the facts name based on the node_name_fact" do
+      Puppet::Node::Facts.new(Puppet[:node_name_value], 'my_name_fact' => 'other_node_name').save
+      Puppet[:node_name_fact] = 'my_name_fact'
+
+      @facthandler.find_facts.name.should == 'other_node_name'
+    end
+
+    it "should set the node_name_value based on the node_name_fact" do
+      Puppet::Node::Facts.new(Puppet[:node_name_value], 'my_name_fact' => 'other_node_name').save
+      Puppet[:node_name_fact] = 'my_name_fact'
+
+      @facthandler.find_facts
+
+      Puppet[:node_name_value].should == 'other_node_name'
+    end
+
     it "should reload Facter before finding facts" do
       @facthandler.expects(:reload_facter)