summaryrefslogtreecommitdiffstats
path: root/spec/integration/type/tidy_spec.rb
diff options
context:
space:
mode:
authorJosh Cooper <josh@puppetlabs.com>2011-07-22 12:34:05 -0700
committerJacob Helwig <jacob@puppetlabs.com>2011-08-19 13:52:57 -0700
commiteaa7d92f4017fcdae54e5f6addf1edd3a72fe384 (patch)
tree7ab6ded80fbabc86be104fc5a0221299ebfa47ca /spec/integration/type/tidy_spec.rb
parent945bf74aad13de37d5ca46961db78a72b8c24029 (diff)
downloadpuppet-eaa7d92f4017fcdae54e5f6addf1edd3a72fe384.tar.gz
puppet-eaa7d92f4017fcdae54e5f6addf1edd3a72fe384.tar.xz
puppet-eaa7d92f4017fcdae54e5f6addf1edd3a72fe384.zip
Disable spec tests for unsupported functionality on Windows
Ruby does not support creating symlinks on Windows (though Windows does support them), and since the tidy spec test is designed to reproduce a specific bug (as opposed to testing symlink functionality on Windows) it has been disabled. Ruby on Windows also does not support File.chmod, so the inspect spec test has been disabled. The general issue of File.chmod on Windows is something I know needs to be investigated. Also disabled the cron spec test as this functionality will not be supported on Windows (instead there will be task manager support). Re-enable the autoload spec tests as those now pass on Windows (this is probably due to the cacher changes recently made). The inventory ssl spec is not supported on Windows and so is disabled. However, while researching the failure, it was due to Time.now.strftime("%Z") returning "Pacific Daylight Time" on Windows, instead of "PDT" like it does on other platforms. As a result, the split method was sometimes splitting in the wrong place. As far as I can tell, the inventory code is only called from the CA (to keep track of serial numbers for certs that it has issued). But it's something to watch out for on Windows when calling strftime. Webrick, fileserver and CA functionality are not supported on Windows so these spec tests are disabled. Also fix path issue with catalog spec. Also several spec tests were creating tempfiles manually and calling system("rm -rf ..."), these have been replaced with PuppetSpec::Files.tmpdir. Reviewed-by: Jacob Helwig <jacob@puppetlabs.com> (cherry picked from commit 75d2e62cab1de7677463c274892f8920cb7e0cbf)
Diffstat (limited to 'spec/integration/type/tidy_spec.rb')
-rwxr-xr-xspec/integration/type/tidy_spec.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/integration/type/tidy_spec.rb b/spec/integration/type/tidy_spec.rb
index 08a24099c..d1bb62d6e 100755
--- a/spec/integration/type/tidy_spec.rb
+++ b/spec/integration/type/tidy_spec.rb
@@ -12,7 +12,7 @@ describe Puppet::Type.type(:tidy) do
end
# Testing #355.
- it "should be able to remove dead links", :fails_on_windows => true do
+ it "should be able to remove dead links", :unless => Puppet.features.microsoft_windows? do
dir = tmpfile("tidy_link_testing")
link = File.join(dir, "link")
target = tmpfile("no_such_file_tidy_link_testing")