<feed xmlns='http://www.w3.org/2005/Atom'>
<title>puppet.git/spec, branch ticket/master/8119</title>
<subtitle>Puppet repo</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/'/>
<entry>
<title>Merge branch '2.7.x'</title>
<updated>2011-08-24T22:42:03+00:00</updated>
<author>
<name>Nick Lewis</name>
<email>nick@puppetlabs.com</email>
</author>
<published>2011-08-24T22:42:03+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=da4a2def42639817c4522fc0162bd691956998da'/>
<id>da4a2def42639817c4522fc0162bd691956998da</id>
<content type='text'>
Conflicts:
	lib/puppet/feature/base.rb
	lib/puppet/file_serving/configuration.rb
	spec/unit/indirector/ssl_file_spec.rb
	spec/unit/parser/functions/extlookup_spec.rb
	spec/unit/resource/catalog_spec.rb
	test/language/ast/variable.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Conflicts:
	lib/puppet/feature/base.rb
	lib/puppet/file_serving/configuration.rb
	spec/unit/indirector/ssl_file_spec.rb
	spec/unit/parser/functions/extlookup_spec.rb
	spec/unit/resource/catalog_spec.rb
	test/language/ast/variable.rb
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #53 from joshcooper/ticket/2.7.x/8662-root-on-windows</title>
<updated>2011-08-23T00:06:44+00:00</updated>
<author>
<name>Nick Lewis</name>
<email>nick@puppetlabs.com</email>
</author>
<published>2011-08-23T00:06:44+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=630ec36089e2224fba99b76d76eaf904af13e4d6'/>
<id>630ec36089e2224fba99b76d76eaf904af13e4d6</id>
<content type='text'>
Ticket/2.7.x/8662 root on windows</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ticket/2.7.x/8662 root on windows</pre>
</div>
</content>
</entry>
<entry>
<title>(#8662) Don't manage internal file permissions on Windows</title>
<updated>2011-08-22T22:07:41+00:00</updated>
<author>
<name>Josh Cooper</name>
<email>josh@puppetlabs.com</email>
</author>
<published>2011-08-22T16:26:33+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=0f207a8ea61205ba6b47e8da429ab3887b3cda4d'/>
<id>0f207a8ea61205ba6b47e8da429ab3887b3cda4d</id>
<content type='text'>
When running as root, puppet will by default manage internal file
permissions for file-related settings. However, ruby does not support
chown/chgrp functionality on Windows, so puppet will fail to run
(puppet apply generates an exception while trying to set the owner,
etc).

This commit disables internal file permissions handling on Windows
until we add support for chown (at least) as part of the larger file
type effort on Windows.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When running as root, puppet will by default manage internal file
permissions for file-related settings. However, ruby does not support
chown/chgrp functionality on Windows, so puppet will fail to run
(puppet apply generates an exception while trying to set the owner,
etc).

This commit disables internal file permissions handling on Windows
until we add support for chown (at least) as part of the larger file
type effort on Windows.
</pre>
</div>
</content>
</entry>
<entry>
<title>(#8662) Skip user and group resources when applying settings on Windows</title>
<updated>2011-08-22T22:07:16+00:00</updated>
<author>
<name>Josh Cooper</name>
<email>josh@puppetlabs.com</email>
</author>
<published>2011-08-18T17:35:50+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=47058abc0c5647d59b0dd21181e67dbfdd908292'/>
<id>47058abc0c5647d59b0dd21181e67dbfdd908292</id>
<content type='text'>
When running as root, puppet will generate a catalog from its settings
to create the various directories, e.g. var, ssl. If mkusers is true
and a setting implements owner and/or group methods, then puppet will
automatically add user and group resources to the catalog (provided
the user name is not root and the group names are not root or
wheel). This functionality will not be supported on Windows, and so
this step is skipped.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When running as root, puppet will generate a catalog from its settings
to create the various directories, e.g. var, ssl. If mkusers is true
and a setting implements owner and/or group methods, then puppet will
automatically add user and group resources to the catalog (provided
the user name is not root and the group names are not root or
wheel). This functionality will not be supported on Windows, and so
this step is skipped.
</pre>
</div>
</content>
</entry>
<entry>
<title>(#8662) Fix Puppet.features.root? on Windows</title>
<updated>2011-08-22T22:06:11+00:00</updated>
<author>
<name>Josh Cooper</name>
<email>josh@puppetlabs.com</email>
</author>
<published>2011-08-18T17:34:18+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=2ac87905708ddbc44d212e10e34d72cad09e3271'/>
<id>2ac87905708ddbc44d212e10e34d72cad09e3271</id>
<content type='text'>
This commit changes Puppet::Util::SUIDManager.root? (and
Puppet.features.root?) to only return true if the user is running with
elevated privileges (granted via UAC). If this check fails because
elevated privileges are not supported, e.g. pre-Vista, then we fall
back to checking if the user is a member of the builtin Administrators
group.

This means if you are logged in as Administrator on 2008,
Puppet.features.root? will return false, unless you are explicitly
running puppet as an administrator, e.g.

 runas /user:Administrator "puppet apply manifest.pp"

This commit also adds tests to ensure SUIDManager.asuser is a no-op on
Windows, since Windows does not (easily) support switching user
contexts without providing a password.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit changes Puppet::Util::SUIDManager.root? (and
Puppet.features.root?) to only return true if the user is running with
elevated privileges (granted via UAC). If this check fails because
elevated privileges are not supported, e.g. pre-Vista, then we fall
back to checking if the user is a member of the builtin Administrators
group.

This means if you are logged in as Administrator on 2008,
Puppet.features.root? will return false, unless you are explicitly
running puppet as an administrator, e.g.

 runas /user:Administrator "puppet apply manifest.pp"

This commit also adds tests to ensure SUIDManager.asuser is a no-op on
Windows, since Windows does not (easily) support switching user
contexts without providing a password.
</pre>
</div>
</content>
</entry>
<entry>
<title>maint: Stub spec test so directory is not created unnecessarily</title>
<updated>2011-08-22T16:40:20+00:00</updated>
<author>
<name>Josh Cooper</name>
<email>josh@puppetlabs.com</email>
</author>
<published>2011-08-18T21:23:15+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=9f39cc476246e307ec4d8861502c1d5b8ce1bc21'/>
<id>9f39cc476246e307ec4d8861502c1d5b8ce1bc21</id>
<content type='text'>
One of the spec tests required that the parent directory (in this case
/tmp) already exist and that /tmp/my_directory could be created. This
fails on Windows as /tmp likely doesn't exist, and also the test
doesn't actually need to create the directory.

This commit forces the call to exists? with the parent directory to
return true, and stubs the mkdir call so that the directory is not
actually created.

It also makes the raise_error expectation look for the specific error
message, instead of a generic DevError.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
One of the spec tests required that the parent directory (in this case
/tmp) already exist and that /tmp/my_directory could be created. This
fails on Windows as /tmp likely doesn't exist, and also the test
doesn't actually need to create the directory.

This commit forces the call to exists? with the parent directory to
return true, and stubs the mkdir call so that the directory is not
actually created.

It also makes the raise_error expectation look for the specific error
message, instead of a generic DevError.
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't use non-1.8.5-compatible methods 'Object#tap' and 'Dir.mktmpdir'</title>
<updated>2011-08-19T21:46:15+00:00</updated>
<author>
<name>Nick Lewis</name>
<email>nick@puppetlabs.com</email>
</author>
<published>2011-07-22T04:25:21+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=66fb5319b419c4145d07b4a217efc13d35e3a5a4'/>
<id>66fb5319b419c4145d07b4a217efc13d35e3a5a4</id>
<content type='text'>
These methods aren't available until Ruby 1.8.6 (Dir.mktmpdir) and Ruby 1.8.7
(Object#tap).

Reviewed-By: Jacob Helwig &lt;jacob@puppetlabs.com&gt;
(cherry picked from commit 61df3f7c39d74b82e37f48c3519293406036e1e9)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These methods aren't available until Ruby 1.8.6 (Dir.mktmpdir) and Ruby 1.8.7
(Object#tap).

Reviewed-By: Jacob Helwig &lt;jacob@puppetlabs.com&gt;
(cherry picked from commit 61df3f7c39d74b82e37f48c3519293406036e1e9)
</pre>
</div>
</content>
</entry>
<entry>
<title>maint: Fix build break due to recent merge from 2.7.x to master</title>
<updated>2011-08-19T20:52:59+00:00</updated>
<author>
<name>Josh Cooper</name>
<email>josh@puppetlabs.com</email>
</author>
<published>2011-08-18T00:08:38+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=2091cbeade9d69a18689609f407f9d7f0304dc04'/>
<id>2091cbeade9d69a18689609f407f9d7f0304dc04</id>
<content type='text'>
The resource_spec was failing because /etc is not considered a
fully-qualified path on Windows. Using File.expand_path fixes that.

The suidmanager_spec was failing because we weren't stubbing the
microsoft_windows feature, so SUIDManager.asuser was a no-op when
running as root, and our expectations weren't being met.
(cherry picked from commit af87f32a016a5ed48353f516f9558f95c54c50b4)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The resource_spec was failing because /etc is not considered a
fully-qualified path on Windows. Using File.expand_path fixes that.

The suidmanager_spec was failing because we weren't stubbing the
microsoft_windows feature, so SUIDManager.asuser was a no-op when
running as root, and our expectations weren't being met.
(cherry picked from commit af87f32a016a5ed48353f516f9558f95c54c50b4)
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix posix exec provider spec failures on Windows</title>
<updated>2011-08-19T20:52:59+00:00</updated>
<author>
<name>Nick Lewis</name>
<email>nick@puppetlabs.com</email>
</author>
<published>2011-08-16T19:40:06+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=2681ca5360428db071aaa66614c21f6be581c1cc'/>
<id>2681ca5360428db071aaa66614c21f6be581c1cc</id>
<content type='text'>
These specs were assuming that paths such as /foo were always absolute, which
is not the case on Windows. Thus, when run on Windows, the provider was
complaining about receiving relative paths when it expected absolute, rather
than succeeding or failing in the intended way. Now we expand all paths we want
to be absolute, to guarantee they will be absolute everywhere.

Also, some specs were failing because they were trying to test the case where a
file isn't executable. That's not something we can reliably check on Windows,
so instead just stub the appropriate executable? methods.

Reviewed-By: Matt Robinson &lt;matt@puppetlabs.com&gt;
(cherry picked from commit e9b558dd35eec6e221aef9de3f300a5843347454)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These specs were assuming that paths such as /foo were always absolute, which
is not the case on Windows. Thus, when run on Windows, the provider was
complaining about receiving relative paths when it expected absolute, rather
than succeeding or failing in the intended way. Now we expand all paths we want
to be absolute, to guarantee they will be absolute everywhere.

Also, some specs were failing because they were trying to test the case where a
file isn't executable. That's not something we can reliably check on Windows,
so instead just stub the appropriate executable? methods.

Reviewed-By: Matt Robinson &lt;matt@puppetlabs.com&gt;
(cherry picked from commit e9b558dd35eec6e221aef9de3f300a5843347454)
</pre>
</div>
</content>
</entry>
<entry>
<title>(#5495) Remove dead Windows-specific code from posix exec provider</title>
<updated>2011-08-19T20:52:59+00:00</updated>
<author>
<name>Nick Lewis</name>
<email>nick@puppetlabs.com</email>
</author>
<published>2011-08-15T22:51:37+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=3812fc35eae962938041256f8974bc94f41a3326'/>
<id>3812fc35eae962938041256f8974bc94f41a3326</id>
<content type='text'>
Because this provider only applies when the posix feature is present (and thus
not the windows feature), it can never be used on Windows. Thus, the
Windows-specific command handling is unnecessary and unused.

Also added more specific error messages for the cases where a command doesn't
exist, isn't a file, and isn't executable. These only apply when the command
path is absolute (otherwise the message is simply command not found).

Reviewed-By: Matt Robinson &lt;matt@puppetlabs.com&gt;
(cherry picked from commit b28bcb031346cfd2026361ec5ffb420c1dcf60d7)

Conflicts:

	spec/unit/provider/exec/posix_spec.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Because this provider only applies when the posix feature is present (and thus
not the windows feature), it can never be used on Windows. Thus, the
Windows-specific command handling is unnecessary and unused.

Also added more specific error messages for the cases where a command doesn't
exist, isn't a file, and isn't executable. These only apply when the command
path is absolute (otherwise the message is simply command not found).

Reviewed-By: Matt Robinson &lt;matt@puppetlabs.com&gt;
(cherry picked from commit b28bcb031346cfd2026361ec5ffb420c1dcf60d7)

Conflicts:

	spec/unit/provider/exec/posix_spec.rb
</pre>
</div>
</content>
</entry>
</feed>
