puppet.git/spec/unit/parser, branch ticket/master/7841

Fix spec test failure on 1.9.2

2011-07-19T22:29:38+00:00

The previous set of windows patches accidentally changed %w{/one}
to make_absolute("/one"). This commit changes it back to
[make_absolute("/one")].

Reviewed-by: Jacob Helwig

Maint: Fix miscellaneous tests

2011-07-19T21:08:38+00:00

Several tests were broken due to pecularities of Windows
and Ruby on Windows:

* Ruby on windows does not differentiate between group and
  other file permissions.
* All open file handles must be closed before the file can
  be deleted
* Sometimes the current working directory (Dir.getwd) is
  reported as C:/foo and other times as C:\\foo, which
  confuses the spec tests.
* Ruby's sprintf formats floating point values differently
  on Windows vs Unix. The Windows exponent has an extra
  leading zero.
* Needed to stub execution of security command with the
  SMF service provider.

Reviewed-by: Jacob Helwig

Fix tests with "relative" paths on Windows

2011-07-19T21:06:36+00:00

Absolute paths on Unix, e.g. /foo/bar, are not absolute on Windows,
which breaks many test cases. This commit adds a method to
PuppetSpec::Files.make_absolute that makes the path absolute in
test cases.

On Unix (Puppet.features.posix?) it is a no-op. On Windows,
(Puppet.features.microsoft_windows?) the drive from the current
 working directory is prepended.

Reviewed-by: Jacob Helwig

(#8489) Consistently use File::PATH_SEPARATOR

2011-07-19T21:03:42+00:00

Puppet uses both colon and File::PATH_SEPARATOR in various places, which
does not work on Windows, where File::PATH_SEPARATOR is a semi-colon. This
commit changes the code and tests to consistently use File::PATH_SEPARATOR.

Reviewed-by: Jacob Helwig

Scope[] now returns nil for undefined variables

2011-07-15T18:52:41+00:00

Given that we have the 'include?' method, this feature
is unnecessary, and it makes sense to convert to more
ruby-like behavior.

Any code that previously checked whether lookupvar
(or the new []) returned :undefined should now check
whether 'scope.include?(var)'.  Thus, you can have
the same behavior, but it takes a bit different code
to get it.

Signed-off-by: Luke Kanies 
Reviewed-by: Nick Lewis

Fixing a failing test because of mismatched error string

2011-07-15T18:52:38+00:00

Signed-off-by: Luke Kanies 
Reviewed-by: Nick Lewis

Removing an unnecessary stub in the Scope tests

2011-07-15T18:52:36+00:00

Signed-off-by: Luke Kanies 
Reviewed-by: Nick Lewis

Making the Functions module more resilient

2011-07-15T18:52:31+00:00

We were previously storing the module name with
the environment instances as the key, which meant
if the environment instances were removed, we could
never get those modules again.  Given that the
functions weren't reloaded, this meant the functions
were gone if we ever reloaded the environment.

This makes the Functions environment module resilient across
environment reloads, and it also makes the method work correctly
when handed either an environment or a string.

Signed-off-by: Luke Kanies 
Reviewed-by: Nick Lewis

Fixing default parameter value assignment

2011-07-15T18:52:24+00:00

The method for adding class resources to the
catalog was only working in cases where the default
values weren't AST objects.  This commit fixes
this, along with the tests that were failing
and drew out the problem.

Signed-off-by: Luke Kanies 
Reviewed-by: Nick Lewis

Cleanup up a small amount of whitespace

2011-07-15T18:52:22+00:00

Signed-off-by: Luke Kanies 
Reviewed-by: Nick Lewis