<feed xmlns='http://www.w3.org/2005/Atom'>
<title>puppet.git/spec/unit/application, branch master</title>
<subtitle>Puppet repo</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/'/>
<entry>
<title>maint: Fix build break due to recent merge from 2.7.x to master</title>
<updated>2011-08-18T00:16:59+00:00</updated>
<author>
<name>Josh Cooper</name>
<email>josh@puppetlabs.com</email>
</author>
<published>2011-08-18T00:08:38+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=af87f32a016a5ed48353f516f9558f95c54c50b4'/>
<id>af87f32a016a5ed48353f516f9558f95c54c50b4</id>
<content type='text'>
The resource_spec was failing because /etc is not considered a
fully-qualified path on Windows. Using File.expand_path fixes that.

The suidmanager_spec was failing because we weren't stubbing the
microsoft_windows feature, so SUIDManager.asuser was a no-op when
running as root, and our expectations weren't being met.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The resource_spec was failing because /etc is not considered a
fully-qualified path on Windows. Using File.expand_path fixes that.

The suidmanager_spec was failing because we weren't stubbing the
microsoft_windows feature, so SUIDManager.asuser was a no-op when
running as root, and our expectations weren't being met.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '2.7.x'</title>
<updated>2011-08-17T21:44:03+00:00</updated>
<author>
<name>Nick Lewis</name>
<email>nick@puppetlabs.com</email>
</author>
<published>2011-08-17T21:44:03+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=cf95530964a067374f2ff8be0602342e47a55cc5'/>
<id>cf95530964a067374f2ff8be0602342e47a55cc5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '2.6.x' into 2.7.x</title>
<updated>2011-08-17T18:41:26+00:00</updated>
<author>
<name>Jacob Helwig</name>
<email>jacob@puppetlabs.com</email>
</author>
<published>2011-08-17T18:41:26+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=3a3a5100305a5334397c350f4e8e42a7f9b7e3f6'/>
<id>3a3a5100305a5334397c350f4e8e42a7f9b7e3f6</id>
<content type='text'>
* 2.6.x:
  Reset indirector state after configurer tests.
  (#8770) Don't fail to set supplementary groups when changing user to root
  (#8770) Always fully drop privileges when changing user
  (#8662) Migrate suidmanager test case to rspec
  (#8740) Do not enumerate files in the root directory.
  (#3553) Explain that cron resources require time attributes

Conflicts:
	lib/puppet/application/resource.rb
	test/puppet/tc_suidmanager.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* 2.6.x:
  Reset indirector state after configurer tests.
  (#8770) Don't fail to set supplementary groups when changing user to root
  (#8770) Always fully drop privileges when changing user
  (#8662) Migrate suidmanager test case to rspec
  (#8740) Do not enumerate files in the root directory.
  (#3553) Explain that cron resources require time attributes

Conflicts:
	lib/puppet/application/resource.rb
	test/puppet/tc_suidmanager.rb
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '2.7.x'</title>
<updated>2011-08-16T18:45:55+00:00</updated>
<author>
<name>Nick Lewis</name>
<email>nick@puppetlabs.com</email>
</author>
<published>2011-08-16T18:45:55+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=66d852bb2c2b66ff5e7c9966fdb510e2edd529db'/>
<id>66d852bb2c2b66ff5e7c9966fdb510e2edd529db</id>
<content type='text'>
Conflicts:
	lib/puppet/provider/augeas/augeas.rb
	spec/unit/node_spec.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Conflicts:
	lib/puppet/provider/augeas/augeas.rb
	spec/unit/node_spec.rb
</pre>
</div>
</content>
</entry>
<entry>
<title>Do not leak indirector state from apply tests</title>
<updated>2011-08-16T02:37:56+00:00</updated>
<author>
<name>Jacob Helwig</name>
<email>jacob@puppetlabs.com</email>
</author>
<published>2011-08-16T00:07:51+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=2297899e76dd3b65787768f2e4bf6b74b95a3d66'/>
<id>2297899e76dd3b65787768f2e4bf6b74b95a3d66</id>
<content type='text'>
Since the indirector state persists across tests, we were seeing order
dependent test failures with tests that assumed the default indirector
settings.

Specifically, if the following tests were run in order, the first
would cause failures in the second two:

  spec/unit/application/apply_spec.rb
  spec/unit/node_spec.rb
  spec/integration/node_spec.rb

To protect against this state leakage, we now:

  - reset the Puppet::Node terminus before each test in
    spec/integration/node_spec.rb to ensure we are testing a clean
    environment.

  - reset the Puppet::Node, and Puppet::Node::Facts terminus, and
    cache class after each test in spec/unit/application/apply_spec.rb
    to prevent leakage into other tests.

Since the cache class has the same state leakage problem as the
terminus class, but does not have the same ability to lazily populate
the default when set to nil, we remove the test.  Testing the default
for the cache class would require running the test before all other
tests to ensure there is no state pollution.n
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since the indirector state persists across tests, we were seeing order
dependent test failures with tests that assumed the default indirector
settings.

Specifically, if the following tests were run in order, the first
would cause failures in the second two:

  spec/unit/application/apply_spec.rb
  spec/unit/node_spec.rb
  spec/integration/node_spec.rb

To protect against this state leakage, we now:

  - reset the Puppet::Node terminus before each test in
    spec/integration/node_spec.rb to ensure we are testing a clean
    environment.

  - reset the Puppet::Node, and Puppet::Node::Facts terminus, and
    cache class after each test in spec/unit/application/apply_spec.rb
    to prevent leakage into other tests.

Since the cache class has the same state leakage problem as the
terminus class, but does not have the same ability to lazily populate
the default when set to nil, we remove the test.  Testing the default
for the cache class would require running the test before all other
tests to ensure there is no state pollution.n
</pre>
</div>
</content>
</entry>
<entry>
<title>maint: Fix order dependent spec failure</title>
<updated>2011-08-15T18:25:37+00:00</updated>
<author>
<name>Matt Robinson</name>
<email>matt@puppetlabs.com</email>
</author>
<published>2011-08-15T18:25:37+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=39116d4a6ed4861e46b16ba26c679a8b346fca00'/>
<id>39116d4a6ed4861e46b16ba26c679a8b346fca00</id>
<content type='text'>
Since the cacher was removed in master the indirection's terminus class
no longer gets reset between tests by clearing the cache.  This meant
that one spec was setting the cache_class and affecting another spec,
causing failures.

Now that test manually resets its indirection related info.

Reviewed-by: Nick Lewis &lt;nick@puppetlabs.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since the cacher was removed in master the indirection's terminus class
no longer gets reset between tests by clearing the cache.  This meant
that one spec was setting the cache_class and affecting another spec,
causing failures.

Now that test manually resets its indirection related info.

Reviewed-by: Nick Lewis &lt;nick@puppetlabs.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '2.7.x'</title>
<updated>2011-08-15T17:36:03+00:00</updated>
<author>
<name>Matt Robinson</name>
<email>matt@puppetlabs.com</email>
</author>
<published>2011-08-15T17:36:03+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=e7d5c7c1cd4109d7bb061a503f5da8777a1be66d'/>
<id>e7d5c7c1cd4109d7bb061a503f5da8777a1be66d</id>
<content type='text'>
* 2.7.x: (25 commits)
  (#4411) Explain that runinterval = 0 does not mean "never run"
  Maint: Fix missing option text in puppet agent and arrange options alphabetically
  (#8302) Improve documentation of exec providers
  (#7853) Clarify and complete docs for the tagmail report processor
  Maint: Mention that audit metaparameter will accept "all"
  Maint: Adjust wording for file type's content parameter
  Maint: Fix poor documentation for versioncmp function.
  maint: Fix case sensitive require
  maint: Add inspect app options to help
  maint: Fix inspect help
  Increment lib/puppet.rb VERSION string
  Updated CHANGELOG for 2.7.3rc1
  (#4762) Ensure that clients on the moon can successfully connect.
  Add document outlining preferred contribution methods
  Add document outlining preferred contribution methods
  Add document outlining preferred contribution methods
  Revert "Merge branch 'vcsrepo'"
  Revert "Merge branch 'vcsrepo'"
  Updating CHANGELOG for 2.7.2rc3
  (#8704) Give better errors for invalid fileserver.conf
  ...

Manually Resolved Conflicts:
	lib/puppet/parser/functions/versioncmp.rb
	spec/integration/node/facts_spec.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* 2.7.x: (25 commits)
  (#4411) Explain that runinterval = 0 does not mean "never run"
  Maint: Fix missing option text in puppet agent and arrange options alphabetically
  (#8302) Improve documentation of exec providers
  (#7853) Clarify and complete docs for the tagmail report processor
  Maint: Mention that audit metaparameter will accept "all"
  Maint: Adjust wording for file type's content parameter
  Maint: Fix poor documentation for versioncmp function.
  maint: Fix case sensitive require
  maint: Add inspect app options to help
  maint: Fix inspect help
  Increment lib/puppet.rb VERSION string
  Updated CHANGELOG for 2.7.3rc1
  (#4762) Ensure that clients on the moon can successfully connect.
  Add document outlining preferred contribution methods
  Add document outlining preferred contribution methods
  Add document outlining preferred contribution methods
  Revert "Merge branch 'vcsrepo'"
  Revert "Merge branch 'vcsrepo'"
  Updating CHANGELOG for 2.7.2rc3
  (#8704) Give better errors for invalid fileserver.conf
  ...

Manually Resolved Conflicts:
	lib/puppet/parser/functions/versioncmp.rb
	spec/integration/node/facts_spec.rb
</pre>
</div>
</content>
</entry>
<entry>
<title>(#8740) Do not enumerate files in the root directory.</title>
<updated>2011-08-11T22:02:45+00:00</updated>
<author>
<name>Josh Cooper</name>
<email>josh@puppetlabs.com</email>
</author>
<published>2011-08-10T23:20:00+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=d7c9c765dbf28df3631e709832c44c343569cb53'/>
<id>d7c9c765dbf28df3631e709832c44c343569cb53</id>
<content type='text'>
Previously the command 'puppet resource file' would enumerate all files
in the root directory, and generate an exception if the file type was
not a directory, file, or link. Worse, it would also do this when a file
or directory was specified, e.g. 'puppet resource file /etc/hosts'.

Ideally, the find method of the ral terminus should not need to call the
type's instances class method, instead just creating an instance of the
type with the specified name and parameters. However, some types, like
package, depend on this behavior. The type walks all providers and all
instances that they provide, checking to see if the provider provides an
instance with that name, and also warning if another provider provides
an instance with the same name.

Also, ideally, puppet should not blow up when encountering an
unsupported file type, e.g. Unix domain socket, but that would be too
big of a change for 2.6.x.

This commit changes 'puppet resource file' to return a message saying
that the operation is not supported:

    Listing all file instances is not supported.  Please specify a file
    or directory, e.g. puppet resource file /etc

The change is bit of a hack, as ideally, the file type's instances
method could raise an exception when called in a 'search' context, but
return an empty array in a 'find' context. But that also would be too
big of a change for 2.6.x.

This commit also adds spec tests for the resource application and file
type, as well as an acceptance test, which creates a Unix domain socket
in the root directory, while running 'puppet resource file'.

Paired-with: Nick Lewis &lt;nick@puppetlabs.com&gt;
Reviewed-by: Jacob Helwig &lt;jacob@puppetlabs.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously the command 'puppet resource file' would enumerate all files
in the root directory, and generate an exception if the file type was
not a directory, file, or link. Worse, it would also do this when a file
or directory was specified, e.g. 'puppet resource file /etc/hosts'.

Ideally, the find method of the ral terminus should not need to call the
type's instances class method, instead just creating an instance of the
type with the specified name and parameters. However, some types, like
package, depend on this behavior. The type walks all providers and all
instances that they provide, checking to see if the provider provides an
instance with that name, and also warning if another provider provides
an instance with the same name.

Also, ideally, puppet should not blow up when encountering an
unsupported file type, e.g. Unix domain socket, but that would be too
big of a change for 2.6.x.

This commit changes 'puppet resource file' to return a message saying
that the operation is not supported:

    Listing all file instances is not supported.  Please specify a file
    or directory, e.g. puppet resource file /etc

The change is bit of a hack, as ideally, the file type's instances
method could raise an exception when called in a 'search' context, but
return an empty array in a 'find' context. But that also would be too
big of a change for 2.6.x.

This commit also adds spec tests for the resource application and file
type, as well as an acceptance test, which creates a Unix domain socket
in the root directory, while running 'puppet resource file'.

Paired-with: Nick Lewis &lt;nick@puppetlabs.com&gt;
Reviewed-by: Jacob Helwig &lt;jacob@puppetlabs.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>(Maint.) Fix spec failures related to leaking state.</title>
<updated>2011-07-28T20:12:58+00:00</updated>
<author>
<name>Pieter van de Bruggen</name>
<email>pieter@puppetlabs.com</email>
</author>
<published>2011-07-28T20:12:58+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=bff817c5bea1a1b298a81d5aa4f28c2789125286'/>
<id>bff817c5bea1a1b298a81d5aa4f28c2789125286</id>
<content type='text'>
The `node clean` code has introduced a systematic change in
state which is not uniformly protected against by the tests.

As these order dependent failures arise, we should refactor
the tests to be more robust.

Reviewed-By: Matt Robinson</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The `node clean` code has introduced a systematic change in
state which is not uniformly protected against by the tests.

As these order dependent failures arise, we should refactor
the tests to be more robust.

Reviewed-By: Matt Robinson</pre>
</div>
</content>
</entry>
<entry>
<title>(#8392) Disable master related tests on Windows</title>
<updated>2011-07-27T22:09:32+00:00</updated>
<author>
<name>Jacob Helwig</name>
<email>jacob@puppetlabs.com</email>
</author>
<published>2011-07-12T22:26:32+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/ricky/public_git/puppet.git/commit/?id=a521b99b2267e4c2588ceb6b90d36cab5af83aa6'/>
<id>a521b99b2267e4c2588ceb6b90d36cab5af83aa6</id>
<content type='text'>
The master, and queue applications are not used for agent
functionality and since only agent functionality is supported on
Windows, these tests do not need to run.

Reviewed-by: Josh Cooper &lt;josh@puppetlabs.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The master, and queue applications are not used for agent
functionality and since only agent functionality is supported on
Windows, these tests do not need to run.

Reviewed-by: Josh Cooper &lt;josh@puppetlabs.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
