This class was using Util::Cacher for its singleton instance, when that was
unnecessary. The FileServing::Configuration instance already manages whether or
not to reparse its config file, based on whether it has changed. Thus, there is
no need for it to be manually expired via the cacher.

Reviewed-By: Jacob Helwig <jacob@puppetlabs.com>
(cherry picked from commit 4bad729f56c26d8154cd0f20614fa4e478de9d40)

For a while Luke, and other authors, injected a created tag, copyright
statement, and "All rights reserved" into every new file they added to the
Puppet project.

This isn't really true, and we have a global license covering the code, so
we have now stripped out all those old tags.

Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>

This implement support for options with default values, allowing faces to set
those values when not invoked.  This can eliminate substantial duplicate code
from actions, especially when there are face-level options in use.

Reviewed-By: Pieter van de Bruggen <pieter@puppetlabs.com>

The problem was caused by the fact that the
options method returns a list of options that
treated the aliases as seperate options.

The fix is to only maintain a list of options
and not add all aliases to the options list.

Pre-released versions of faces may have used the "desc" option, which
was later changed to "description", and an alias provided for "desc". The
previous fix for 8048 removed this backwards compatibility (since it was
never released to customers). This commit fixes the test case that
assumed the "desc" option was still available.

Reviewed-By: Daniel Pittman <daniel@puppetlabs.com>

Previously, we were adding ellipsis to any short_description, which was
misleading; they were only necessary when we were truncating in the _middle_ of
a paragraph.

This commit changes the behavior, and updates the tests to show when we expect
ellipsis.

Paired-with: Matt Robinson <matt@puppetlabs.com>

Add the ability to download a file into the local filebucket using a puppet
URI or from disk.  Also, the ability to store into the filebucket.

These provide at least basic UI for moving data around using the filebucket
service, and act as an example of how further work can be done.

Also, update the code to eliminate a couple of redundant checks on arguments,
and add some basic testing around the actions.  Mostly only that they exist,
at this point.

Reviewed-By: Daniel Pittman <daniel@puppetlabs.com>

We now strip whitespace in face (and related) documentation in two places:

We strip any trailing whitespace on each line, just because.

We strip any leading indent, but not all leading whitespace, from the text.
That is, we strip the *minimum* amount of whitespace that we can take from
every line in the documentation without changing the overall content.

Reviewed-By: Pieter van de Bruggen <pieter@puppetlabs.com>