puppet.git/spec/lib/puppet_spec, branch master

Consolidate test logic determining if a registered file is in the temp directory

2011-08-02T23:33:47+00:00

Previously, we were always using string comparisons, and hard-coded
paths to temp locations on non-Windows platforms.  This was
problematic for a few reasons.  We had to maintain a list of temp
locations for the various platforms, and the string comparisons were
unreliable on Windows, since paths have two string representations
(the "short" name containing a ~ followed by a number, and the "full"
name).

By getting the current temp location using Dir.tempdir (the same
mechanism our temp creation code uses), we no longer need to maintain
the list of temp locations.  Also, rather than doing string
comparisons on file paths, we can use a combination of
Pathname#ascend, and File.identical? to determine if the path
registered as a temp file for deletion was actually created in the
temp location.

With this refactoring, the same code now works for both Windows, and
non-Windows platforms.

Reviewed-by: Nick Lewis

Fix tests with "relative" paths on Windows

2011-07-19T21:06:36+00:00

Absolute paths on Unix, e.g. /foo/bar, are not absolute on Windows,
which breaks many test cases. This commit adds a method to
PuppetSpec::Files.make_absolute that makes the path absolute in
test cases.

On Unix (Puppet.features.posix?) it is a no-op. On Windows,
(Puppet.features.microsoft_windows?) the drive from the current
 working directory is prepended.

Reviewed-by: Jacob Helwig

maint: add a 'print' matcher to rspec, to inspect std{out,err}

2011-04-28T21:50:12+00:00

You can now write expectations along the lines of:

  expect { ... }.to print /whatever/

This will do the expected thing, which is to require that we print something
matching that regular expression during the block.  The output itself is
suppressed during operation of the matcher.

Paired-With: Max Martin

maint: clean up the spec test headers in bulk.

2011-04-13T07:36:38+00:00

We now use a shebang of: #!/usr/bin/env rspec

This enables the direct execution of spec tests again, which was lost earlier
during the transition to more directly using the rspec2 runtime environment.

maint: use FileUtil to remove files, not exec

2011-04-08T22:17:55+00:00

We used to shell out to chmod and rm to clean up temporary files; this lead to
the cleanup method here being one of the largest consumers of walltime.
Replacing that with FileUtil calls is as, or more, secure, and performs
sufficiently well that we can just delegate.

Reviewed-By: Matt Robinson

Merge branch '2.6.next' into next

2011-03-23T21:32:59+00:00

* 2.6.next:
  Fixed #6562 - Minor kick documentation fix
  (#6658) Propagate ENC connection errors to the agent
  (#4884) Remove typo from spec test
  (#4884) Modify tests to pass on non-OS X systems
  (#4884) Revise new exec tests, add a few more
  (#4884) Add an shell provider for execs
  (#4884) Fix Test::Unit exec tests
  (#4884) Break the exec type out to have a posix provider
  (#4884) Add consistent path validation and behavior
  (#4884) Add expand_path to requiring the spec_helper
  (#4884) Autorequire shared behaviors and method to silence warnings
  (#4884) Fix whitespace
  (#4884) Get rid of open3 require since it wasn't being used
  (#5814) Improved cron type specs
  (#5814) cron_spec shouldn't depend on cron provider

Manually Resolved Conflicts:
	lib/puppet/util/command_line/puppetrun
	spec/spec_helper.rb
	spec/unit/type/exec_spec.rb
	spec/unit/type_spec.rb
	test/ral/type/exec.rb

(#4884) Autorequire shared behaviors and method to silence warnings

2011-03-15T18:55:58+00:00

with_verbose_disabled allows you to run tests that muck with constans
without getting spammy warnings.

Reviewed-by: Max Martin and Matt Robinson

(#6582) Don't demand the checkout be named 'puppet'.

2011-03-04T02:11:57+00:00

As part of implementing the fixture support I hard-coded the assumption that
the git checkout was a directory named 'puppet'; this broke on our CI server,
and would break for anyone else who didn't follow that default.

This commit eliminates that assumption and depends only on the appropriate
part of the input filename.

Reviewed-By: Paul Berry

(#6582) move more helper code into methods, out of RSpec#configure

2011-03-04T00:29:24+00:00

We move the tempfile cleanup support off into the module that uses it, which
removes some of the dependency on magic globals from configure.  It still
exists, but is hidden in the same module that uses it, which helps.

Reviewed-By: Nick Lewis

(#6582) add fixture helper methods to replace unit test code.

2011-03-04T00:29:07+00:00

We validate that fixtures exist, when requested, or that they match something
when they use a glob.  This catches internal errors where we don't match any
fixtures with a glob; this can reveal problems that would otherwise avoid all
assertions and result in internal failures.

The code is hidden out in a module, included in the main RSpec namespace.
This doesn't clean up the API any, but it isolates the code more effectively
and keeps the configuration file cleaner.

Reviewed-By: Nick Lewis