The instance method now behaves like the prefetch method: After parsing
/etc/(v)fstab run mount to update the ensure state from either
:unmounted to :mounted and from :absent to :ghost

Reviewed-By: Nick Lewis
Reviewed-By: Josh Cooper

Facter[:operatingsystem] will not retrieve the operatingsystem as a
string so puppet will always write fstab entries.

There were two problems:

* In lib/puppet/type/mount.rb, we were calling provider.mounted? to
  determine whether we needed to execute "mount" after updating the
  in-memory fstab record.  This wasn't working properly because
  provider.mounted? makes its decision based on the data stored in the
  in-memory fstab record.  Since the fstab record had just been
  updated, provider.mounted? was incorrectly returning true even
  though the device wasn't actually mounted.  Fixed this by checking
  provider.mounted? before updating the in-memory fstab record.

* Calling mount from this point in lib/puppet/type/mount.rb is
  actually too early, because even though the in-memory fstab record
  has been created, its contents have not been written to `/etc/fstab`
  yet.  Fixed this by storing a :needs_mount entry in the
  property_hash and checking it at the end of the flush() method.

Reviewed-by: Jacob Helwig <jacob@puppetlabs.com>

* ticket/2.6.x/4914:
  (#4914) Improved stubbing in mount/parsed_spec tests.
  (#4914) Improved parsed_spec for mount
  (#4914) Remove mount specs
  (#4914) Specs for mounted? match new behaviour
  (#4914) Add specs for modified mount provider
  (#4914) Add specs for modified mount type
  (#4914) Update property blocks
  (#4914) Query property_hash for mountstate
  (#4914) Prefetch mountstate
  (#4914) Join lines for better readability

Conflicts:
	lib/puppet/provider/mount.rb
	lib/puppet/provider/mount/parsed.rb
	spec/unit/provider/mount/parsed_spec.rb
	spec/unit/provider/mount_spec.rb
	spec/unit/type/mount_spec.rb

Add specs for the new prefetching and the correct parsing of vfstab on
Solaris and fstab on other systems

Paired-with: Jesse Wolfe <jesse@puppetlabs.com>

Add a method mountinstances that returns a list of currently mounted
filesystems and overwrite prefetch to update the :ensure state of a
mount resource to either
- :absent    => not in fstab and not mounted
- :unmounted => in fstab but not mounted
- :mounted   => in fstab and mounted
- :ghost     => not in fstab but mounted

This is just one step towards 4914. Next will be query the property_hash
when asking mounted? and update the insync? methods to handle the
different states.

Replaced 106806 occurances of ^( +)(.*$) with

The ruby community almost universally (i.e. everyone but Luke, Markus, and the other eleven people
who learned ruby in the 1900s) uses two-space indentation.

3 Examples:

    The code:
        end

        # Tell getopt which arguments are valid
        def test_get_getopt_args
            element = Setting.new :name => "foo", :desc => "anything", :settings => Puppet::Util::Settings.new
            assert_equal([["--foo", GetoptLong::REQUIRED_ARGUMENT]], element.getopt_args, "Did not produce appropriate getopt args")

    becomes:
        end

        # Tell getopt which arguments are valid
        def test_get_getopt_args
          element = Setting.new :name => "foo", :desc => "anything", :settings => Puppet::Util::Settings.new
          assert_equal([["--foo", GetoptLong::REQUIRED_ARGUMENT]], element.getopt_args, "Did not produce appropriate getopt args")

    The code:
            assert_equal(str, val)

            assert_instance_of(Float, result)

        end

        # Now test it with a passed object
    becomes:
          assert_equal(str, val)

          assert_instance_of(Float, result)

        end

        # Now test it with a passed object
    The code:
        end

        assert_nothing_raised do
            klass[:Yay] = "boo"
            klass["Cool"] = :yayness
        end

    becomes:
        end

        assert_nothing_raised do
          klass[:Yay] = "boo"
          klass["Cool"] = :yayness
        end