From af4947c603b8f6610d861f303a7813cbc5ecf5e7 Mon Sep 17 00:00:00 2001 From: Jacob Helwig Date: Mon, 28 Mar 2011 11:08:29 -0700 Subject: (#6862) Add a default subject for the mail_patches rake task This will prevent committers to forget to write cover letter subject when rake mail_patches needs to send multiple e-mails. It defaults to the "type" and "branch name" of the patch-set. This is taken from Brice's patch against Puppet (37f9ca09135330ed180fb68d9295a4967a5cc857). Signed-off-by: Brice Figureau --- tasks/rake/mail_patches.rake | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tasks/rake/mail_patches.rake b/tasks/rake/mail_patches.rake index be8dda1..1346faa 100644 --- a/tasks/rake/mail_patches.rake +++ b/tasks/rake/mail_patches.rake @@ -34,12 +34,14 @@ task :mail_patches do # If we've got more than one patch, add --compose if files.length > 1 compose = "--compose" + subject = %Q{--subject "#{type} #{name} against #{parent}"} else compose = "" + subject = "" end # Now send the mail. - sh "git send-email #{compose} --no-signed-off-by-cc --suppress-from --to puppet-dev@googlegroups.com 00*.patch" + sh "git send-email #{compose} #{subject} --no-signed-off-by-cc --suppress-from --to puppet-dev@googlegroups.com 00*.patch" # Finally, clean up the patches sh "rm 00*.patch" -- cgit