| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Thanks to Benedikt Bohm for the fix.
|
|
|
|
| |
Based on initial patch by James Turnbull
|
|
|
|
|
|
|
|
| |
This patch removes the relationship between the domain fact and LDAP/NIS domains.
domain fact relates to DNS domain - this will avoid the confusion caused
by the LDAP/NIS domain (which might be different to the DNS domain name).
Additionally, if hostname is already in long form, it won't try to build
the fqdn fact from hostname and domain.
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1.
This has broken master for some facts (eg OS X facts), it also breaks facter
platform support on win32 as popen3 does not work there.
I'd like to get master working, backlog of patches applied and revisit exec.
Paul
|
|
|
|
| |
This adds a test to ensure we are not prematurely splitting on Handle
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
In addition to the stripping of the output of these facts this patchset:
Refactor - Extracted function to enable easier testing.
Tests - data driven tests for the dmidecode/smbios fact.
Paul
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So far messages to stderr haven't been catched by
Facter::Util::Resolution.exec and were insted printed out to
stderr. This will cause facter and even puppet to print to stderr
themself, which is not very nice when running puppetd by cron,
as you might get every run a mail if a command outputs to stderr.
We are now wrapping the command execution with Open3.popen3 to
catch stderr and passing them to the new introduced Facter.warn
method.
We are also catching multiline outputs chomping newlines and
returning an array if there have been more than one line. Otherwise
we return an array containing the different lines.
This prevents in general cases as described in #2766 and should
handle command execution in a bit saner way.
|
|
|
|
|
| |
We can now warn messages that will be passed to Kernel.warn if
debugging is enabled.
|
| |
|
| |
|
|
|
|
|
|
| |
Fix facts added with empty blocks by handling calls to value when setcode not called
Ensure we handle load failures more gracefully
|
|
|
|
|
|
|
|
|
| |
This cleans up xen and vserver detection to enable us to stub out so when we
happen to be running tests on xen we don't report as that.
More cleanup is needed in this area but this should give us a green build.
This renames the tests to be consistent with current naming convention
|
| |
|
| |
|
|
|
|
| |
fact's value when collection has not being yet initialized.
|
|
|
|
|
| |
Solaris orders inet and inet6 seperately. This tests for and fixes this by
uniqueing the list. Will probably need work when we get to ipv6 support.
|
|
|
|
|
|
| |
coverage
switch %x{} call to Facter::Util::Resolution.exec for better testing
|
|\ |
|
| |
| |
| |
| | |
Add tests and utility for virtual fact detection
|
| | |
|
|/
|
|
| |
Use OpenBSD sysctl for manufacturer facts.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Patch from Todd Zullinger, rebased.
Merge branch 'cleanup-operatingsystemrelease' of git://jet.mox.net/~tmz/facter
into tickets/master/2060
Conflicts:
lib/facter/operatingsystemrelease.rb
|
| |
| |
| |
| |
| |
| | |
This allows operatingsystemrelease to properly determine the release for
various Red Hat based distros, including the point portion of the
release.
|
| |
| |
| |
| | |
These operating systems all use a similar format for the release file.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Facter #2120 - Solaris support for Facter[virtual]
This reverts commit 56760d34f070db4d7bb8e5fcfb7939fe3074bf49.
This patch is broken as $? global will report last run process in the case of
no vmware-checkvm binary
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The previous check for /5/ matched releases like 4.5, which is not the
intent. The previous check was introduced in 095eb15e, and changed the
pattern from /^5^/. Using /^5/ to match when the release begins with 5
seems saner.
Signed-off-by: Paul Nasrat <pnasrat@googlemail.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
On older CentOS releases, a sed command is used to parse the release
number from /etc/redhat-release. However, the command lacked the proper
amount of backslashes to escape the parenthesis.
Signed-off-by: Paul Nasrat <pnasrat@googlemail.com>
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Initial support for virtual vmware fact on Solaris
Tested on VMWare Fusion and OpenSolaris
Paul
|
| |
| |
| |
| |
| |
| | |
This corrects the architecture results for Gentoo on x86 and amd64
Patch from redmine
|
| |
| |
| |
| | |
vserver detection
|
| |
| |
| |
| |
| |
| |
| |
| | |
Added tests for operatingsystem fact covering the two simple cases and a test
for this specific interaction of release files
We should take some time to add tests when we're adding or changing new
operatingsystem facts
|
| |
| |
| |
| | |
and other facts)
|
| |
| |
| |
| | |
Added a test to pickup typo and fix
|
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes up the syntax so that we can get 1.5.5 out, I've not done tests for
this as we need to fixup the number of time we call out to ifconfig and the
duplication with ip.rb.
Paul
|
| | |
|
| | |
|
| |
| |
| |
| | |
operatingsystem and operatingsystemrelease
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
The interface collection regex was leaving trailing
':' characters on the interface names, which meant
individual interfaces weren't quite right.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
this ensures we can compare all kind of objects and
not only instances of strings.
It compares strings in a case-insensitive manner and converts
symbols to strings.
introducing this behavior required that we introduce
a convert util method, to ensure that we convert the value
correctly. Introduced this method in other places as well.
This behavior change requires that we drop one test, which have
become anyway deprecated.
|
| | |
|