| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/
|
|
|
|
|
|
|
| |
The 2nd regex (with the 0x\d+) got removed because it appears
to never be used, even on SunOS, for which it has been
introduced (99833a1b / #1793).
The 3dn regex is changed to clearly confine the value between
mandatory newlines/whitespaces.
|
|
|
|
| |
Includes Rspec tests
|
|
|
|
|
|
|
|
|
|
| |
This patch is originally by Daniel Berger <djberg96@gmail.com>, I
changed using Facter.value instead of repeatedly testing
Config['host_os'], removed Resolution::which, and fixed the specs.
Thanks to Paul Nasrat for helping with cross-platform debugging.
Signed-off-by: David Schmitt <david@dasz.at>
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Splitting dmi output on the string "/^Handle/" didn't work, and
caused the function to match the wrong key if it was found more
than once.
The intended behaviour of the function is restored by splitting
the dmi output on the regex /^Handle/.
|
|
|
|
| |
Thanks to Tim Sharpe for the fix
|
|
|
|
| |
Thanks to Pavol Dilung for the fix.
|
|
|
|
| |
Based on initial patch by James Turnbull
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1.
This has broken master for some facts (eg OS X facts), it also breaks facter
platform support on win32 as popen3 does not work there.
I'd like to get master working, backlog of patches applied and revisit exec.
Paul
|
|
|
|
| |
This adds a test to ensure we are not prematurely splitting on Handle
|
| |
|
|
|
|
|
|
|
|
|
| |
In addition to the stripping of the output of these facts this patchset:
Refactor - Extracted function to enable easier testing.
Tests - data driven tests for the dmidecode/smbios fact.
Paul
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So far messages to stderr haven't been catched by
Facter::Util::Resolution.exec and were insted printed out to
stderr. This will cause facter and even puppet to print to stderr
themself, which is not very nice when running puppetd by cron,
as you might get every run a mail if a command outputs to stderr.
We are now wrapping the command execution with Open3.popen3 to
catch stderr and passing them to the new introduced Facter.warn
method.
We are also catching multiline outputs chomping newlines and
returning an array if there have been more than one line. Otherwise
we return an array containing the different lines.
This prevents in general cases as described in #2766 and should
handle command execution in a bit saner way.
|
| |
|
|
|
|
|
|
| |
Fix facts added with empty blocks by handling calls to value when setcode not called
Ensure we handle load failures more gracefully
|
|
|
|
|
|
|
|
|
| |
This cleans up xen and vserver detection to enable us to stub out so when we
happen to be running tests on xen we don't report as that.
More cleanup is needed in this area but this should give us a green build.
This renames the tests to be consistent with current naming convention
|
| |
|
|
|
|
|
| |
Solaris orders inet and inet6 seperately. This tests for and fixes this by
uniqueing the list. Will probably need work when we get to ipv6 support.
|
|
|
|
|
|
| |
coverage
switch %x{} call to Facter::Util::Resolution.exec for better testing
|
|\ |
|
| |
| |
| |
| | |
Add tests and utility for virtual fact detection
|
|/
|
|
| |
Use OpenBSD sysctl for manufacturer facts.
|
|
|
|
| |
Added a test to pickup typo and fix
|
| |
|
|
|
|
|
|
|
|
| |
The interface collection regex was leaving trailing
':' characters on the interface names, which meant
individual interfaces weren't quite right.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this ensures we can compare all kind of objects and
not only instances of strings.
It compares strings in a case-insensitive manner and converts
symbols to strings.
introducing this behavior required that we introduce
a convert util method, to ensure that we convert the value
correctly. Introduced this method in other places as well.
This behavior change requires that we drop one test, which have
become anyway deprecated.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Facts that raise exceptions just return nil now.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This name change just reflects the file location.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
|
|
|
| |
Also added tests to the macosx code; it's much cleaner and
actually tested now.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've made the IPMess stuff a lot less messy, and refactored
a lot of the util/ip module, including naming it more sensibly.
The biggest changes are that I moved the big case statement into
a constant and then used a bit of dispatch-style logic to use it,
and I eliminated a bunch of duplicate code in the ipmess.rb file.
Added some test data for FreeBSD and fixed a bug in my map
logic pointed out by Paul Nasrat.
I've also fixed #1846, in that the interface list now s/:/_/g.
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
| |
Signed-off-by: Luke Kanies <luke@madstop.com>
|
| |
|
| |
|