diff options
| author | Jacob Helwig <jacob@puppetlabs.com> | 2011-03-28 11:08:29 -0700 |
|---|---|---|
| committer | Adrien Thebo <adrien.thebo@gmail.com> | 2011-04-01 18:19:11 -0700 |
| commit | af4947c603b8f6610d861f303a7813cbc5ecf5e7 (patch) | |
| tree | bf6737ab5905143b66ade4a453d87b44ca4c12cf | |
| parent | d6967a0630dec168059316426b0eb4228b27e451 (diff) | |
| download | facter-af4947c603b8f6610d861f303a7813cbc5ecf5e7.tar.gz facter-af4947c603b8f6610d861f303a7813cbc5ecf5e7.tar.xz facter-af4947c603b8f6610d861f303a7813cbc5ecf5e7.zip | |
(#6862) Add a default subject for the mail_patches rake task
This will prevent committers to forget to write cover letter subject
when rake mail_patches needs to send multiple e-mails.
It defaults to the "type" and "branch name" of the patch-set.
This is taken from Brice's patch against Puppet
(37f9ca09135330ed180fb68d9295a4967a5cc857).
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
| -rw-r--r-- | tasks/rake/mail_patches.rake | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tasks/rake/mail_patches.rake b/tasks/rake/mail_patches.rake index be8dda1..1346faa 100644 --- a/tasks/rake/mail_patches.rake +++ b/tasks/rake/mail_patches.rake @@ -34,12 +34,14 @@ task :mail_patches do # If we've got more than one patch, add --compose if files.length > 1 compose = "--compose" + subject = %Q{--subject "#{type} #{name} against #{parent}"} else compose = "" + subject = "" end # Now send the mail. - sh "git send-email #{compose} --no-signed-off-by-cc --suppress-from --to puppet-dev@googlegroups.com 00*.patch" + sh "git send-email #{compose} #{subject} --no-signed-off-by-cc --suppress-from --to puppet-dev@googlegroups.com 00*.patch" # Finally, clean up the patches sh "rm 00*.patch" |