From fa333f2d94885df6beb3d7ea29380e28fde651a4 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Tue, 31 Mar 2015 14:23:49 -0400 Subject: Print exceptions when saving data fails in admin UI There were places where a broad exception was caught when saving administrative changes but the actual exception wasn't logged. The user was presented only with a 'Failed to save data!' message. https://fedorahosted.org/ipsilon/ticket/39 Signed-off-by: Rob Crittenden Reviewed-by: Simo Sorce --- ipsilon/providers/saml2/admin.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'ipsilon/providers/saml2/admin.py') diff --git a/ipsilon/providers/saml2/admin.py b/ipsilon/providers/saml2/admin.py index 2503be1..d5a5bdf 100644 --- a/ipsilon/providers/saml2/admin.py +++ b/ipsilon/providers/saml2/admin.py @@ -255,7 +255,8 @@ class SPAdminPage(AdminPage): self.parent.rename_sp(rename[0], rename[1]) message = "Properties successfully changed" message_type = ADMIN_STATUS_OK - except Exception: # pylint: disable=broad-except + except Exception, e: # pylint: disable=broad-except + self.error('Failed to save data: %s' % e) message = "Failed to save data!" message_type = ADMIN_STATUS_ERROR -- cgit