From 05892f92cfcf9e060ce8e01c0448025c77b893bc Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Thu, 7 May 2015 21:12:53 +0000 Subject: pylint 1.4.3 version fixes for tests Fix type() vs isinstance() checks, isinstance is generally a more correct approach to check for classes. Signed-off-by: Rob Crittenden --- tests/helpers/http.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/helpers/http.py b/tests/helpers/http.py index bfa3240..74f1bb9 100755 --- a/tests/helpers/http.py +++ b/tests/helpers/http.py @@ -46,7 +46,7 @@ class PageTree(object): def first_value(self, rule): result = self.tree.xpath(rule) - if type(result) is list: + if isinstance(result, list): if len(result) > 0: result = result[0] else: @@ -55,7 +55,7 @@ class PageTree(object): def all_values(self, rule): result = self.tree.xpath(rule) - if type(result) is list: + if isinstance(result, list): return result return [result] @@ -137,7 +137,7 @@ class HttpSessions(object): return values def handle_login_form(self, idp, page): - if type(page) != PageTree: + if not isinstance(page, PageTree): raise TypeError("Expected PageTree object") srv = self.servers[idp] @@ -167,7 +167,7 @@ class HttpSessions(object): {'headers': headers, 'data': payload}] def handle_return_form(self, page): - if type(page) != PageTree: + if not isinstance(page, PageTree): raise TypeError("Expected PageTree object") try: @@ -193,7 +193,7 @@ class HttpSessions(object): {'headers': headers, 'data': payload}] def handle_openid_form(self, page): - if type(page) != PageTree: + if not isinstance(page, PageTree): raise TypeError("Expected PageTree object") if not page.first_value('//title/text()') == \ @@ -223,7 +223,7 @@ class HttpSessions(object): {'headers': headers, 'data': payload}] def handle_openid_consent_form(self, page): - if type(page) != PageTree: + if not isinstance(page, PageTree): raise TypeError("Expected PageTree object") try: -- cgit