pylint 1.4.3 version fixes

Pylint 1.4.3 completely stopped recognizing the star-args condition.
In order to avoid pylint error with > 1.4.3 stop caring for star-args
and add cmdline option to ignore those errors completly so older pylint
versions are happy too.

Also fix type() vs isinstance() checks, isinstance is generally a more
correct approach to check for classes.

In some 'admin' files the type() -> isinstance() fix required to invert
the order in which ComplexList and MappingList are checked as the latter
is a subclass of ComplexList, so it needs to be checked first otherwise
the check for isinstance(option, ComplexList) matches for both and the
code stops functioning properly.

Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Rob Crittenden <rcritten@redhat.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/ipsilon/tools/files.py b/ipsilon/tools/files.py
index 5847654..857a2fe 100644
--- a/ipsilon/tools/files.py
+++ b/ipsilon/tools/files.py
@@ -39,6 +39,6 @@ def fix_user_dirs(path, user=None, mode=0700):
 def write_from_template(destfile, template, opts):
     with open(template) as f:
         t = Template(f.read())
-    text = t.substitute(**opts)  # pylint: disable=star-args
+    text = t.substitute(**opts)
     with open(destfile, 'w+') as f:
         f.write(text)