summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick Uiterwijk <puiterwijk@redhat.com>2015-04-27 22:22:05 +0200
committerPatrick Uiterwijk <puiterwijk@redhat.com>2015-04-28 20:52:43 +0200
commitba45934659346510966ca6c58a01dbba3eca7d2f (patch)
tree11b9492aace84c5ae2eaa4c0a03aa44a27da94b5
parentb6c7d218162bdcf4b5a23f9840362ccae5af46c1 (diff)
downloadipsilon.git-ba45934659346510966ca6c58a01dbba3eca7d2f.tar.gz
ipsilon.git-ba45934659346510966ca6c58a01dbba3eca7d2f.tar.xz
ipsilon.git-ba45934659346510966ca6c58a01dbba3eca7d2f.zip
Fix OpenID AX extension bug
This makes sure that _display returns a dict, and that the result from _resp can still be passed to addExtension Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com> Reviewed-by: Rob Crittenden <rcritten@redhat.com>
-rw-r--r--ipsilon/providers/openid/extensions/ax.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/ipsilon/providers/openid/extensions/ax.py b/ipsilon/providers/openid/extensions/ax.py
index 10c3bb7..bf63d25 100644
--- a/ipsilon/providers/openid/extensions/ax.py
+++ b/ipsilon/providers/openid/extensions/ax.py
@@ -35,7 +35,7 @@ class OpenidExtension(OpenidExtensionBase):
def _resp(self, request, userdata):
req = ax.FetchRequest.fromOpenIDRequest(request)
if req is None:
- return {}
+ return None
resp = ax.FetchResponse(req)
for name in req.requested_attributes:
try:
@@ -50,6 +50,8 @@ class OpenidExtension(OpenidExtensionBase):
def _display(self, request, userdata):
resp = self._resp(request, userdata)
+ if resp is None:
+ return {}
data = dict()
for name, value in resp.data.items():
key = name