From 623abc6bdff15a77fc14eac9dc1af975e9d98b2f Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Tue, 30 Nov 2010 17:00:54 -0500 Subject: Properly quote passwords sent to pkisilent so special characters work. Also check for url-encoded passwords before logging them. ticket 324 --- ipapython/ipautil.py | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'ipapython/ipautil.py') diff --git a/ipapython/ipautil.py b/ipapython/ipautil.py index 9a3e8a6a..236de51f 100644 --- a/ipapython/ipautil.py +++ b/ipapython/ipautil.py @@ -28,6 +28,7 @@ import random import os, sys, traceback, readline import stat import shutil +import urllib2 from ipapython import ipavalidate from types import * @@ -129,6 +130,10 @@ def run(args, stdin=None, raiseonerr=True, nolog=(), env=None): args = args.replace(value, 'XXXXXXXX') stdout = stdout.replace(value, 'XXXXXXXX') stderr = stderr.replace(value, 'XXXXXXXX') + quoted = urllib2.quote(value) + args = args.replace(quoted, 'XXXXXXXX') + stdout = stdout.replace(quoted, 'XXXXXXXX') + stderr = stderr.replace(quoted, 'XXXXXXXX') logging.info('args=%s' % args) logging.info('stdout=%s' % stdout) logging.info('stderr=%s' % stderr) -- cgit